Patchwork task-core-lsb: Don't pull in eglibc-pic via RDEPENDS

login
register
mail settings
Submitter Andy Ross
Date Aug. 14, 2012, 10:44 p.m.
Message ID <1344984262-31589-1-git-send-email-andy.ross@windriver.com>
Download mbox | patch
Permalink /patch/34621/
State Accepted
Commit 79545d068659c943ac9aa925a7da0eee82207b8b
Headers show

Comments

Andy Ross - Aug. 14, 2012, 10:44 p.m.
The task-core-lsb-runtime-add subpackage includes eglibc-pic as an
RDEPEND.  That's incorrect, eglibc-pic is nothing but 22MB of static
libraries and should never appear as a runtime dependency.

Signed-off-by: Andy Ross <andy.ross@windriver.com>
---
 meta/recipes-extended/tasks/task-core-lsb.bb | 1 -
 1 file changed, 1 deletion(-)
Koen Kooi - Aug. 15, 2012, 7:38 a.m.
Op 15 aug. 2012, om 00:44 heeft Andy Ross <andy.ross@windriver.com> het volgende geschreven:

> The task-core-lsb-runtime-add subpackage includes eglibc-pic as an
> RDEPEND.  That's incorrect, eglibc-pic is nothing but 22MB of static
> libraries and should never appear as a runtime dependency.
> 
> Signed-off-by: Andy Ross <andy.ross@windriver.com>
> ---
> meta/recipes-extended/tasks/task-core-lsb.bb | 1 -
> 1 file changed, 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/tasks/task-core-lsb.bb b/meta/recipes-extended/tasks/task-core-lsb.bb
> index 553b89e..be9eac2 100644
> --- a/meta/recipes-extended/tasks/task-core-lsb.bb
> +++ b/meta/recipes-extended/tasks/task-core-lsb.bb
> @@ -194,7 +194,6 @@ RDEPENDS_task-core-lsb-runtime-add = "\
>     eglibc-localedata-posix \
>     eglibc-extra-nss \
>     eglibc-pcprofile \
> -    eglibc-pic \
>     eglibc-utils \
> "


MIssing PR bump
Richard Purdie - Aug. 15, 2012, 1:51 p.m.
On Tue, 2012-08-14 at 15:44 -0700, Andy Ross wrote:
> The task-core-lsb-runtime-add subpackage includes eglibc-pic as an
> RDEPEND.  That's incorrect, eglibc-pic is nothing but 22MB of static
> libraries and should never appear as a runtime dependency.
> 
> Signed-off-by: Andy Ross <andy.ross@windriver.com>
> ---
>  meta/recipes-extended/tasks/task-core-lsb.bb | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/tasks/task-core-lsb.bb b/meta/recipes-extended/tasks/task-core-lsb.bb
> index 553b89e..be9eac2 100644
> --- a/meta/recipes-extended/tasks/task-core-lsb.bb
> +++ b/meta/recipes-extended/tasks/task-core-lsb.bb
> @@ -194,7 +194,6 @@ RDEPENDS_task-core-lsb-runtime-add = "\
>      eglibc-localedata-posix \
>      eglibc-extra-nss \
>      eglibc-pcprofile \
> -    eglibc-pic \
>      eglibc-utils \
>  "

Are files in that package required in order to pass LSB tests?

I'm fine with removing it if it isn't required but I would like that
confirmation before we merge this.

Cheers,

Richard
Andy Ross - Aug. 15, 2012, 3:37 p.m.
On 08/15/2012 06:51 AM, Richard Purdie wrote:
> Are files in that package required in order to pass LSB tests?
>
> I'm fine with removing it if it isn't required but I would like that
> confirmation before we merge this.

I can't speak to the test suites, but these files are eglibc-specific, so
it's hard to imagine them being required by the LSB.

Doing some checking, it arrived in commit 472f89de ("task-poky-lsb:
Add packges needed by LSB Test Suite") along with a bunch of other
eglibc subpackages.  My guess, noting that the development packages
were *not* added, is it got added by mistake.  I'll dig around.

Andy
Phil Blundell - Aug. 15, 2012, 3:41 p.m.
On Wed, 2012-08-15 at 08:37 -0700, Andy Ross wrote:
> On 08/15/2012 06:51 AM, Richard Purdie wrote:
> > Are files in that package required in order to pass LSB tests?
> >
> > I'm fine with removing it if it isn't required but I would like that
> > confirmation before we merge this.
> 
> I can't speak to the test suites, but these files are eglibc-specific, so
> it's hard to imagine them being required by the LSB.

Agreed, libc-pic is a pretty fringe requirement and, bizarre though the
LSB demands can be at times, I would be startled if they called for
it.  

To be honest I'm not convinced we ought to be even building that package
by default -- afaik, the only thing that uses it is mklibs.

p.
Andy Ross - Aug. 15, 2012, 3:58 p.m.
On 08/15/2012 12:38 AM, Koen Kooi wrote:
> MIssing PR bump

Oops, fixed.

Andy

Patch

diff --git a/meta/recipes-extended/tasks/task-core-lsb.bb b/meta/recipes-extended/tasks/task-core-lsb.bb
index 553b89e..be9eac2 100644
--- a/meta/recipes-extended/tasks/task-core-lsb.bb
+++ b/meta/recipes-extended/tasks/task-core-lsb.bb
@@ -194,7 +194,6 @@  RDEPENDS_task-core-lsb-runtime-add = "\
     eglibc-localedata-posix \
     eglibc-extra-nss \
     eglibc-pcprofile \
-    eglibc-pic \
     eglibc-utils \
 "