Patchwork [RFC,v2] plowshare: Add Git version (initial recipe)

login
register
mail settings
Submitter Matthieu
Date Aug. 14, 2012, 12:50 p.m.
Message ID <CAL2sKTm8xG5o7MfWiALcXrzTsvqk-vR0VmkJbC4Wt4ecCZVxPQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/34605/
State Changes Requested, archived
Headers show

Comments

Matthieu - Aug. 14, 2012, 12:50 p.m.
Add recipe for plowshare (git repository).

v2:
- fix big mistake DEPENDS => RDEPENDS
- set SRCREV to empty string
- keep PE=1 to respect upstream scheme

Signed-off-by: Matthieu Crapet <mcrapet@gmail.com>
---
 meta/recipes-support/plowshare/plowshare_git.bb |   27
+++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 meta/recipes-support/plowshare/plowshare_git.bb

+}
--
1.7.9.5
ml@communistcode.co.uk - Aug. 14, 2012, 5:40 p.m.
On 14/08/2012 13:50, Matthieu wrote:
> Add recipe for plowshare (git repository).
>
> v2:
> - fix big mistake DEPENDS => RDEPENDS
> - set SRCREV to empty string
> - keep PE=1 to respect upstream scheme
>
> Signed-off-by: Matthieu Crapet <mcrapet@gmail.com>
> ---
>   meta/recipes-support/plowshare/plowshare_git.bb |   27
> +++++++++++++++++++++++
>   1 file changed, 27 insertions(+)
>   create mode 100644 meta/recipes-support/plowshare/plowshare_git.bb
>
> diff --git a/meta/recipes-support/plowshare/plowshare_git.bbb/meta/recipes-support/plowshare/
> plowshare_git.bb
> new file mode 100644
> index 0000000..f819255
> --- /dev/null
> +++ b/meta/recipes-support/plowshare/plowshare_git.bb
> @@ -0,0 +1,27 @@
> +DESCRIPTION = "Command-line download/upload tool for file sharing hosters"
> +HOMEPAGE = "http://code.google.com/p/plowshare/"
> +SECTION = "console/utils"
> +
> +LICENSE = "GPLv3"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
> +
> +# Follow uptream (debian) naming convention,
> +# for example: plowshare_1~git20120807-1_all.deb
> +PV = "gitr${SRCPV}"
> +PE = "1"
> +SRCREV = ""
> +
> +RDEPENDS_${PN} = "bash curl"
> +SRC_URI = "git://
> code.google.com/p/plowshare.git;protocol=http;branch=master"
> +S = "${WORKDIR}/git"
> +
> +inherit allarch
> +
> +# Nothing to compile, it's scripts!
> +do_compile() {
> + :
> +}
> +
> +do_install() {
> + oe_runmake PREFIX="${prefix}" DESTDIR="${D}" install
> +}
> --
> 1.7.9.5
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Matthieu,

Before you bear the wrath of Koen, I would recommend you at least move 
this to an appropriate layer (such as somewhere in meta-oe[1]).

The general consensus is that things only go in oe-core if they are 
required for a core-system build.

[1] https://github.com/openembedded/meta-oe
Matthieu - Aug. 15, 2012, 8:43 a.m.
Hi,

Thanks for answer! The path in the "diff --git" line is not good. 
"meta-openembedded-contrib/meta-oe/recipes-support" is my suggestion.
However, I don't know if this kind of software is suitable for oe-devel. 
I just wanted to create a "valid" recipe.

I'm still confused with this SRCREV thing. Just want to retrieve HEAD 
from git master branch. Also tried using inherit gitpkgv
(like systemd) but It raises an error without SRCREV defined.

Regards,
Matthieu

PS: What's the difference between:
https://github.com/openembedded/meta-oe
http://cgit.openembedded.org/meta-openembedded/

>
> Before you bear the wrath of Koen, I would recommend you at least move 
> this to an appropriate layer (such as somewhere in meta-oe[1]).
>
> The general consensus is that things only go in oe-core if they are 
> required for a core-system build.
>
> [1] https://github.com/openembedded/meta-oe
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Koen Kooi - Aug. 15, 2012, 8:53 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 15-08-12 10:43, Matthieu Crapet schreef:
> Hi,
> 
> Thanks for answer! The path in the "diff --git" line is not good. 
> "meta-openembedded-contrib/meta-oe/recipes-support" is my suggestion. 
> However, I don't know if this kind of software is suitable for oe-devel.
> I just wanted to create a "valid" recipe.
> 
> I'm still confused with this SRCREV thing. Just want to retrieve HEAD
> from git master branch.

That's not allowed, all SRCREVs must be locked down. If there's an update
you want/need, send a patch. Most people stop looking after AUTOREV recipes
after a month or so and everyone else gets to live with the breakage.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQK2OWMkyGM64RGpERAlWtAKCMwXpuClb8p1obLjU7PVMlni1d6gCcDsDI
CWuOwmaAtY+bHTFZO/F/g/s=
=eBzs
-----END PGP SIGNATURE-----
Paul Eggleton - Aug. 15, 2012, 9:27 a.m.
On Wednesday 15 August 2012 10:53:42 Koen Kooi wrote:
> Op 15-08-12 10:43, Matthieu Crapet schreef:
> > I'm still confused with this SRCREV thing. Just want to retrieve HEAD
> > from git master branch.
> 
> That's not allowed, all SRCREVs must be locked down. If there's an update
> you want/need, send a patch. Most people stop looking after AUTOREV recipes
> after a month or so and everyone else gets to live with the breakage.

It's worth noting however that if you really still want to use AUTOREV for the 
recipe in your own builds, it's trivial to just bbappend the recipe and do 
that in your own layer on top - so it is possible to have the best of both 
worlds.

Cheers,
Paul

Patch

diff --git a/meta/recipes-support/plowshare/plowshare_git.bbb/meta/recipes-support/plowshare/
plowshare_git.bb
new file mode 100644
index 0000000..f819255
--- /dev/null
+++ b/meta/recipes-support/plowshare/plowshare_git.bb
@@ -0,0 +1,27 @@ 
+DESCRIPTION = "Command-line download/upload tool for file sharing hosters"
+HOMEPAGE = "http://code.google.com/p/plowshare/"
+SECTION = "console/utils"
+
+LICENSE = "GPLv3"
+LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
+
+# Follow uptream (debian) naming convention,
+# for example: plowshare_1~git20120807-1_all.deb
+PV = "gitr${SRCPV}"
+PE = "1"
+SRCREV = ""
+
+RDEPENDS_${PN} = "bash curl"
+SRC_URI = "git://
code.google.com/p/plowshare.git;protocol=http;branch=master"
+S = "${WORKDIR}/git"
+
+inherit allarch
+
+# Nothing to compile, it's scripts!
+do_compile() {
+ :
+}
+
+do_install() {
+ oe_runmake PREFIX="${prefix}" DESTDIR="${D}" install