Patchwork busybox: Upgrade to upstream 1.20.2

login
register
mail settings
Submitter Radu Moisan
Date Aug. 14, 2012, 12:17 p.m.
Message ID <502A41C7.4030009@intel.com>
Download mbox | patch
Permalink /patch/34583/
State New
Headers show

Comments

Radu Moisan - Aug. 14, 2012, 12:17 p.m.
On 08/14/2012 03:01 PM, Anders Darander wrote:
> * Radu Moisan <radu.moisan@intel.com> [120814 13:42]:
>
>
>> On 08/14/2012 02:25 PM, Anders Darander wrote:
>>> * Radu Moisan <radu.moisan@intel.com> [120814 11:01]:
>>>
>>>> Signed-off-by: Radu Moisan <radu.moisan@intel.com>
>>>> ---
>>>>    .../B921600.patch                                  |    0
>>>>    .../busybox-appletlib-dependency.patch             |    0
>>>>    .../busybox-mkfs-minix-tests_bigendian.patch       |    0
>>>>    .../busybox-udhcpc-no_deconfig.patch               |   37 +++++++++-----------
>>>>    .../{busybox-1.19.4 => busybox-1.20.2}/defconfig   |    0
>>> Are there no changes to the configuration file? I.e. new and removed
>>> options?
>> None that I know about, I've took a quick look over the changelog but
>> nothing cought my eye. I you find anything, just point it out and I'll
>> deep dive on it.
> Could you diff the generated .config between 1.19.4 and 1.20.2?
>
> This would allow us to see the differences.
Paul Eggleton - Aug. 14, 2012, 12:37 p.m.
On Tuesday 14 August 2012 15:17:11 Radu Moisan wrote:
> +CONFIG_LSOF=y

This would be the only change that would concern me. If we didn't provide this 
with busybox before I think it should be disabled by default.

Cheers,
Paul
Anders Darander - Aug. 14, 2012, 12:55 p.m.
* Paul Eggleton <paul.eggleton@linux.intel.com> [120814 14:38]:

> On Tuesday 14 August 2012 15:17:11 Radu Moisan wrote:
> > +CONFIG_LSOF=y

> This would be the only change that would concern me. If we didn't provide this 
> with busybox before I think it should be disabled by default.

I was about to reply with more or less the same comment.

The other changes in the defconfig looks minor, at least without any
deeper inspection. 

However, we should think twice before we add more applets in the default
config. And if we decide to do this, we're probably going to need to add
update-alternatives handling for lsof.

Cheers,
Anders

Patch

diff --git a/../../busybox-1.19.4-r13/busybox-1.19.4/.config b/.config
index 61321dd..9be989b 100644
--- a/../../busybox-1.19.4-r13/busybox-1.19.4/.config
+++ b/.config
@@ -1,7 +1,7 @@ 
  #
  # Automatically generated make config: don't edit
-# Busybox version: 1.19.4
-# Tue Aug 14 11:20:02 2012
+# Busybox version: 1.20.2
+# Tue Aug 14 12:31:54 2012
  #
  CONFIG_HAVE_DOT_CONFIG=y

@@ -62,7 +62,10 @@  CONFIG_FEATURE_HAVE_RPC=y
  # CONFIG_FEATURE_SHARED_BUSYBOX is not set
  CONFIG_LFS=y
  CONFIG_CROSS_COMPILER_PREFIX="i586-poky-linux-"
+CONFIG_SYSROOT=""
  CONFIG_EXTRA_CFLAGS=" -O2 -pipe -g -feliminate-unused-debug-types"
+CONFIG_EXTRA_LDFLAGS=""
+CONFIG_EXTRA_LDLIBS=""

  #
  # Debugging Options
@@ -92,7 +95,7 @@  CONFIG_PREFIX="./_install"
  CONFIG_FEATURE_SYSTEMD=y
  CONFIG_FEATURE_RTMINMAX=y
  CONFIG_PASSWORD_MINLEN=6
-CONFIG_MD5_SIZE_VS_SPEED=2
+CONFIG_MD5_SMALL=1
  CONFIG_FEATURE_FAST_TOP=y
  # CONFIG_FEATURE_ETC_NETWORKS is not set
  CONFIG_FEATURE_USE_TERMIOS=y
@@ -101,6 +104,7 @@  CONFIG_FEATURE_EDITING_MAX_LEN=1024
  # CONFIG_FEATURE_EDITING_VI is not set
  CONFIG_FEATURE_EDITING_HISTORY=15
  CONFIG_FEATURE_EDITING_SAVEHISTORY=y
+# CONFIG_FEATURE_EDITING_SAVE_ON_EXIT is not set
  # CONFIG_FEATURE_REVERSE_SEARCH is not set
  CONFIG_FEATURE_TAB_COMPLETION=y
  CONFIG_FEATURE_USERNAME_COMPLETION=y
@@ -140,6 +144,7 @@  CONFIG_CPIO=y
  CONFIG_GUNZIP=y
  CONFIG_GZIP=y
  # CONFIG_FEATURE_GZIP_LONG_OPTIONS is not set
+CONFIG_GZIP_FAST=0
  # CONFIG_LZOP is not set
  # CONFIG_LZOP_COMPR_HIGH is not set
  # CONFIG_RPM2CPIO is not set
@@ -173,11 +178,13 @@  CONFIG_DATE=y
  # CONFIG_FEATURE_DATE_ISOFMT is not set
  # CONFIG_FEATURE_DATE_NANO is not set
  CONFIG_FEATURE_DATE_COMPAT=y
+# CONFIG_HOSTID is not set
  CONFIG_ID=y
  CONFIG_GROUPS=y
  CONFIG_TEST=y
  CONFIG_FEATURE_TEST_64=y
  CONFIG_TOUCH=y
+CONFIG_FEATURE_TOUCH_SUSV3=y
  CONFIG_TR=y
  CONFIG_FEATURE_TR_CLASSES=y
  # CONFIG_FEATURE_TR_EQUIV is not set
@@ -220,7 +227,6 @@  CONFIG_FALSE=y
  # CONFIG_FSYNC is not set
  CONFIG_HEAD=y
  # CONFIG_FEATURE_FANCY_HEAD is not set
-# CONFIG_HOSTID is not set
  # CONFIG_INSTALL is not set
  # CONFIG_FEATURE_INSTALL_LONG_OPTIONS is not set
  CONFIG_LN=y
@@ -461,6 +467,7 @@  CONFIG_LAST_SYSTEM_ID=0
  # CONFIG_FEATURE_DEL_USER_FROM_GROUP is not set
  # CONFIG_GETTY is not set
  # CONFIG_LOGIN is not set
+# CONFIG_LOGIN_SESSION_AS_CHILD is not set
  # CONFIG_PAM is not set
  # CONFIG_LOGIN_SCRIPTS is not set
  # CONFIG_FEATURE_NOLOGIN is not set
@@ -469,6 +476,7 @@  CONFIG_LAST_SYSTEM_ID=0
  # CONFIG_FEATURE_PASSWD_WEAK_CHECK is not set
  # CONFIG_CRYPTPW is not set
  # CONFIG_CHPASSWD is not set
+CONFIG_FEATURE_DEFAULT_PASSWD_ALGO=""
  # CONFIG_SU is not set
  # CONFIG_FEATURE_SU_SYSLOG is not set
  # CONFIG_FEATURE_SU_CHECKS_SHELLS is not set
@@ -518,6 +526,12 @@  CONFIG_DEFAULT_DEPMOD_FILE="modules.dep"
  # Linux System Utilities
  #
  # CONFIG_BLOCKDEV is not set
+# CONFIG_MDEV is not set
+# CONFIG_FEATURE_MDEV_CONF is not set
+# CONFIG_FEATURE_MDEV_RENAME is not set
+# CONFIG_FEATURE_MDEV_RENAME_REGEXP is not set
+# CONFIG_FEATURE_MDEV_EXEC is not set
+# CONFIG_FEATURE_MDEV_LOAD_FIRMWARE is not set
  # CONFIG_REV is not set
  # CONFIG_ACPID is not set
  # CONFIG_FEATURE_ACPID_COMPAT is not set
@@ -561,12 +575,6 @@  CONFIG_FEATURE_HWCLOCK_ADJTIME_FHS=y
  CONFIG_LOSETUP=y
  # CONFIG_LSPCI is not set
  # CONFIG_LSUSB is not set
-# CONFIG_MDEV is not set
-# CONFIG_FEATURE_MDEV_CONF is not set
-# CONFIG_FEATURE_MDEV_RENAME is not set
-# CONFIG_FEATURE_MDEV_RENAME_REGEXP is not set
-# CONFIG_FEATURE_MDEV_EXEC is not set
-# CONFIG_FEATURE_MDEV_LOAD_FIRMWARE is not set
  CONFIG_MKSWAP=y
  # CONFIG_FEATURE_MKSWAP_UUID is not set
  CONFIG_MORE=y
@@ -831,6 +839,7 @@  CONFIG_TRACEROUTE=y
  # CONFIG_FEATURE_TRACEROUTE_USE_ICMP is not set
  # CONFIG_TUNCTL is not set
  # CONFIG_FEATURE_TUNCTL_UG is not set
+# CONFIG_UDHCPC6 is not set
  CONFIG_UDHCPD=y
  # CONFIG_DHCPRELAY is not set
  CONFIG_DUMPLEASES=y
@@ -877,6 +886,7 @@  CONFIG_FEATURE_MIME_CHARSET=""
  # Process Utilities
  #
  # CONFIG_IOSTAT is not set
+CONFIG_LSOF=y
  # CONFIG_MPSTAT is not set
  # CONFIG_NMETER is not set
  # CONFIG_PMAP is not set
@@ -898,6 +908,7 @@  CONFIG_PIDOF=y
  # CONFIG_PKILL is not set
  CONFIG_PS=y
  CONFIG_FEATURE_PS_WIDE=y
+CONFIG_FEATURE_PS_LONG=y
  # CONFIG_FEATURE_PS_TIME is not set
  # CONFIG_FEATURE_PS_ADDITIONAL_COLUMNS is not set
  # CONFIG_FEATURE_PS_UNUSUAL_SYSTEMS is not set