Patchwork [CONSOLIDATED,REQUEST,05/64] console-tools: cleanup update-alternatives deprecated code

login
register
mail settings
Submitter Saul Wold
Date Aug. 14, 2012, 12:12 p.m.
Message ID <5623cc2a909aa332092db9ca0c79ef36c2987554.1344946189.git.sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/34481/
State New
Headers show

Comments

Saul Wold - Aug. 14, 2012, 12:12 p.m.
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 .../console-tools/console-tools_0.3.2.bb           |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)
Richard Purdie - Aug. 14, 2012, 7:01 p.m.
On Tue, 2012-08-14 at 15:12 +0300, Saul Wold wrote:
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  .../console-tools/console-tools_0.3.2.bb           |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-core/console-tools/console-tools_0.3.2.bb b/meta/recipes-core/console-tools/console-tools_0.3.2.bb
> index 6027d4a..1446368 100644
> --- a/meta/recipes-core/console-tools/console-tools_0.3.2.bb
> +++ b/meta/recipes-core/console-tools/console-tools_0.3.2.bb
> @@ -3,7 +3,7 @@ LICENSE = "GPLv2"
>  LIC_FILES_CHKSUM = "file://COPYING.kbd;md5=9b2d91511d3d80d4d20ac6e6b0137fe9"
>  SUMMARY = "Allows you to set-up and manipulate the Linux console."
>  DESCRIPTION = "Provides tools that enable the set-up and manipulation of the linux console and console-font files."
> -PR = "r5"
> +PR = "r6"
>  
>  SRC_URI = "${SOURCEFORGE_MIRROR}/lct/console-tools-${PV}.tar.gz \
>             file://codepage.patch \
> @@ -35,6 +35,10 @@ inherit autotools gettext update-alternatives
>  ALTERNATIVE_PRIORITY = "100"
>  
>  bindir_progs = "chvt deallocvt fgconsole openvt"
> -ALTERNATIVE_LINKS = "${bindir}/${@' ${bindir}/'.join((d.getVar('bindir_progs', True)).split())}"
> +ALTERNATIVE_${PN} = "${bindir_progs}"
> +#python __anonymous() {
> +#	for prog in d.getVar('bindir_progs', True).split():
> +#		d.setVarFlag('ALTERNATIVE_LINK_NAME', prog, '%s/%s' % (d.getVar('base_bindir', True), prog))
> +#}

Any particular reason we're adding in this anonymous python function
which is commented out?

Cheers,

Richard
Saul Wold - Aug. 15, 2012, 8:57 p.m.
On 08/14/2012 12:01 PM, Richard Purdie wrote:
> On Tue, 2012-08-14 at 15:12 +0300, Saul Wold wrote:
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>> ---
>>   .../console-tools/console-tools_0.3.2.bb           |    8 ++++++--
>>   1 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/console-tools/console-tools_0.3.2.bb b/meta/recipes-core/console-tools/console-tools_0.3.2.bb
>> index 6027d4a..1446368 100644
>> --- a/meta/recipes-core/console-tools/console-tools_0.3.2.bb
>> +++ b/meta/recipes-core/console-tools/console-tools_0.3.2.bb
>> @@ -3,7 +3,7 @@ LICENSE = "GPLv2"
>>   LIC_FILES_CHKSUM = "file://COPYING.kbd;md5=9b2d91511d3d80d4d20ac6e6b0137fe9"
>>   SUMMARY = "Allows you to set-up and manipulate the Linux console."
>>   DESCRIPTION = "Provides tools that enable the set-up and manipulation of the linux console and console-font files."
>> -PR = "r5"
>> +PR = "r6"
>>
>>   SRC_URI = "${SOURCEFORGE_MIRROR}/lct/console-tools-${PV}.tar.gz \
>>              file://codepage.patch \
>> @@ -35,6 +35,10 @@ inherit autotools gettext update-alternatives
>>   ALTERNATIVE_PRIORITY = "100"
>>
>>   bindir_progs = "chvt deallocvt fgconsole openvt"
>> -ALTERNATIVE_LINKS = "${bindir}/${@' ${bindir}/'.join((d.getVar('bindir_progs', True)).split())}"
>> +ALTERNATIVE_${PN} = "${bindir_progs}"
>> +#python __anonymous() {
>> +#	for prog in d.getVar('bindir_progs', True).split():
>> +#		d.setVarFlag('ALTERNATIVE_LINK_NAME', prog, '%s/%s' % (d.getVar('base_bindir', True), prog))
>> +#}
>
Oops, that should not be there as I solved with the line above. Thanks 
for taking care of that.

Sau!

> Any particular reason we're adding in this anonymous python function
> which is commented out?
>
> Cheers,
>
> Richard
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-core/console-tools/console-tools_0.3.2.bb b/meta/recipes-core/console-tools/console-tools_0.3.2.bb
index 6027d4a..1446368 100644
--- a/meta/recipes-core/console-tools/console-tools_0.3.2.bb
+++ b/meta/recipes-core/console-tools/console-tools_0.3.2.bb
@@ -3,7 +3,7 @@  LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING.kbd;md5=9b2d91511d3d80d4d20ac6e6b0137fe9"
 SUMMARY = "Allows you to set-up and manipulate the Linux console."
 DESCRIPTION = "Provides tools that enable the set-up and manipulation of the linux console and console-font files."
-PR = "r5"
+PR = "r6"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/lct/console-tools-${PV}.tar.gz \
            file://codepage.patch \
@@ -35,6 +35,10 @@  inherit autotools gettext update-alternatives
 ALTERNATIVE_PRIORITY = "100"
 
 bindir_progs = "chvt deallocvt fgconsole openvt"
-ALTERNATIVE_LINKS = "${bindir}/${@' ${bindir}/'.join((d.getVar('bindir_progs', True)).split())}"
+ALTERNATIVE_${PN} = "${bindir_progs}"
+#python __anonymous() {
+#	for prog in d.getVar('bindir_progs', True).split():
+#		d.setVarFlag('ALTERNATIVE_LINK_NAME', prog, '%s/%s' % (d.getVar('base_bindir', True), prog))
+#}
 
 RDEPENDS_${PN} = "bash"