Patchwork angstrom-2010.x.conf: Prefer binutils 2.21 and uclibc-git

login
register
mail settings
Submitter Khem Raj
Date Jan. 24, 2011, 2:03 a.m.
Message ID <1295834629-3974-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/344/
State Rejected
Headers show

Comments

Khem Raj - Jan. 24, 2011, 2:03 a.m.
* no need to pin older udev with uclibc/git either

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 conf/distro/angstrom-2010.x.conf                   |    6 +++---
 .../include/angstrom-2010-preferred-versions.inc   |    1 -
 2 files changed, 3 insertions(+), 4 deletions(-)
Koen Kooi - Jan. 24, 2011, 9:02 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 24-01-11 03:03, Khem Raj wrote:
> * no need to pin older udev with uclibc/git either
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

NAK! binutils 2.21 introduces way too many problem at this moment, those
need to get solved before switching to it.

> ---
>  conf/distro/angstrom-2010.x.conf                   |    6 +++---
>  .../include/angstrom-2010-preferred-versions.inc   |    1 -
>  2 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/conf/distro/angstrom-2010.x.conf b/conf/distro/angstrom-2010.x.conf
> index c6fb07d..3ac3847 100644
> --- a/conf/distro/angstrom-2010.x.conf
> +++ b/conf/distro/angstrom-2010.x.conf
> @@ -71,8 +71,8 @@ PREFERRED_VERSION_linux-libc-headers-native = "${LINUX_LIBC_HEADERS_VERSION}"
>  #Prefer glibc 2.6 and uclibc 0.9.30, these have had the most testing.
>  PREFERRED_VERSION_glibc 		?= "2.10.1"
>  PREFERRED_VERSION_glibc-initial 	?= "2.10.1"
> -PREFERRED_VERSION_uclibc        	?= "0.9.30.2"
> -PREFERRED_VERSION_uclibc-initial	?= "0.9.30.2"
> +PREFERRED_VERSION_uclibc        	?= "git"
> +PREFERRED_VERSION_uclibc-initial	?= "git"
>  PREFERRED_VERSION_eglibc		?= "2.12"
>  PREFERRED_VERSION_eglibc-initial	?= "2.12"
>  
> @@ -95,7 +95,7 @@ ANGSTROM_GCC_VERSION_avr32		?= "4.2.2"
>  #Everybody else can just use this: 
>  ANGSTROM_GCC_VERSION                     ?= "4.5"
>  
> -ANGSTROM_BINUTILS_VERSION                ?= "2.20.1"
> +ANGSTROM_BINUTILS_VERSION                ?= "2.21"
>  
>  PREFERRED_VERSION_binutils               ?= "${ANGSTROM_BINUTILS_VERSION}"
>  PREFERRED_VERSION_binutils-cross         ?= "${ANGSTROM_BINUTILS_VERSION}"
> diff --git a/conf/distro/include/angstrom-2010-preferred-versions.inc b/conf/distro/include/angstrom-2010-preferred-versions.inc
> index 5532f29..66ee5ab 100644
> --- a/conf/distro/include/angstrom-2010-preferred-versions.inc
> +++ b/conf/distro/include/angstrom-2010-preferred-versions.inc
> @@ -66,7 +66,6 @@ PREFERRED_VERSION_samba		= "3.3.9"
>  PREFERRED_VERSION_tiff 		= "3.9.4+4.0.0beta6"
>  
>  PREFERRED_VERSION_udev 		= "165"
> -PREFERRED_VERSION_udev_libc-uclibc = "141"
>  UDEV_GE_141 = "1"
>  
>  PREFERRED_VERSION_usbutils = "0.86"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNPUAeMkyGM64RGpERAm6CAJsHFPAQdphhKT4liYnMNE57ubU32wCfeJim
6pPp+1le2CwVszFtrNlJ+Qk=
=ihdt
-----END PGP SIGNATURE-----
Khem Raj - Jan. 24, 2011, 9:15 a.m.
On Mon, Jan 24, 2011 at 1:02 AM, Koen Kooi <k.kooi@student.utwente.nl> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 24-01-11 03:03, Khem Raj wrote:
>> * no need to pin older udev with uclibc/git either
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>
> NAK! binutils 2.21 introduces way too many problem at this moment, those
> need to get solved before switching to it.

hmmm. Too vague a statement. Do you have list of issues somewhere I can look at
it built the console-image x11-image images I tried and booted
console-image too.

>
>> ---
>>  conf/distro/angstrom-2010.x.conf                   |    6 +++---
>>  .../include/angstrom-2010-preferred-versions.inc   |    1 -
>>  2 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/conf/distro/angstrom-2010.x.conf b/conf/distro/angstrom-2010.x.conf
>> index c6fb07d..3ac3847 100644
>> --- a/conf/distro/angstrom-2010.x.conf
>> +++ b/conf/distro/angstrom-2010.x.conf
>> @@ -71,8 +71,8 @@ PREFERRED_VERSION_linux-libc-headers-native = "${LINUX_LIBC_HEADERS_VERSION}"
>>  #Prefer glibc 2.6 and uclibc 0.9.30, these have had the most testing.
>>  PREFERRED_VERSION_glibc              ?= "2.10.1"
>>  PREFERRED_VERSION_glibc-initial      ?= "2.10.1"
>> -PREFERRED_VERSION_uclibc             ?= "0.9.30.2"
>> -PREFERRED_VERSION_uclibc-initial     ?= "0.9.30.2"
>> +PREFERRED_VERSION_uclibc             ?= "git"
>> +PREFERRED_VERSION_uclibc-initial     ?= "git"
>>  PREFERRED_VERSION_eglibc             ?= "2.12"
>>  PREFERRED_VERSION_eglibc-initial     ?= "2.12"
>>
>> @@ -95,7 +95,7 @@ ANGSTROM_GCC_VERSION_avr32          ?= "4.2.2"
>>  #Everybody else can just use this:
>>  ANGSTROM_GCC_VERSION                     ?= "4.5"
>>
>> -ANGSTROM_BINUTILS_VERSION                ?= "2.20.1"
>> +ANGSTROM_BINUTILS_VERSION                ?= "2.21"
>>
>>  PREFERRED_VERSION_binutils               ?= "${ANGSTROM_BINUTILS_VERSION}"
>>  PREFERRED_VERSION_binutils-cross         ?= "${ANGSTROM_BINUTILS_VERSION}"
>> diff --git a/conf/distro/include/angstrom-2010-preferred-versions.inc b/conf/distro/include/angstrom-2010-preferred-versions.inc
>> index 5532f29..66ee5ab 100644
>> --- a/conf/distro/include/angstrom-2010-preferred-versions.inc
>> +++ b/conf/distro/include/angstrom-2010-preferred-versions.inc
>> @@ -66,7 +66,6 @@ PREFERRED_VERSION_samba             = "3.3.9"
>>  PREFERRED_VERSION_tiff               = "3.9.4+4.0.0beta6"
>>
>>  PREFERRED_VERSION_udev               = "165"
>> -PREFERRED_VERSION_udev_libc-uclibc = "141"
>>  UDEV_GE_141 = "1"
>>
>>  PREFERRED_VERSION_usbutils = "0.86"
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFNPUAeMkyGM64RGpERAm6CAJsHFPAQdphhKT4liYnMNE57ubU32wCfeJim
> 6pPp+1le2CwVszFtrNlJ+Qk=
> =ihdt
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Koen Kooi - Jan. 24, 2011, 9:39 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 24-01-11 10:15, Khem Raj wrote:
> On Mon, Jan 24, 2011 at 1:02 AM, Koen Kooi <k.kooi@student.utwente.nl> wrote:
> On 24-01-11 03:03, Khem Raj wrote:
>>>> * no need to pin older udev with uclibc/git either
>>>>
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> 
> NAK! binutils 2.21 introduces way too many problem at this moment, those
> need to get solved before switching to it.
> 
>> hmmm. Too vague a statement. Do you have list of issues somewhere I can look at
>> it built the console-image x11-image images I tried and booted
>> console-image too.

Try building anything that uses linux-omap-psp 2.6.32. You will run into
the secure mode problem. That one is relatively easy to solve, but it
needs to get solved *before* the switch, not after.

But besided that, so a change needs to get RFC'd, tested and signed off
by the angstrom maintainers before it gets pushed. It's a toolchain
change and we take toolchains seriously.

Waking up and seeing it applied without all that is *extremely*
insulting. So I reverted it.

> 
> 
>>>> ---
>>>>  conf/distro/angstrom-2010.x.conf                   |    6 +++---
>>>>  .../include/angstrom-2010-preferred-versions.inc   |    1 -
>>>>  2 files changed, 3 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/conf/distro/angstrom-2010.x.conf b/conf/distro/angstrom-2010.x.conf
>>>> index c6fb07d..3ac3847 100644
>>>> --- a/conf/distro/angstrom-2010.x.conf
>>>> +++ b/conf/distro/angstrom-2010.x.conf
>>>> @@ -71,8 +71,8 @@ PREFERRED_VERSION_linux-libc-headers-native = "${LINUX_LIBC_HEADERS_VERSION}"
>>>>  #Prefer glibc 2.6 and uclibc 0.9.30, these have had the most testing.
>>>>  PREFERRED_VERSION_glibc              ?= "2.10.1"
>>>>  PREFERRED_VERSION_glibc-initial      ?= "2.10.1"
>>>> -PREFERRED_VERSION_uclibc             ?= "0.9.30.2"
>>>> -PREFERRED_VERSION_uclibc-initial     ?= "0.9.30.2"
>>>> +PREFERRED_VERSION_uclibc             ?= "git"
>>>> +PREFERRED_VERSION_uclibc-initial     ?= "git"
>>>>  PREFERRED_VERSION_eglibc             ?= "2.12"
>>>>  PREFERRED_VERSION_eglibc-initial     ?= "2.12"
>>>>
>>>> @@ -95,7 +95,7 @@ ANGSTROM_GCC_VERSION_avr32          ?= "4.2.2"
>>>>  #Everybody else can just use this:
>>>>  ANGSTROM_GCC_VERSION                     ?= "4.5"
>>>>
>>>> -ANGSTROM_BINUTILS_VERSION                ?= "2.20.1"
>>>> +ANGSTROM_BINUTILS_VERSION                ?= "2.21"
>>>>
>>>>  PREFERRED_VERSION_binutils               ?= "${ANGSTROM_BINUTILS_VERSION}"
>>>>  PREFERRED_VERSION_binutils-cross         ?= "${ANGSTROM_BINUTILS_VERSION}"
>>>> diff --git a/conf/distro/include/angstrom-2010-preferred-versions.inc b/conf/distro/include/angstrom-2010-preferred-versions.inc
>>>> index 5532f29..66ee5ab 100644
>>>> --- a/conf/distro/include/angstrom-2010-preferred-versions.inc
>>>> +++ b/conf/distro/include/angstrom-2010-preferred-versions.inc
>>>> @@ -66,7 +66,6 @@ PREFERRED_VERSION_samba             = "3.3.9"
>>>>  PREFERRED_VERSION_tiff               = "3.9.4+4.0.0beta6"
>>>>
>>>>  PREFERRED_VERSION_udev               = "165"
>>>> -PREFERRED_VERSION_udev_libc-uclibc = "141"
>>>>  UDEV_GE_141 = "1"
>>>>
>>>>  PREFERRED_VERSION_usbutils = "0.86"
> 
>>
>>
Frans Meulenbroeks - Jan. 24, 2011, 9:59 a.m.
2011/1/24 Koen Kooi <k.kooi@student.utwente.nl>:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 24-01-11 10:15, Khem Raj wrote:
>> On Mon, Jan 24, 2011 at 1:02 AM, Koen Kooi <k.kooi@student.utwente.nl> wrote:
>> On 24-01-11 03:03, Khem Raj wrote:
>>>>> * no need to pin older udev with uclibc/git either
>>>>>
>>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>
>> NAK! binutils 2.21 introduces way too many problem at this moment, those
>> need to get solved before switching to it.
>>
>>> hmmm. Too vague a statement. Do you have list of issues somewhere I can look at
>>> it built the console-image x11-image images I tried and booted
>>> console-image too.
>
> Try building anything that uses linux-omap-psp 2.6.32. You will run into
> the secure mode problem. That one is relatively easy to solve, but it
> needs to get solved *before* the switch, not after.
>
> But besided that, so a change needs to get RFC'd, tested and signed off
> by the angstrom maintainers before it gets pushed. It's a toolchain
> change and we take toolchains seriously.
>
> Waking up and seeing it applied without all that is *extremely*
> insulting. So I reverted it.
>

Pushing distro changes without review is against the policy:

From http://www.openembedded.org/index.php/Commit_Policy:

 * Distro config changes should be reviewed by the distro maintainers
   where known

Reveting changes from others is also against the policy:

http://www.openembedded.org/index.php/Revert_Policy

(and imho equally bad (or insulting if you prefer))


Do unto others as you would have them do unto you

My two eurocents. Frans.
Tom Rini - Jan. 24, 2011, 2:52 p.m.
On 01/24/2011 02:59 AM, Frans Meulenbroeks wrote:
> 2011/1/24 Koen Kooi<k.kooi@student.utwente.nl>:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> On 24-01-11 10:15, Khem Raj wrote:
>>> On Mon, Jan 24, 2011 at 1:02 AM, Koen Kooi<k.kooi@student.utwente.nl>  wrote:
>>> On 24-01-11 03:03, Khem Raj wrote:
>>>>>> * no need to pin older udev with uclibc/git either
>>>>>>
>>>>>> Signed-off-by: Khem Raj<raj.khem@gmail.com>
>>>
>>> NAK! binutils 2.21 introduces way too many problem at this moment, those
>>> need to get solved before switching to it.
>>>
>>>> hmmm. Too vague a statement. Do you have list of issues somewhere I can look at
>>>> it built the console-image x11-image images I tried and booted
>>>> console-image too.
>>
>> Try building anything that uses linux-omap-psp 2.6.32. You will run into
>> the secure mode problem. That one is relatively easy to solve, but it
>> needs to get solved *before* the switch, not after.
>>
>> But besided that, so a change needs to get RFC'd, tested and signed off
>> by the angstrom maintainers before it gets pushed. It's a toolchain
>> change and we take toolchains seriously.
>>
>> Waking up and seeing it applied without all that is *extremely*
>> insulting. So I reverted it.
>>
>
> Pushing distro changes without review is against the policy:
>
>> From http://www.openembedded.org/index.php/Commit_Policy:
>
>   * Distro config changes should be reviewed by the distro maintainers
>     where known
>
> Reveting changes from others is also against the policy:
>
> http://www.openembedded.org/index.php/Revert_Policy
>
> (and imho equally bad (or insulting if you prefer))
>
>
> Do unto others as you would have them do unto you

Well, no.  I'm pretty sure the "you just broke my distribution" falls 
into the yes, it's OK to push the revert before the other party wakes up 
and says "Oops, sorry!".
Philip Balister - Jan. 24, 2011, 3:15 p.m.
On 01/24/2011 01:59 AM, Frans Meulenbroeks wrote:
> 2011/1/24 Koen Kooi<k.kooi@student.utwente.nl>:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
> Pushing distro changes without review is against the policy:
>
>> From http://www.openembedded.org/index.php/Commit_Policy:
>
>   * Distro config changes should be reviewed by the distro maintainers
>     where known
>
> Reveting changes from others is also against the policy:
>
> http://www.openembedded.org/index.php/Revert_Policy
>
> (and imho equally bad (or insulting if you prefer))
>
>
> Do unto others as you would have them do unto you
>
> My two eurocents. Frans.

Frans, as noted this change intoduces serious issues with some Angstrom 
targets. The Angstrom devs know what is best for Angstrom. I'm not sure 
what Khem was thinking by pushing this change without consulting with 
Angstrom devs.

Philip
Tom Rini - Jan. 24, 2011, 3:28 p.m.
On 01/24/2011 08:15 AM, Philip Balister wrote:
> On 01/24/2011 01:59 AM, Frans Meulenbroeks wrote:
>> 2011/1/24 Koen Kooi<k.kooi@student.utwente.nl>:
>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> Hash: SHA1
>>>
>> Pushing distro changes without review is against the policy:
>>
>>> From http://www.openembedded.org/index.php/Commit_Policy:
>>
>> * Distro config changes should be reviewed by the distro maintainers
>> where known
>>
>> Reveting changes from others is also against the policy:
>>
>> http://www.openembedded.org/index.php/Revert_Policy
>>
>> (and imho equally bad (or insulting if you prefer))
>>
>>
>> Do unto others as you would have them do unto you
>>
>> My two eurocents. Frans.
>
> Frans, as noted this change intoduces serious issues with some Angstrom
> targets. The Angstrom devs know what is best for Angstrom. I'm not sure
> what Khem was thinking by pushing this change without consulting with
> Angstrom devs.

Not to put too many words into Khem's mouth, but I imagine it was that 
he checked this in on the same branch as the other changes he pushed 
last night and forgot (time for some 'git stash'ing Khem :))
Khem Raj - Jan. 24, 2011, 3:38 p.m.
On Mon, Jan 24, 2011 at 1:39 AM, Koen Kooi <k.kooi@student.utwente.nl> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 24-01-11 10:15, Khem Raj wrote:
>> On Mon, Jan 24, 2011 at 1:02 AM, Koen Kooi <k.kooi@student.utwente.nl> wrote:
>> On 24-01-11 03:03, Khem Raj wrote:
>>>>> * no need to pin older udev with uclibc/git either
>>>>>
>>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>
>> NAK! binutils 2.21 introduces way too many problem at this moment, those
>> need to get solved before switching to it.
>>
>>> hmmm. Too vague a statement. Do you have list of issues somewhere I can look at
>>> it built the console-image x11-image images I tried and booted
>>> console-image too.
>
> Try building anything that uses linux-omap-psp 2.6.32. You will run into
> the secure mode problem. That one is relatively easy to solve, but it
> needs to get solved *before* the switch, not after.
>
> But besided that, so a change needs to get RFC'd, tested and signed off
> by the angstrom maintainers before it gets pushed. It's a toolchain
> change and we take toolchains seriously.
>
> Waking up and seeing it applied without all that is *extremely*
> insulting. So I reverted it.
Koen

bah it was not intentionally pushed. I wanted to push the other gcc
change and git push
pushed all branches. I should probably not track remote branches that
way git push wont
do this kind of mess. Sorry for the hassle. Thank you for reverting it
>
>>
>>
>>>>> ---
>>>>>  conf/distro/angstrom-2010.x.conf                   |    6 +++---
>>>>>  .../include/angstrom-2010-preferred-versions.inc   |    1 -
>>>>>  2 files changed, 3 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/conf/distro/angstrom-2010.x.conf b/conf/distro/angstrom-2010.x.conf
>>>>> index c6fb07d..3ac3847 100644
>>>>> --- a/conf/distro/angstrom-2010.x.conf
>>>>> +++ b/conf/distro/angstrom-2010.x.conf
>>>>> @@ -71,8 +71,8 @@ PREFERRED_VERSION_linux-libc-headers-native = "${LINUX_LIBC_HEADERS_VERSION}"
>>>>>  #Prefer glibc 2.6 and uclibc 0.9.30, these have had the most testing.
>>>>>  PREFERRED_VERSION_glibc              ?= "2.10.1"
>>>>>  PREFERRED_VERSION_glibc-initial      ?= "2.10.1"
>>>>> -PREFERRED_VERSION_uclibc             ?= "0.9.30.2"
>>>>> -PREFERRED_VERSION_uclibc-initial     ?= "0.9.30.2"
>>>>> +PREFERRED_VERSION_uclibc             ?= "git"
>>>>> +PREFERRED_VERSION_uclibc-initial     ?= "git"
>>>>>  PREFERRED_VERSION_eglibc             ?= "2.12"
>>>>>  PREFERRED_VERSION_eglibc-initial     ?= "2.12"
>>>>>
>>>>> @@ -95,7 +95,7 @@ ANGSTROM_GCC_VERSION_avr32          ?= "4.2.2"
>>>>>  #Everybody else can just use this:
>>>>>  ANGSTROM_GCC_VERSION                     ?= "4.5"
>>>>>
>>>>> -ANGSTROM_BINUTILS_VERSION                ?= "2.20.1"
>>>>> +ANGSTROM_BINUTILS_VERSION                ?= "2.21"
>>>>>
>>>>>  PREFERRED_VERSION_binutils               ?= "${ANGSTROM_BINUTILS_VERSION}"
>>>>>  PREFERRED_VERSION_binutils-cross         ?= "${ANGSTROM_BINUTILS_VERSION}"
>>>>> diff --git a/conf/distro/include/angstrom-2010-preferred-versions.inc b/conf/distro/include/angstrom-2010-preferred-versions.inc
>>>>> index 5532f29..66ee5ab 100644
>>>>> --- a/conf/distro/include/angstrom-2010-preferred-versions.inc
>>>>> +++ b/conf/distro/include/angstrom-2010-preferred-versions.inc
>>>>> @@ -66,7 +66,6 @@ PREFERRED_VERSION_samba             = "3.3.9"
>>>>>  PREFERRED_VERSION_tiff               = "3.9.4+4.0.0beta6"
>>>>>
>>>>>  PREFERRED_VERSION_udev               = "165"
>>>>> -PREFERRED_VERSION_udev_libc-uclibc = "141"
>>>>>  UDEV_GE_141 = "1"
>>>>>
>>>>>  PREFERRED_VERSION_usbutils = "0.86"
>>
>>>
>>>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>>
>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (Darwin)
>
> iD8DBQFNPUjjMkyGM64RGpERAhlFAJ0WQYEHLjLVp4uJAQ6N75/EYnCYegCfZdMK
> WxfAO9VF9GtRwgDa5cvFipA=
> =hJkJ
> -----END PGP SIGNATURE-----
>
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
Khem Raj - Jan. 24, 2011, 3:42 p.m.
On Mon, Jan 24, 2011 at 7:28 AM, Tom Rini <tom_rini@mentor.com> wrote:
>
> Not to put too many words into Khem's mouth, but I imagine it was that he
> checked this in on the same branch as the other changes he pushed last night
> and forgot (time for some 'git stash'ing Khem :))
>
>

yeah in order to send the review thru git format-patch/git send-email
you need to commit it somewhere
and this has bitten me more than once plus it was too late in the
night so I will forgive myself but look
for some pre-push hooks to show me what its pushing before it finally
does so. If anyone knows
of such a hook please lemme know
Andreas Oberritter - Jan. 24, 2011, 4:08 p.m.
Hello Khem,

On 01/24/2011 04:38 PM, Khem Raj wrote:
>> bah it was not intentionally pushed. I wanted to push the other gcc
>> change and git push
>> pushed all branches. I should probably not track remote branches that
>> way git push wont
>> do this kind of mess. Sorry for the hassle. Thank you for reverting it

you can set "git config push.default current" to push only the current
branch.

Regards,
Andreas

Patch

diff --git a/conf/distro/angstrom-2010.x.conf b/conf/distro/angstrom-2010.x.conf
index c6fb07d..3ac3847 100644
--- a/conf/distro/angstrom-2010.x.conf
+++ b/conf/distro/angstrom-2010.x.conf
@@ -71,8 +71,8 @@  PREFERRED_VERSION_linux-libc-headers-native = "${LINUX_LIBC_HEADERS_VERSION}"
 #Prefer glibc 2.6 and uclibc 0.9.30, these have had the most testing.
 PREFERRED_VERSION_glibc 		?= "2.10.1"
 PREFERRED_VERSION_glibc-initial 	?= "2.10.1"
-PREFERRED_VERSION_uclibc        	?= "0.9.30.2"
-PREFERRED_VERSION_uclibc-initial	?= "0.9.30.2"
+PREFERRED_VERSION_uclibc        	?= "git"
+PREFERRED_VERSION_uclibc-initial	?= "git"
 PREFERRED_VERSION_eglibc		?= "2.12"
 PREFERRED_VERSION_eglibc-initial	?= "2.12"
 
@@ -95,7 +95,7 @@  ANGSTROM_GCC_VERSION_avr32		?= "4.2.2"
 #Everybody else can just use this: 
 ANGSTROM_GCC_VERSION                     ?= "4.5"
 
-ANGSTROM_BINUTILS_VERSION                ?= "2.20.1"
+ANGSTROM_BINUTILS_VERSION                ?= "2.21"
 
 PREFERRED_VERSION_binutils               ?= "${ANGSTROM_BINUTILS_VERSION}"
 PREFERRED_VERSION_binutils-cross         ?= "${ANGSTROM_BINUTILS_VERSION}"
diff --git a/conf/distro/include/angstrom-2010-preferred-versions.inc b/conf/distro/include/angstrom-2010-preferred-versions.inc
index 5532f29..66ee5ab 100644
--- a/conf/distro/include/angstrom-2010-preferred-versions.inc
+++ b/conf/distro/include/angstrom-2010-preferred-versions.inc
@@ -66,7 +66,6 @@  PREFERRED_VERSION_samba		= "3.3.9"
 PREFERRED_VERSION_tiff 		= "3.9.4+4.0.0beta6"
 
 PREFERRED_VERSION_udev 		= "165"
-PREFERRED_VERSION_udev_libc-uclibc = "141"
 UDEV_GE_141 = "1"
 
 PREFERRED_VERSION_usbutils = "0.86"