Patchwork [0/1,denzil] linux-yocto: make validate_branches handle non BSP branches

login
register
mail settings
Submitter Bruce Ashfield
Date Aug. 13, 2012, 5:10 p.m.
Message ID <cover.1344876697.git.bruce.ashfield@windriver.com>
Download mbox
Permalink /patch/34337/
State New
Headers show

Pull-request

git://git.pokylinux.org/poky-contrib zedd/kernel-denzil

Comments

Bruce Ashfield - Aug. 13, 2012, 5:10 p.m.
Scott,

Here's a fix for validate_branches that comes from a pending master
change that I've been running for 3 weeks, and one that TomZ has tested
in his yocto BSP work on denzil.

It fixes some BSP use cases that involve setting a specific SRCREV
on a base branch, so that a BSP branch that doesn't yet exist can 
be created off of that known base. Previously only an existing BSP
branch could have it's SRCREV restricted.

cc: Tom Zanussi <tom.zanussi@intel.com>

Cheers,

Bruce

The following changes since commit 73cdebf60df225ee10f2eb215935be3b61e1b831:

  documentation/dev-manual/dev-manual-kernel-appendix.xml: Add note about conflict (2012-06-29 15:54:26 +0100)

are available in the git repository at:
  git://git.pokylinux.org/poky-contrib zedd/kernel-denzil
  http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel-denzil

Bruce Ashfield (1):
  linux-yocto: allow do_validate_branches to handle all branches

 meta/classes/kernel-yocto.bbclass |  119 +++++++++++++++++++++++++------------
 1 files changed, 80 insertions(+), 39 deletions(-)
Tom Zanussi - Aug. 22, 2012, 5:27 a.m.
On Mon, 2012-08-13 at 13:10 -0400, Bruce Ashfield wrote:
> Scott,
> 
> Here's a fix for validate_branches that comes from a pending master
> change that I've been running for 3 weeks, and one that TomZ has tested
> in his yocto BSP work on denzil.
> 
> It fixes some BSP use cases that involve setting a specific SRCREV
> on a base branch, so that a BSP branch that doesn't yet exist can 
> be created off of that known base. Previously only an existing BSP
> branch could have it's SRCREV restricted.
> 

Hi Scott,

I don't see this in denzil - do you have it queued for the next pull
request, or did it get missed?

Tom

> cc: Tom Zanussi <tom.zanussi@intel.com>
> 
> Cheers,
> 
> Bruce
> 
> The following changes since commit 73cdebf60df225ee10f2eb215935be3b61e1b831:
> 
>   documentation/dev-manual/dev-manual-kernel-appendix.xml: Add note about conflict (2012-06-29 15:54:26 +0100)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib zedd/kernel-denzil
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel-denzil
> 
> Bruce Ashfield (1):
>   linux-yocto: allow do_validate_branches to handle all branches
> 
>  meta/classes/kernel-yocto.bbclass |  119 +++++++++++++++++++++++++------------
>  1 files changed, 80 insertions(+), 39 deletions(-)
>
Bruce Ashfield - Aug. 22, 2012, 5:48 a.m.
On 12-08-22 1:27 AM, Tom Zanussi wrote:
> On Mon, 2012-08-13 at 13:10 -0400, Bruce Ashfield wrote:
>> Scott,
>>
>> Here's a fix for validate_branches that comes from a pending master
>> change that I've been running for 3 weeks, and one that TomZ has tested
>> in his yocto BSP work on denzil.
>>
>> It fixes some BSP use cases that involve setting a specific SRCREV
>> on a base branch, so that a BSP branch that doesn't yet exist can
>> be created off of that known base. Previously only an existing BSP
>> branch could have it's SRCREV restricted.
>>
>
> Hi Scott,
>
> I don't see this in denzil - do you have it queued for the next pull
> request, or did it get missed?

I was wondering the same thing, in particular, since I just made a minor
tweak to this in master (which I'll send out tomorrow). The attached
patch should also be merged to denzil.

Bruce

>
> Tom
>
>> cc: Tom Zanussi<tom.zanussi@intel.com>
>>
>> Cheers,
>>
>> Bruce
>>
>> The following changes since commit 73cdebf60df225ee10f2eb215935be3b61e1b831:
>>
>>    documentation/dev-manual/dev-manual-kernel-appendix.xml: Add note about conflict (2012-06-29 15:54:26 +0100)
>>
>> are available in the git repository at:
>>    git://git.pokylinux.org/poky-contrib zedd/kernel-denzil
>>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel-denzil
>>
>> Bruce Ashfield (1):
>>    linux-yocto: allow do_validate_branches to handle all branches
>>
>>   meta/classes/kernel-yocto.bbclass |  119 +++++++++++++++++++++++++------------
>>   1 files changed, 80 insertions(+), 39 deletions(-)
>>
>
>
Tom Zanussi - Aug. 23, 2012, 7:18 p.m.
On Wed, 2012-08-22 at 01:48 -0400, Bruce Ashfield wrote:
> On 12-08-22 1:27 AM, Tom Zanussi wrote:
> > On Mon, 2012-08-13 at 13:10 -0400, Bruce Ashfield wrote:
> >> Scott,
> >>
> >> Here's a fix for validate_branches that comes from a pending master
> >> change that I've been running for 3 weeks, and one that TomZ has tested
> >> in his yocto BSP work on denzil.
> >>
> >> It fixes some BSP use cases that involve setting a specific SRCREV
> >> on a base branch, so that a BSP branch that doesn't yet exist can
> >> be created off of that known base. Previously only an existing BSP
> >> branch could have it's SRCREV restricted.
> >>
> >
> > Hi Scott,
> >
> > I don't see this in denzil - do you have it queued for the next pull
> > request, or did it get missed?
> 
> I was wondering the same thing, in particular, since I just made a minor
> tweak to this in master (which I'll send out tomorrow). The attached
> patch should also be merged to denzil.
> 

I tried the above patch on top of the other, built and booted a qemu arm
bsp generated by yocto-bsp, and didn't see any problems FWIW...

Tom

> Bruce
> 
> >
> > Tom
> >
> >> cc: Tom Zanussi<tom.zanussi@intel.com>
> >>
> >> Cheers,
> >>
> >> Bruce
> >>
> >> The following changes since commit 73cdebf60df225ee10f2eb215935be3b61e1b831:
> >>
> >>    documentation/dev-manual/dev-manual-kernel-appendix.xml: Add note about conflict (2012-06-29 15:54:26 +0100)
> >>
> >> are available in the git repository at:
> >>    git://git.pokylinux.org/poky-contrib zedd/kernel-denzil
> >>    http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel-denzil
> >>
> >> Bruce Ashfield (1):
> >>    linux-yocto: allow do_validate_branches to handle all branches
> >>
> >>   meta/classes/kernel-yocto.bbclass |  119 +++++++++++++++++++++++++------------
> >>   1 files changed, 80 insertions(+), 39 deletions(-)
> >>
> >
> >
>
Bruce Ashfield - Aug. 23, 2012, 7:21 p.m.
On 12-08-23 03:18 PM, Tom Zanussi wrote:
> On Wed, 2012-08-22 at 01:48 -0400, Bruce Ashfield wrote:
>> On 12-08-22 1:27 AM, Tom Zanussi wrote:
>>> On Mon, 2012-08-13 at 13:10 -0400, Bruce Ashfield wrote:
>>>> Scott,
>>>>
>>>> Here's a fix for validate_branches that comes from a pending master
>>>> change that I've been running for 3 weeks, and one that TomZ has tested
>>>> in his yocto BSP work on denzil.
>>>>
>>>> It fixes some BSP use cases that involve setting a specific SRCREV
>>>> on a base branch, so that a BSP branch that doesn't yet exist can
>>>> be created off of that known base. Previously only an existing BSP
>>>> branch could have it's SRCREV restricted.
>>>>
>>>
>>> Hi Scott,
>>>
>>> I don't see this in denzil - do you have it queued for the next pull
>>> request, or did it get missed?
>>
>> I was wondering the same thing, in particular, since I just made a minor
>> tweak to this in master (which I'll send out tomorrow). The attached
>> patch should also be merged to denzil.
>>
>
> I tried the above patch on top of the other, built and booted a qemu arm
> bsp generated by yocto-bsp, and didn't see any problems FWIW...

Good news. It will make the bsp tooling more robust for new boards.

Cheers,

Bruce

>
> Tom
>
>> Bruce
>>
>>>
>>> Tom
>>>
>>>> cc: Tom Zanussi<tom.zanussi@intel.com>
>>>>
>>>> Cheers,
>>>>
>>>> Bruce
>>>>
>>>> The following changes since commit 73cdebf60df225ee10f2eb215935be3b61e1b831:
>>>>
>>>>     documentation/dev-manual/dev-manual-kernel-appendix.xml: Add note about conflict (2012-06-29 15:54:26 +0100)
>>>>
>>>> are available in the git repository at:
>>>>     git://git.pokylinux.org/poky-contrib zedd/kernel-denzil
>>>>     http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel-denzil
>>>>
>>>> Bruce Ashfield (1):
>>>>     linux-yocto: allow do_validate_branches to handle all branches
>>>>
>>>>    meta/classes/kernel-yocto.bbclass |  119 +++++++++++++++++++++++++------------
>>>>    1 files changed, 80 insertions(+), 39 deletions(-)
>>>>
>>>
>>>
>>
>
>
Scott Garman - Aug. 24, 2012, 8:08 a.m.
On 08/21/2012 10:27 PM, Tom Zanussi wrote:
> On Mon, 2012-08-13 at 13:10 -0400, Bruce Ashfield wrote:
>> Scott,
>>
>> Here's a fix for validate_branches that comes from a pending master
>> change that I've been running for 3 weeks, and one that TomZ has tested
>> in his yocto BSP work on denzil.
>>
>> It fixes some BSP use cases that involve setting a specific SRCREV
>> on a base branch, so that a BSP branch that doesn't yet exist can
>> be created off of that known base. Previously only an existing BSP
>> branch could have it's SRCREV restricted.
>>
>
> Hi Scott,
>
> I don't see this in denzil - do you have it queued for the next pull
> request, or did it get missed?
>
> Tom

Sorry about this - it did get missed. I now have it in my denzil-next 
branches and I'm planning to submit a pull request sometime next week.

Scott