Patchwork [oe-core] qwt: fix link error when linking with ld-gold.

login
mail settings
Submitter Marc Reilly
Date Aug. 12, 2012, 8:50 a.m.
Message ID <1344761452-10965-1-git-send-email-marc@cpdesign.com.au>
Download mbox | patch
Permalink /patch/34301/
State Changes Requested, archived
Headers show

Comments

Marc Reilly - Aug. 12, 2012, 8:50 a.m.
ld-gold doesn't implicitly link with librt, this fixes an unresolved
symbol error when compiling qwt examples.

Signed-off-by: Marc Reilly <marc@cpdesign.com.au>
---
 .../recipes-qt/qwt/files/fix-ld-gold-linking.patch |   14 ++++++++++++++
 meta-oe/recipes-qt/qwt/qwt.inc                     |    1 +
 2 files changed, 15 insertions(+), 0 deletions(-)
 create mode 100644 meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch
Martin Jansa - Aug. 12, 2012, 9:16 a.m.
On Sun, Aug 12, 2012 at 06:50:52PM +1000, Marc Reilly wrote:
> ld-gold doesn't implicitly link with librt, this fixes an unresolved
> symbol error when compiling qwt examples.
> 
> Signed-off-by: Marc Reilly <marc@cpdesign.com.au>
> ---
>  .../recipes-qt/qwt/files/fix-ld-gold-linking.patch |   14 ++++++++++++++
>  meta-oe/recipes-qt/qwt/qwt.inc                     |    1 +
>  2 files changed, 15 insertions(+), 0 deletions(-)
>  create mode 100644 meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch
> 
> diff --git a/meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch b/meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch
> new file mode 100644
> index 0000000..a00aba4
> --- /dev/null
> +++ b/meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch
> @@ -0,0 +1,14 @@
> +- fix link of unresolved symbols: clock_getres and clock_gettime
> +---
> +diff --git a/src/src.pro b/src/src.pro
> +index beb7125..ebf8ea6 100644
> +--- a/src/src.pro
> ++++ b/src/src.pro
> +@@ -94,6 +102,7 @@ SOURCES += \
> +     qwt_symbol.cpp \
> +     qwt_system_clock.cpp
> + 
> ++linux*:LIBS += -lrt
> +  
> + contains(QWT_CONFIG, QwtPlot) {
> +  
> diff --git a/meta-oe/recipes-qt/qwt/qwt.inc b/meta-oe/recipes-qt/qwt/qwt.inc
> index a299ac8..94231b4 100644
> --- a/meta-oe/recipes-qt/qwt/qwt.inc
> +++ b/meta-oe/recipes-qt/qwt/qwt.inc
> @@ -7,6 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=dac2743472b0462ff3cfb4af42051c88"
>  
>  SRC_URI = "${SOURCEFORGE_MIRROR}/qwt/qwt-${PV}.tar.bz2;name=qwt \
>  	file://qwt6.patch \
> +        file://fix-ld-gold-linking.patch \
>  	"

Please don't mix tabs and spaces for indentation.

Spaces should be used for multiline variables, so your line is right,
please change 2nd and last (of SRC_URI). Thanks

>  
>  S = "${WORKDIR}/qwt-${PV}"
> -- 
> 1.7.7
> 
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
Saul Wold - Aug. 12, 2012, 10:48 a.m.
On 08/12/2012 11:50 AM, Marc Reilly wrote:
> ld-gold doesn't implicitly link with librt, this fixes an unresolved
> symbol error when compiling qwt examples.
>
> Signed-off-by: Marc Reilly <marc@cpdesign.com.au>
> ---
>   .../recipes-qt/qwt/files/fix-ld-gold-linking.patch |   14 ++++++++++++++
>   meta-oe/recipes-qt/qwt/qwt.inc                     |    1 +
>   2 files changed, 15 insertions(+), 0 deletions(-)
>   create mode 100644 meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch
>
> diff --git a/meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch b/meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch
> new file mode 100644
> index 0000000..a00aba4
> --- /dev/null
> +++ b/meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch
> @@ -0,0 +1,14 @@
> +- fix link of unresolved symbols: clock_getres and clock_gettime
> +---
Patch needs Signed-off-by and Upstream-Status Tags please

Thanks

Sau!
> +diff --git a/src/src.pro b/src/src.pro
> +index beb7125..ebf8ea6 100644
> +--- a/src/src.pro
> ++++ b/src/src.pro
> +@@ -94,6 +102,7 @@ SOURCES += \
> +     qwt_symbol.cpp \
> +     qwt_system_clock.cpp
> +
> ++linux*:LIBS += -lrt
> +
> + contains(QWT_CONFIG, QwtPlot) {
> +
> diff --git a/meta-oe/recipes-qt/qwt/qwt.inc b/meta-oe/recipes-qt/qwt/qwt.inc
> index a299ac8..94231b4 100644
> --- a/meta-oe/recipes-qt/qwt/qwt.inc
> +++ b/meta-oe/recipes-qt/qwt/qwt.inc
> @@ -7,6 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=dac2743472b0462ff3cfb4af42051c88"
>
>   SRC_URI = "${SOURCEFORGE_MIRROR}/qwt/qwt-${PV}.tar.bz2;name=qwt \
>   	file://qwt6.patch \
> +        file://fix-ld-gold-linking.patch \
>   	"
>
>   S = "${WORKDIR}/qwt-${PV}"
>

Patch

diff --git a/meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch b/meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch
new file mode 100644
index 0000000..a00aba4
--- /dev/null
+++ b/meta-oe/recipes-qt/qwt/files/fix-ld-gold-linking.patch
@@ -0,0 +1,14 @@ 
+- fix link of unresolved symbols: clock_getres and clock_gettime
+---
+diff --git a/src/src.pro b/src/src.pro
+index beb7125..ebf8ea6 100644
+--- a/src/src.pro
++++ b/src/src.pro
+@@ -94,6 +102,7 @@ SOURCES += \
+     qwt_symbol.cpp \
+     qwt_system_clock.cpp
+ 
++linux*:LIBS += -lrt
+  
+ contains(QWT_CONFIG, QwtPlot) {
+  
diff --git a/meta-oe/recipes-qt/qwt/qwt.inc b/meta-oe/recipes-qt/qwt/qwt.inc
index a299ac8..94231b4 100644
--- a/meta-oe/recipes-qt/qwt/qwt.inc
+++ b/meta-oe/recipes-qt/qwt/qwt.inc
@@ -7,6 +7,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=dac2743472b0462ff3cfb4af42051c88"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/qwt/qwt-${PV}.tar.bz2;name=qwt \
 	file://qwt6.patch \
+        file://fix-ld-gold-linking.patch \
 	"
 
 S = "${WORKDIR}/qwt-${PV}"