Patchwork [1/1] at 3.1.13: get 'at' depends on 'flex-native' explicitly

login
register
mail settings
Submitter wenzong.fan@windriver.com
Date Aug. 9, 2012, 2:59 a.m.
Message ID <ab9afe9c0eab7dc2d9832cd2afabe1eededc7cae.1344480978.git.wenzong.fan@windriver.com>
Download mbox | patch
Permalink /patch/34115/
State Accepted
Commit f5a722a1db6315ba945c41551c60b1ef2c8b647f
Headers show

Comments

wenzong.fan@windriver.com - Aug. 9, 2012, 2:59 a.m.
From: Wenzong Fan <wenzong.fan@windriver.com>

'at' needs flex to generate source file lex.yy.c, but it doesn't
depend on flex-native directly; This maybe cause a do_compile
failure if flex-native is not built or included in project.

Error message is:
    error: lex.yy.c: No such file or directory

Get 'at' depends on flex-native to fix this potential issue.

[YOCTO #2919]

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
 meta/recipes-extended/at/at_3.1.13.bb |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Paul Eggleton - Aug. 9, 2012, 1:44 p.m.
On Thursday 09 August 2012 10:59:15 wenzong.fan@windriver.com wrote:
> From: Wenzong Fan <wenzong.fan@windriver.com>
> 
> 'at' needs flex to generate source file lex.yy.c, but it doesn't
> depend on flex-native directly; This maybe cause a do_compile
> failure if flex-native is not built or included in project.
> 
> Error message is:
>     error: lex.yy.c: No such file or directory
> 
> Get 'at' depends on flex-native to fix this potential issue.
> 
> [YOCTO #2919]
> 
> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
>  meta/recipes-extended/at/at_3.1.13.bb |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-extended/at/at_3.1.13.bb
> b/meta/recipes-extended/at/at_3.1.13.bb index ce9396a..a391d6e 100644
> --- a/meta/recipes-extended/at/at_3.1.13.bb
> +++ b/meta/recipes-extended/at/at_3.1.13.bb
> @@ -4,14 +4,14 @@ the system load levels drop to a particular level."
>  SECTION = "base"
>  LICENSE="GPLv2+"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=4325afd396febcb659c36b49533135d4"
> -DEPENDS = "flex initscripts \
> +DEPENDS = "flex flex-native initscripts \

Does it need flex for the target as well, or was it a case of "flex" being added 
instead of "flex-native" by mistake?

Cheers,
Paul
Saul Wold - Aug. 9, 2012, 1:57 p.m.
On 08/09/2012 05:59 AM, wenzong.fan@windriver.com wrote:
> From: Wenzong Fan <wenzong.fan@windriver.com>
>
> 'at' needs flex to generate source file lex.yy.c, but it doesn't
> depend on flex-native directly; This maybe cause a do_compile
> failure if flex-native is not built or included in project.
>
> Error message is:
>      error: lex.yy.c: No such file or directory
>
> Get 'at' depends on flex-native to fix this potential issue.
>
> [YOCTO #2919]
>
> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
>   meta/recipes-extended/at/at_3.1.13.bb |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/at/at_3.1.13.bb b/meta/recipes-extended/at/at_3.1.13.bb
> index ce9396a..a391d6e 100644
> --- a/meta/recipes-extended/at/at_3.1.13.bb
> +++ b/meta/recipes-extended/at/at_3.1.13.bb
> @@ -4,14 +4,14 @@ the system load levels drop to a particular level."
>   SECTION = "base"
>   LICENSE="GPLv2+"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=4325afd396febcb659c36b49533135d4"
> -DEPENDS = "flex initscripts \
> +DEPENDS = "flex flex-native initscripts \
Ok, I understand the flex-native dependency, that makes sense, but I 
wonder why there was a dependency on flex originally?  Is that actually 
needed?

Sau!

>   	${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
>   RDEPENDS_${PN} = "${@base_contains('DISTRO_FEATURES', 'pam', '${PAM_DEPS}', '', d)}"
>   PAM_DEPS = "libpam libpam-runtime pam-plugin-env pam-plugin-limits"
>
>   RCONFLICTS_${PN} = "atd"
>   RREPLACES_${PN} = "atd"
> -PR = "r2"
> +PR = "r3"
>
>   SRC_URI = "${DEBIAN_MIRROR}/main/a/at/at_${PV}.orig.tar.gz \
>       file://configure.patch \
>
wenzong.fan@windriver.com - Aug. 10, 2012, 1:49 a.m.
On 08/09/2012 09:01 PM, Paul Eggleton wrote:
> On Thursday 09 August 2012 10:59:15 wenzong.fan@windriver.com wrote:
>> From: Wenzong Fan<wenzong.fan@windriver.com>
>>
>> 'at' needs flex to generate source file lex.yy.c, but it doesn't
>> depend on flex-native directly; This maybe cause a do_compile
>> failure if flex-native is not built or included in project.
>>
>> Error message is:
>>      error: lex.yy.c: No such file or directory
>>
>> Get 'at' depends on flex-native to fix this potential issue.
>>
>> [YOCTO #2919]
>>
>> Signed-off-by: Wenzong Fan<wenzong.fan@windriver.com>
>> ---
>>   meta/recipes-extended/at/at_3.1.13.bb |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-extended/at/at_3.1.13.bb
>> b/meta/recipes-extended/at/at_3.1.13.bb index ce9396a..a391d6e 100644
>> --- a/meta/recipes-extended/at/at_3.1.13.bb
>> +++ b/meta/recipes-extended/at/at_3.1.13.bb
>> @@ -4,14 +4,14 @@ the system load levels drop to a particular level."
>>   SECTION = "base"
>>   LICENSE="GPLv2+"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=4325afd396febcb659c36b49533135d4"
>> -DEPENDS = "flex initscripts \
>> +DEPENDS = "flex flex-native initscripts \
>
> Does it need flex for the target as well, or was it a case of "flex" being added
> instead of "flex-native" by mistake?

Yes, it is needed.

I removed 'flex' from DEPENDS, the build failed with:
---------------------------
i586-poky-linux-gcc  -m32   -march=i586 
--sysroot=/buildarea/wfan/at/tmp/sysroots/qemux86 -I. -O2 -pipe -g 
-feliminate-unused-debug-types -o at at.o panic.o perm.o posixtm.o 
y.tab.o lex.yy.o   -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
| lex.yy.o: In function `yylex':
| 
/buildarea/wfan/at/tmp/work/i586-poky-linux/at-3.1.13-r2/at-3.1.13/lex.yy.c:1247: 
undefined reference to `yywrap'
| collect2: error: ld returned 1 exit status
---------------------------

Thanks
Wenzong

>
> Cheers,
> Paul
>

Patch

diff --git a/meta/recipes-extended/at/at_3.1.13.bb b/meta/recipes-extended/at/at_3.1.13.bb
index ce9396a..a391d6e 100644
--- a/meta/recipes-extended/at/at_3.1.13.bb
+++ b/meta/recipes-extended/at/at_3.1.13.bb
@@ -4,14 +4,14 @@  the system load levels drop to a particular level."
 SECTION = "base"
 LICENSE="GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=4325afd396febcb659c36b49533135d4"
-DEPENDS = "flex initscripts \
+DEPENDS = "flex flex-native initscripts \
 	${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
 RDEPENDS_${PN} = "${@base_contains('DISTRO_FEATURES', 'pam', '${PAM_DEPS}', '', d)}"
 PAM_DEPS = "libpam libpam-runtime pam-plugin-env pam-plugin-limits"
 
 RCONFLICTS_${PN} = "atd"
 RREPLACES_${PN} = "atd"
-PR = "r2"
+PR = "r3"
 
 SRC_URI = "${DEBIAN_MIRROR}/main/a/at/at_${PV}.orig.tar.gz \
     file://configure.patch \