Patchwork [1/1] sysfsutils: install libs to base_libdir

login
register
mail settings
Submitter wenzong.fan@windriver.com
Date Aug. 7, 2012, 12:14 p.m.
Message ID <38e3b88585fd93495837f9f071887989a080ccd6.1344341416.git.wenzong.fan@windriver.com>
Download mbox | patch
Permalink /patch/34037/
State Accepted
Commit f3c93627d4f603f9e4c4491d89eb988aa6241662
Headers show

Comments

wenzong.fan@windriver.com - Aug. 7, 2012, 12:14 p.m.
From: Wenzong Fan <wenzong.fan@windriver.com>

Fix the warning form pcmciautils building:

"WARNING: QA Issue: pcmciautils: /sbin/pccardctl, installed in the
base_prefix, requires a shared library under exec_prefix (/usr):
libsysfs.so.2 => /usr/lib/libsysfs.so.2"

Just refer to Debian/Ubuntu distributions, install sysfsutils libs
to "/lib*" instead of "/usr/lib*".

[YOCTO #2907]

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
 meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Koen Kooi - Aug. 7, 2012, 12:23 p.m.
Op 7 aug. 2012, om 14:14 heeft wenzong.fan@windriver.com het volgende geschreven:

> From: Wenzong Fan <wenzong.fan@windriver.com>
> 
> Fix the warning form pcmciautils building:
> 
> "WARNING: QA Issue: pcmciautils: /sbin/pccardctl, installed in the
> base_prefix, requires a shared library under exec_prefix (/usr):
> libsysfs.so.2 => /usr/lib/libsysfs.so.2"
> 
> Just refer to Debian/Ubuntu distributions, install sysfsutils libs
> to "/lib*" instead of "/usr/lib*".
> 
> [YOCTO #2907]
> 
> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
> meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb |    4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb b/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
> index 3e4fdda..f01d19b 100644
> --- a/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
> +++ b/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
> @@ -8,7 +8,7 @@ LICENSE_libsysfs = "LGPLv2.1"
> LIC_FILES_CHKSUM = "file://COPYING;md5=3d06403ea54c7574a9e581c6478cc393 \
>                     file://cmd/GPL;md5=d41d4e2e1e108554e0388ea4aecd8d27 \
>                     file://lib/LGPL;md5=b75d069791103ffe1c0d6435deeff72e"
> -PR = "r3"
> +PR = "r4"
> 
> SRC_URI = "${SOURCEFORGE_MIRROR}/linux-diag/sysfsutils-${PV}.tar.gz \
> 	  file://sysfsutils-2.0.0-class-dup.patch \
> @@ -24,3 +24,5 @@ PACKAGES =+ "libsysfs libsysfs-dev libsysfs-staticdev"
> FILES_libsysfs = "${libdir}/lib*${SOLIBS}"
> FILES_libsysfs-dev = "${libdir}/lib*${SOLIBSDEV} ${includedir}"
> FILES_libsysfs-staticdev = "${libdir}/lib*.a"

Ahem! ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

> +
> +export libdir = "${base_libdir}"

And can you post the buildhistory diff to see if anything else moved when it shouldn't have e.g. package config files?
wenzong.fan@windriver.com - Aug. 8, 2012, 6:09 a.m.
On 08/07/2012 08:23 PM, Koen Kooi wrote:
>
> Op 7 aug. 2012, om 14:14 heeft wenzong.fan@windriver.com het volgende geschreven:
>
>> From: Wenzong Fan<wenzong.fan@windriver.com>
>>
>> Fix the warning form pcmciautils building:
>>
>> "WARNING: QA Issue: pcmciautils: /sbin/pccardctl, installed in the
>> base_prefix, requires a shared library under exec_prefix (/usr):
>> libsysfs.so.2 =>  /usr/lib/libsysfs.so.2"
>>
>> Just refer to Debian/Ubuntu distributions, install sysfsutils libs
>> to "/lib*" instead of "/usr/lib*".
>>
>> [YOCTO #2907]
>>
>> Signed-off-by: Wenzong Fan<wenzong.fan@windriver.com>
>> ---
>> meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb |    4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb b/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
>> index 3e4fdda..f01d19b 100644
>> --- a/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
>> +++ b/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
>> @@ -8,7 +8,7 @@ LICENSE_libsysfs = "LGPLv2.1"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=3d06403ea54c7574a9e581c6478cc393 \
>>                      file://cmd/GPL;md5=d41d4e2e1e108554e0388ea4aecd8d27 \
>>                      file://lib/LGPL;md5=b75d069791103ffe1c0d6435deeff72e"
>> -PR = "r3"
>> +PR = "r4"
>>
>> SRC_URI = "${SOURCEFORGE_MIRROR}/linux-diag/sysfsutils-${PV}.tar.gz \
>> 	  file://sysfsutils-2.0.0-class-dup.patch \
>> @@ -24,3 +24,5 @@ PACKAGES =+ "libsysfs libsysfs-dev libsysfs-staticdev"
>> FILES_libsysfs = "${libdir}/lib*${SOLIBS}"
>> FILES_libsysfs-dev = "${libdir}/lib*${SOLIBSDEV} ${includedir}"
>> FILES_libsysfs-staticdev = "${libdir}/lib*.a"
>
> Ahem! ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>
>> +
>> +export libdir = "${base_libdir}"
>
> And can you post the buildhistory diff to see if anything else moved when it shouldn't have e.g. package config files?

I make a diff to the build dir, only the location of 'lib/' was moved:
------------------------
Only in sysfsutils-2.1.0-r4.new/image: lib
Only in sysfsutils-2.1.0-r4.old/image/usr: lib
Only in sysfsutils-2.1.0-r4.new/package: lib
Only in sysfsutils-2.1.0-r4.old/package/usr: lib
Only in sysfsutils-2.1.0-r4.new/packages-split/libsysfs: lib
Only in sysfsutils-2.1.0-r4.old/packages-split/libsysfs: usr
Only in sysfsutils-2.1.0-r4.new/packages-split/libsysfs-dev: lib
Only in sysfsutils-2.1.0-r4.old/packages-split/libsysfs-dev/usr: lib
Only in sysfsutils-2.1.0-r4.new/packages-split/libsysfs-staticdev: lib
Only in sysfsutils-2.1.0-r4.old/packages-split/libsysfs-staticdev: usr
Only in sysfsutils-2.1.0-r4.new/packages-split/sysfsutils-dbg: lib
Only in sysfsutils-2.1.0-r4.old/packages-split/sysfsutils-dbg/usr: lib
Only in sysfsutils-2.1.0-r4.new/packages-split/sysfsutils-dev: lib
Only in sysfsutils-2.1.0-r4.old/packages-split/sysfsutils-dev: usr
Only in sysfsutils-2.1.0-r4.new/sysroot-destdir: lib
Only in sysfsutils-2.1.0-r4.old/sysroot-destdir/usr: lib
------------------------

Thanks
Wenzong

> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Koen Kooi - Aug. 8, 2012, 8:44 a.m.
Op 8 aug. 2012, om 08:09 heeft wenzong fan <wenzong.fan@windriver.com> het volgende geschreven:

> On 08/07/2012 08:23 PM, Koen Kooi wrote:
>> 
>> Op 7 aug. 2012, om 14:14 heeft wenzong.fan@windriver.com het volgende geschreven:
>> 
>>> From: Wenzong Fan<wenzong.fan@windriver.com>
>>> 
>>> Fix the warning form pcmciautils building:
>>> 
>>> "WARNING: QA Issue: pcmciautils: /sbin/pccardctl, installed in the
>>> base_prefix, requires a shared library under exec_prefix (/usr):
>>> libsysfs.so.2 =>  /usr/lib/libsysfs.so.2"
>>> 
>>> Just refer to Debian/Ubuntu distributions, install sysfsutils libs
>>> to "/lib*" instead of "/usr/lib*".
>>> 
>>> [YOCTO #2907]
>>> 
>>> Signed-off-by: Wenzong Fan<wenzong.fan@windriver.com>
>>> ---
>>> meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb |    4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>> 
>>> diff --git a/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb b/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
>>> index 3e4fdda..f01d19b 100644
>>> --- a/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
>>> +++ b/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
>>> @@ -8,7 +8,7 @@ LICENSE_libsysfs = "LGPLv2.1"
>>> LIC_FILES_CHKSUM = "file://COPYING;md5=3d06403ea54c7574a9e581c6478cc393 \
>>>                     file://cmd/GPL;md5=d41d4e2e1e108554e0388ea4aecd8d27 \
>>>                     file://lib/LGPL;md5=b75d069791103ffe1c0d6435deeff72e"
>>> -PR = "r3"
>>> +PR = "r4"
>>> 
>>> SRC_URI = "${SOURCEFORGE_MIRROR}/linux-diag/sysfsutils-${PV}.tar.gz \
>>> 	  file://sysfsutils-2.0.0-class-dup.patch \
>>> @@ -24,3 +24,5 @@ PACKAGES =+ "libsysfs libsysfs-dev libsysfs-staticdev"
>>> FILES_libsysfs = "${libdir}/lib*${SOLIBS}"
>>> FILES_libsysfs-dev = "${libdir}/lib*${SOLIBSDEV} ${includedir}"
>>> FILES_libsysfs-staticdev = "${libdir}/lib*.a"
>> 
>> Ahem! ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> 
>>> +
>>> +export libdir = "${base_libdir}"
>> 
>> And can you post the buildhistory diff to see if anything else moved when it shouldn't have e.g. package config files?
> 
> I make a diff to the build dir, only the location of 'lib/' was moved:

Please post the buildhistory diff, that is much more informative. And you haven't responded to the FILES_lib* oversight.

Patch

diff --git a/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb b/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
index 3e4fdda..f01d19b 100644
--- a/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
+++ b/meta/recipes-core/sysfsutils/sysfsutils_2.1.0.bb
@@ -8,7 +8,7 @@  LICENSE_libsysfs = "LGPLv2.1"
 LIC_FILES_CHKSUM = "file://COPYING;md5=3d06403ea54c7574a9e581c6478cc393 \
                     file://cmd/GPL;md5=d41d4e2e1e108554e0388ea4aecd8d27 \
                     file://lib/LGPL;md5=b75d069791103ffe1c0d6435deeff72e"
-PR = "r3"
+PR = "r4"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/linux-diag/sysfsutils-${PV}.tar.gz \
 	  file://sysfsutils-2.0.0-class-dup.patch \
@@ -24,3 +24,5 @@  PACKAGES =+ "libsysfs libsysfs-dev libsysfs-staticdev"
 FILES_libsysfs = "${libdir}/lib*${SOLIBS}"
 FILES_libsysfs-dev = "${libdir}/lib*${SOLIBSDEV} ${includedir}"
 FILES_libsysfs-staticdev = "${libdir}/lib*.a"
+
+export libdir = "${base_libdir}"