Patchwork [v2,08/28] ubootchart: use variables instead of hardcoded paths

login
register
mail settings
Submitter Javier Martinez Canillas
Date Aug. 5, 2012, 7:48 p.m.
Message ID <1344196136-7643-9-git-send-email-javier@dowhile0.org>
Download mbox | patch
Permalink /patch/33917/
State Accepted
Commit 73ee5587a46751ed39a181b3ff2a12d4a3086c21
Headers show

Comments

Javier Martinez Canillas - Aug. 5, 2012, 7:48 p.m.
It is considered good practice to use the build system provided
variables instead of directly specify hardcoded paths.

Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
---
 meta/recipes-devtools/ubootchart/ubootchart_svn.bb |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

Patch

diff --git a/meta/recipes-devtools/ubootchart/ubootchart_svn.bb b/meta/recipes-devtools/ubootchart/ubootchart_svn.bb
index b49e94a..843024c 100644
--- a/meta/recipes-devtools/ubootchart/ubootchart_svn.bb
+++ b/meta/recipes-devtools/ubootchart/ubootchart_svn.bb
@@ -4,7 +4,7 @@  LICENSE = "GPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=8f0e2cd40e05189ec81232da84bd6e1a"
 SRCREV = "12"
 PV = "0.0+r${SRCPV}"
-PR = "r5"
+PR = "r6"
 
 #RRECOMMENDS_${PN} = "acct"
 
@@ -27,13 +27,13 @@  do_compile() {
 }
 
 do_install() {
-        install -m 0755 -d ${D}/sbin ${D}/etc/ubootchart ${D}/usr/share/applications
-        install -m 0755 ${S}/ubootchartd_bin ${D}/sbin
-        install -m 0755 ${S}/ubootchartd ${D}/sbin
-        install -m 0644 ${S}/ubootchart.conf ${D}/etc/ubootchart
-        install -m 0755 ${S}/start.sh ${D}/etc/ubootchart
-        install -m 0755 ${S}/finish.sh ${D}/etc/ubootchart
+        install -m 0755 -d ${D}${base_sbindir} ${D}${sysconfdir}/ubootchart ${D}${datadir}/applications
+        install -m 0755 ${S}/ubootchartd_bin ${D}${base_sbindir}
+        install -m 0755 ${S}/ubootchartd ${D}${base_sbindir}
+        install -m 0644 ${S}/ubootchart.conf ${D}${sysconfdir}/ubootchart
+        install -m 0755 ${S}/start.sh ${D}${sysconfdir}/ubootchart
+        install -m 0755 ${S}/finish.sh ${D}${sysconfdir}/ubootchart
         
-        install -m 0755 ${WORKDIR}/ubootchart-stop ${D}/sbin
-        install -m 0644 ${WORKDIR}/ubootchart.desktop ${D}/usr/share/applications
+        install -m 0755 ${WORKDIR}/ubootchart-stop ${D}${base_sbindir}
+        install -m 0644 ${WORKDIR}/ubootchart.desktop ${D}${datadir}/applications
 }