Patchwork [v2,01/28] xinetd: use ${sbindir} and ${sysconfdir} instead of /usr/sbin and /etc

login
register
mail settings
Submitter Javier Martinez Canillas
Date Aug. 5, 2012, 7:48 p.m.
Message ID <1344196136-7643-2-git-send-email-javier@dowhile0.org>
Download mbox | patch
Permalink /patch/33905/
State Accepted
Commit 6f0eebbd12d79a86dd4a79f87b6be4758439a3f5
Headers show

Comments

Javier Martinez Canillas - Aug. 5, 2012, 7:48 p.m.
It is considered good practice to use the build system provided
variables instead of directly specify hardcoded paths.

Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
---
 meta/recipes-extended/xinetd/xinetd_2.3.15.bb |   20 ++++++++++----------
 1 files changed, 10 insertions(+), 10 deletions(-)

Patch

diff --git a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb
index a142143..2139e74 100644
--- a/meta/recipes-extended/xinetd/xinetd_2.3.15.bb
+++ b/meta/recipes-extended/xinetd/xinetd_2.3.15.bb
@@ -7,7 +7,7 @@  LICENSE = "BSD"
 LIC_FILES_CHKSUM = "file://COPYRIGHT;md5=8ad8615198542444f84d28a6cf226dd8"
 
 DEPENDS = ""
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "http://www.xinetd.org/xinetd-${PV}.tar.gz \
       file://xinetd.init \
@@ -38,15 +38,15 @@  do_install() {
 	# Same here, the Makefile does some really stupid things,
 	# but since we only want two files why not override
 	# do_install from autotools and doing it ourselfs?
-	install -d "${D}/usr/sbin"
-	install -d "${D}/etc/init.d"
-	install -d "${D}/etc/xinetd.d"
-	install -d "${D}/etc/default"
-	install -m 644 "${WORKDIR}/xinetd.conf" "${D}/etc"
-	install -m 755 "${WORKDIR}/xinetd.init" "${D}/etc/init.d/xinetd"
-	install -m 644 "${WORKDIR}/xinetd.default" "${D}/etc/default/xinetd"
-	install -m 755 "${S}/xinetd/xinetd" "${D}/usr/sbin"
-	install -m 755 "${S}/xinetd/itox" "${D}/usr/sbin"
+	install -d "${D}${sbindir}"
+	install -d "${D}${sysconfdir}/init.d"
+	install -d "${D}${sysconfdir}/xinetd.d"
+	install -d "${D}${sysconfdir}/default"
+	install -m 644 "${WORKDIR}/xinetd.conf" "${D}${sysconfdir}"
+	install -m 755 "${WORKDIR}/xinetd.init" "${D}${sysconfdir}/init.d/xinetd"
+	install -m 644 "${WORKDIR}/xinetd.default" "${D}${sysconfdir}/default/xinetd"
+	install -m 755 "${S}/xinetd/xinetd" "${D}${sbindir}"
+	install -m 755 "${S}/xinetd/itox" "${D}${sbindir}"
 }
 
 CONFFILES_${PN} = "${sysconfdir}/xinetd.conf"