Patchwork [v2] networkmanager_git: remove `DEFAULT_PREFERENCE = "-1"`

login
register
mail settings
Submitter Paul Menzel
Date May 8, 2011, 1:29 p.m.
Message ID <1304861367.4124.63.camel@mattotaupa>
Download mbox | patch
Permalink /patch/3387/
State New, archived
Headers show

Comments

Paul Menzel - May 8, 2011, 1:29 p.m.
Date: Sat, 7 May 2011 16:40:28 +0200

Use `networkmanager_git` and `network-manager-applet_git` by default.

Build tested using `minimal` for `MACHINE = "beagleboard"`. Using
`minimal-uclibc` task compile fails because `execinfo.h` is not
available [1].

[1] http://mail.gnome.org/archives/networkmanager-list/2011-May/msg00069.html

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
---
?ngström and SHR maintainers, please tell me, if you want me to remove
the distribution specific overrides too.

Am Sonntag, den 08.05.2011, 15:07 +0200 schrieb Koen Kooi:

> On 08-05-11 12:41, Paul Menzel wrote:
> > Date: Sat, 7 May 2011 16:40:28 +0200
> > 
> > 1. Use `networkmanager_git` by default.
> 
> IF you do that you need to double check that matching vpn and applet
> versions are built

Thank you for pointing that out. Looking through it nm-openvpn does not
have any `DEFAULT_PREFERENCE` set.
---
 .../networkmanager/network-manager-applet_git.bb   |    1 -
 recipes/networkmanager/networkmanager_git.bb       |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)
Martin Jansa - May 8, 2011, 4:21 p.m.
On Sun, May 08, 2011 at 03:29:27PM +0200, Paul Menzel wrote:
> Date: Sat, 7 May 2011 16:40:28 +0200
> 
> Use `networkmanager_git` and `network-manager-applet_git` by default.
> 
> Build tested using `minimal` for `MACHINE = "beagleboard"`. Using
> `minimal-uclibc` task compile fails because `execinfo.h` is not
> available [1].
> 
> [1] http://mail.gnome.org/archives/networkmanager-list/2011-May/msg00069.html
> 
> Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
> ---
> ?ngström and SHR maintainers, please tell me, if you want me to remove
> the distribution specific overrides too.

feel free to remove shr override..

> 
> Am Sonntag, den 08.05.2011, 15:07 +0200 schrieb Koen Kooi:
> 
> > On 08-05-11 12:41, Paul Menzel wrote:
> > > Date: Sat, 7 May 2011 16:40:28 +0200
> > > 
> > > 1. Use `networkmanager_git` by default.
> > 
> > IF you do that you need to double check that matching vpn and applet
> > versions are built
> 
> Thank you for pointing that out. Looking through it nm-openvpn does not
> have any `DEFAULT_PREFERENCE` set.
> ---
>  .../networkmanager/network-manager-applet_git.bb   |    1 -
>  recipes/networkmanager/networkmanager_git.bb       |    1 -
>  2 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes/networkmanager/network-manager-applet_git.bb b/recipes/networkmanager/network-manager-applet_git.bb
> index 8493f6d..2f644d7 100644
> --- a/recipes/networkmanager/network-manager-applet_git.bb
> +++ b/recipes/networkmanager/network-manager-applet_git.bb
> @@ -3,7 +3,6 @@ LICENSE = "GPL"
>  DEPENDS = "libnotify networkmanager dbus-glib libglade gconf gnome-keyring"
>  RDEPENDS_${PN} = "networkmanager"
>  
> -DEFAULT_PREFERENCE = "-1"
>  DEFAULT_PREFERENCE_angstrom = "1"
>  
>  SRCREV = "0.8.3.999"
> diff --git a/recipes/networkmanager/networkmanager_git.bb b/recipes/networkmanager/networkmanager_git.bb
> index 8187787..cb79e78 100644
> --- a/recipes/networkmanager/networkmanager_git.bb
> +++ b/recipes/networkmanager/networkmanager_git.bb
> @@ -1,6 +1,5 @@
>  require networkmanager-0.7.inc
>  
> -DEFAULT_PREFERENCE = "-1"
>  DEFAULT_PREFERENCE_angstrom = "1"
>  DEFAULT_PREFERENCE_shr = "1"
>  
> -- 
> 1.7.4.4

Patch

diff --git a/recipes/networkmanager/network-manager-applet_git.bb b/recipes/networkmanager/network-manager-applet_git.bb
index 8493f6d..2f644d7 100644
--- a/recipes/networkmanager/network-manager-applet_git.bb
+++ b/recipes/networkmanager/network-manager-applet_git.bb
@@ -3,7 +3,6 @@  LICENSE = "GPL"
 DEPENDS = "libnotify networkmanager dbus-glib libglade gconf gnome-keyring"
 RDEPENDS_${PN} = "networkmanager"
 
-DEFAULT_PREFERENCE = "-1"
 DEFAULT_PREFERENCE_angstrom = "1"
 
 SRCREV = "0.8.3.999"
diff --git a/recipes/networkmanager/networkmanager_git.bb b/recipes/networkmanager/networkmanager_git.bb
index 8187787..cb79e78 100644
--- a/recipes/networkmanager/networkmanager_git.bb
+++ b/recipes/networkmanager/networkmanager_git.bb
@@ -1,6 +1,5 @@ 
 require networkmanager-0.7.inc
 
-DEFAULT_PREFERENCE = "-1"
 DEFAULT_PREFERENCE_angstrom = "1"
 DEFAULT_PREFERENCE_shr = "1"