Patchwork [1/1] gdk-pixbuf: fix parallel install issue

From: Wenzong Fan <wenzong.fan@windriver.com>

This patch fixes parallel install issue that lib libpixbufloader-png.la
depends on libgdk_pixbuf-2.0.la which will be regenerated during insta-
llation, if libgdk_pixbuf-2.0.la is regenerating and at the same time
libpixbufloader-png.la links it, the error will happen.

Error message is:
* usr/bin/ld: cannot find -lgdk_pixbuf-2.0
* collect2: ld returned 1 exit status

Make an explicit dependency to the libs install targets would fix this
issue.

[YOCTO #2883]

Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
 .../extending-libinstall-dependencies.patch        |   42 ++++++++++++++++++++
 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb |    3 +-
 2 files changed, 44 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf-2.24.1/extending-libinstall-dependencies.patch

On Fri, 2012-08-03 at 11:30 +0800, wenzong.fan@windriver.com wrote:

> Make an explicit dependency to the libs install targets would fix this
> issue.

I don't think Yocto should be running the 'make install' target with
parallelism enabled; it's just going to be a source of major pain for
small gain.  Historically Automake's install targets have had a lot of
paralleism issues AIUI, even discarding modules which have custom
install hooks.

On 08/06/2012 06:32 AM, Colin Walters wrote:
> On Fri, 2012-08-03 at 11:30 +0800, wenzong.fan@windriver.com wrote:
>
>> Make an explicit dependency to the libs install targets would fix this
>> issue.
>
> I don't think Yocto should be running the 'make install' target with
> parallelism enabled; it's just going to be a source of major pain for
> small gain.  Historically Automake's install targets have had a lot of
> paralleism issues AIUI, even discarding modules which have custom
> install hooks.
>
>
Hi Richard,

What's your opinions?

Disable/Enable paralleism for 'make install', this more like a policy
issue rather than tech.

Thanks
Wenzong

>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

On Sun, 2012-08-05 at 18:32 -0400, Colin Walters wrote:
> On Fri, 2012-08-03 at 11:30 +0800, wenzong.fan@windriver.com wrote:
> 
> > Make an explicit dependency to the libs install targets would fix this
> > issue.
> 
> I don't think Yocto should be running the 'make install' target with
> parallelism enabled; it's just going to be a source of major pain for
> small gain.  Historically Automake's install targets have had a lot of
> paralleism issues AIUI, even discarding modules which have custom
> install hooks.

We did used to steer clear of this but more recently tested it out and
with a few exceptions (which we disabled with PARALLEL_MAKEINST=""),
parallel make install seems to work fine and did give a small but
measurable speed-up (I'd have to look at the archives to remember what).

It helps that we use the latest automake everywhere and regenerate all
the makefiles ourselves.

So whilst I agree with this from a historical perspective, times so seem
to be changing and improving. If there are issues I do want to know
about and deal with them though.

Cheers,

Richard

Op 6 aug. 2012, om 00:32 heeft Colin Walters <walters@verbum.org> het volgende geschreven:

> On Fri, 2012-08-03 at 11:30 +0800, wenzong.fan@windriver.com wrote:
> 
>> Make an explicit dependency to the libs install targets would fix this
>> issue.
> 
> I don't think Yocto should be running the 'make install' target with
> parallelism enabled

You mean oe-core, right?