Patchwork latest updates make kernel menuconfig unusable

login
register
mail settings
Submitter Liang Li
Date Aug. 2, 2012, 2:25 p.m.
Message ID <20120802142510.GA6025@localhost>
Download mbox | patch
Permalink /patch/33675/
State New
Headers show

Comments

Liang Li - Aug. 2, 2012, 2:25 p.m.
On 2012-08-02 19:07, Andreas M?ller <schnitzeltony@googlemail.com> wrote:
> On Thu, Jun 21, 2012 at 2:29 AM, Khem Raj <raj.khem@gmail.com> wrote:
> > On Wed, Jun 20, 2012 at 11:55 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> >> On Wed, Jun 20, 2012 at 04:20:03PM +0200, Andreas M?ler wrote:
> >>> Hi,
> >>>
> >>> since
> >>>
> >>> commit fe417e8a4d625c6933de72163d2fee52ac47f571
> >>> Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> >>> Date:   Thu May 31 13:22:34 2012 +0000
> >>>
> >>>     cmd1.bbclass: Ensure ncurses is built and used for menuconfig tasks
> >>>
> >>>     Currently, the task just exits if something goes wrong. This adds the
> >>>     ncurses-native dependency. It also adds a small delay before closing the
> >>>     window so any messages displayed there can be seen.
> >>>
> >>>     Trying to get the kernel build system to correctly find and link with
> >>>     our copy of ncurses is some kind of nightmare. I ended up having to add
> >>>     it to HOST_LOADLIBES globally for this task which is rather nasty but I
> >>>     couldn't find any other way.
> >>>
> >>>     [YOCTO #2513]
> >>>
> >>>     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> >>>
> >>> my menuconfig is unusable (see screenshot attached). I reverted it and
> >>> can work as before.
> >>>
> >>> I am working on Fedora 15 and set in my local.conf
> >>>
> >>> TERMCMD = "${GNOME_TERMCMD}"
> >>> TERMCMDRUN = "${GNOME_TERMCMDRUN}"
> >>
> >> I can confirm the same look&feel with
> >> TERMCMD = "${SCREEN_TERMCMD}"
> >> TERMCMDRUN = "${SCREEN_TERMCMDRUN}"
> >>
> >
> > seems like a locale issue.
> >
> FYI
> 
> Still have this behaviour and can work around it by commenting out
> 
> OE_TERMINAL_EXPORTS += "HOST_EXTRACFLAGS HOSTLDFLAGS HOST_LOADLIBES"
> 
> in cml1.bbclass.
> 

I have same issue on fedora 17, make it works for my host with
below temporary tweak:

 do_menuconfig[depends] += "ncurses-native:do_populate_sysroot"

---

FYI.

Regards,
		Liang Li

> Andreas
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Paul Eggleton - Sept. 6, 2012, 1:30 p.m.
On Thursday 02 August 2012 22:25:18 Liang Li wrote:
> On 2012-08-02 19:07, Andreas M?ller <schnitzeltony@googlemail.com> wrote:
> > On Thu, Jun 21, 2012 at 2:29 AM, Khem Raj <raj.khem@gmail.com> wrote:
> > > On Wed, Jun 20, 2012 at 11:55 AM, Martin Jansa <martin.jansa@gmail.com> 
wrote:
> > >> On Wed, Jun 20, 2012 at 04:20:03PM +0200, Andreas M?ler wrote:
> > >>> Hi,
> > >>> 
> > >>> since
> > >>> 
> > >>> commit fe417e8a4d625c6933de72163d2fee52ac47f571
> > >>> Author: Richard Purdie <richard.purdie@linuxfoundation.org>
> > >>> Date:   Thu May 31 13:22:34 2012 +0000
> > >>> 
> > >>>     cmd1.bbclass: Ensure ncurses is built and used for menuconfig
> > >>>     tasks
> > >>>     
> > >>>     Currently, the task just exits if something goes wrong. This adds
> > >>>     the
> > >>>     ncurses-native dependency. It also adds a small delay before
> > >>>     closing the
> > >>>     window so any messages displayed there can be seen.
> > >>>     
> > >>>     Trying to get the kernel build system to correctly find and link
> > >>>     with
> > >>>     our copy of ncurses is some kind of nightmare. I ended up having
> > >>>     to add
> > >>>     it to HOST_LOADLIBES globally for this task which is rather nasty
> > >>>     but I
> > >>>     couldn't find any other way.
> > >>>     
> > >>>     [YOCTO #2513]
> > >>>     
> > >>>     Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > >>> 
> > >>> my menuconfig is unusable (see screenshot attached). I reverted it and
> > >>> can work as before.
> > >>> 
> > >>> I am working on Fedora 15 and set in my local.conf
> > >>> 
> > >>> TERMCMD = "${GNOME_TERMCMD}"
> > >>> TERMCMDRUN = "${GNOME_TERMCMDRUN}"
> > >> 
> > >> I can confirm the same look&feel with
> > >> TERMCMD = "${SCREEN_TERMCMD}"
> > >> TERMCMDRUN = "${SCREEN_TERMCMDRUN}"
> > > 
> > > seems like a locale issue.
> > 
> > FYI
> > 
> > Still have this behaviour and can work around it by commenting out
> > 
> > OE_TERMINAL_EXPORTS += "HOST_EXTRACFLAGS HOSTLDFLAGS HOST_LOADLIBES"
> > 
> > in cml1.bbclass.
> 
> I have same issue on fedora 17, make it works for my host with
> below temporary tweak:
> 
> diff --git meta/classes/cml1.bbclass meta/classes/cml1.bbclass
> index bd25311..948cfad 100644
> --- meta/classes/cml1.bbclass
> +++ meta/classes/cml1.bbclass
> @@ -15,6 +15,7 @@ HOSTLDFLAGS = "${BUILD_LDFLAGS}"
>  HOST_LOADLIBES = "-lncurses"
> 
>  python do_menuconfig() {
> +        d.setVar("HOSTLDFLAGS", "")
>          oe_terminal("${SHELL} -c \"make menuconfig; echo 'Pausing for
>          5 seconds'; sleep 5\"", '${PN} Configuration', d)
>  }
>  do_menuconfig[depends] += "ncurses-native:do_populate_sysroot"
> 
> ---
> 
> FYI.
> 
> Regards,
> 		Liang Li
> 

Is there a proper fix for this issue if clearing HOSTLDFLAGS isn't the right 
one? I'm not quite sure how to reproduce the problem here.

Cheers,
Paul

Patch

diff --git meta/classes/cml1.bbclass meta/classes/cml1.bbclass
index bd25311..948cfad 100644
--- meta/classes/cml1.bbclass
+++ meta/classes/cml1.bbclass
@@ -15,6 +15,7 @@  HOSTLDFLAGS = "${BUILD_LDFLAGS}"
 HOST_LOADLIBES = "-lncurses"
 
 python do_menuconfig() {
+        d.setVar("HOSTLDFLAGS", "")
         oe_terminal("${SHELL} -c \"make menuconfig; echo 'Pausing for
         5 seconds'; sleep 5\"", '${PN} Configuration', d)
 }