Patchwork [1/1] send-pull-request: Make -a really imply -c

login
register
mail settings
Submitter Darren Hart
Date Aug. 1, 2012, 7:18 p.m.
Message ID <81cebc4971664125194e077f73c61bcb42505c9a.1343848387.git.dvhart@linux.intel.com>
Download mbox | patch
Permalink /patch/33599/
State Accepted
Commit 319d2cc8e60450106b665ee4172e2e6dc90e14b5
Headers show

Comments

Darren Hart - Aug. 1, 2012, 7:18 p.m.
The switch statement does not fall through as the comment suggests.
This results in -a not implying -c as was intended.

Add the two lines from -c to -a to achieve the intended behavior.

Signed-off-by: Darren Hart <dvhart@linux.intel.com>
---
 scripts/send-pull-request |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Patch

diff --git a/scripts/send-pull-request b/scripts/send-pull-request
index 09f4245..18a53c4 100755
--- a/scripts/send-pull-request
+++ b/scripts/send-pull-request
@@ -71,8 +71,9 @@  harvest_recipients()
 while getopts "achp:t:" OPT; do
 	case $OPT in
 	a)
+		AUTO=1
+		GITSOBCC="--signed-off-by-cc"
 		AUTO_CL=1
-		# Fall through to include -c
 		;;
 	c)
 		AUTO=1