Patchwork socat: missing several dependencies

login
register
mail settings
Submitter Amy Fong
Date July 31, 2012, 6:56 p.m.
Message ID <20120731185629.GA13766@windriver.com>
Download mbox | patch
Permalink /patch/33443/
State New
Headers show

Comments

Amy Fong - July 31, 2012, 6:56 p.m.
socat: missing several dependencies
    
socat depends on ncurses, readline, and tcp-wrappers
    
Signed-off-by: Amy Fong <amy.fong@windriver.com>
---
 socat_1.7.2.0.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Saul Wold - Aug. 13, 2012, 6:54 a.m.
On 07/31/2012 09:56 PM, Amy Fong wrote:
> socat: missing several dependencies
>
> socat depends on ncurses, readline, and tcp-wrappers
>
> Signed-off-by: Amy Fong <amy.fong@windriver.com>
> ---
>   socat_1.7.2.0.bb |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/socat/socat_1.7.2.0.bb b/meta/recipes-connectivity/socat/socat_1.7.2.0.bb
> index 1273dcf..0faf016 100644
> --- a/meta/recipes-connectivity/socat/socat_1.7.2.0.bb
> +++ b/meta/recipes-connectivity/socat/socat_1.7.2.0.bb
> @@ -4,7 +4,7 @@ HOMEPAGE = "http://www.dest-unreach.org/socat/"
>
>   SECTION = "console/network"
>
> -DEPENDS = "openssl"
> +DEPENDS = "openssl readline ncurses tcp-wrappers"
>
I have been thinking on this one and trying to understand why we should 
need to have readline and ncurses for socat, is there any configure 
flags to disable these instead of depending on them?

It also seems that tcp-wrappers' libwrap is also optional and can be 
disabled via the configure options.  I can see value of libwrap here, 
but we have not explicitly enabled it in the past, so my initial thought 
here is to disable it instead of adding the DEPENDS.

Sau!


>   LICENSE = "GPL-2.0+-with-OpenSSL-exception"
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>

Patch

diff --git a/meta/recipes-connectivity/socat/socat_1.7.2.0.bb b/meta/recipes-connectivity/socat/socat_1.7.2.0.bb
index 1273dcf..0faf016 100644
--- a/meta/recipes-connectivity/socat/socat_1.7.2.0.bb
+++ b/meta/recipes-connectivity/socat/socat_1.7.2.0.bb
@@ -4,7 +4,7 @@  HOMEPAGE = "http://www.dest-unreach.org/socat/"
 
 SECTION = "console/network"
 
-DEPENDS = "openssl"
+DEPENDS = "openssl readline ncurses tcp-wrappers"
 
 LICENSE = "GPL-2.0+-with-OpenSSL-exception"