Patchwork [1/7] combo-layer: remove &> bashism

login
mail settings
Submitter Paul Eggleton
Date July 31, 2012, 12:06 a.m.
Message ID <1d6c82026f0307cf3516213aad39fc9d9790452f.1343693147.git.paul.eggleton@linux.intel.com>
Download mbox | patch
Permalink /patch/33329/
State Accepted
Commit 5582cc58e42402c4680877e669d8c1ce058e7098
Headers show

Comments

Paul Eggleton - July 31, 2012, 12:06 a.m.
&> does not work with dash - use > xxxx 2>&1 instead.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 scripts/combo-layer |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/scripts/combo-layer b/scripts/combo-layer
index 73d61cc..b1a9dca 100755
--- a/scripts/combo-layer
+++ b/scripts/combo-layer
@@ -75,7 +75,7 @@  class Configuration(object):
             sys.exit(1)
 
         # filterdiff is required by action_splitpatch, so check its availability
-        if subprocess.call("which filterdiff &>/dev/null", shell=True) != 0:
+        if subprocess.call("which filterdiff > /dev/null 2>&1", shell=True) != 0:
             logger.error("ERROR: patchutils package is missing, please install it (e.g. # apt-get install patchutils)")
             sys.exit(1)