| Submitter | Ross Burton |
|---|---|
| Date | July 30, 2012, 12:18 p.m. |
| Message ID | <1343650687-2307-2-git-send-email-ross.burton@intel.com> |
| Download | mbox | patch |
| Permalink | /patch/33291/ |
| State | New |
| Headers | show |
Comments
On Monday 30 July 2012 13:18:07 Ross Burton wrote: > Signed-off-by: Ross Burton <ross.burton@intel.com> > --- > meta/lib/oe/buildhistory_analysis.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/lib/oe/buildhistory_analysis.py > b/meta/lib/oe/buildhistory_analysis.py index d0e0808..0a50432 100644 > --- a/meta/lib/oe/buildhistory_analysis.py > +++ b/meta/lib/oe/buildhistory_analysis.py > @@ -23,7 +23,7 @@ numeric_fields = ['PKGSIZE', 'IMAGESIZE'] > # Fields to monitor > monitor_fields = ['RDEPENDS', 'RRECOMMENDS', 'PACKAGES', 'FILELIST', > 'PKGSIZE', 'IMAGESIZE'] # Percentage change to alert for numeric fields > -monitor_numeric_threshold = 20 > +monitor_numeric_threshold = 10 > # Image files to monitor (note that image-info.txt is handled separately) > img_monitor_files = ['installed-package-names.txt', 'files-in-image.txt'] > # Related context fields for reporting (note: PE, PV & PR are always > reported for monitored package fields) I don't think I picked 20% completely out of thin air but I wasn't especially scientific about it either, so: Acked-by: Paul Eggleton <paul.eggleton@linux.intel.com> Cheers, Paul
On 30 July 2012 13:22, Paul Eggleton <paul.eggleton@linux.intel.com> wrote: > I don't think I picked 20% completely out of thin air but I wasn't especially > scientific about it either, so: FWIW, my situation was that I was messing around with the Mesa packaging and it wasn't reporting a package size reduction due to package re-arrangement. 20% is fairly large for a "not significant" change IMHO, I'd be interested to see what sort of "false positives" it threw up with 5%. Ross
Patch
diff --git a/meta/lib/oe/buildhistory_analysis.py b/meta/lib/oe/buildhistory_analysis.py index d0e0808..0a50432 100644 --- a/meta/lib/oe/buildhistory_analysis.py +++ b/meta/lib/oe/buildhistory_analysis.py @@ -23,7 +23,7 @@ numeric_fields = ['PKGSIZE', 'IMAGESIZE'] # Fields to monitor monitor_fields = ['RDEPENDS', 'RRECOMMENDS', 'PACKAGES', 'FILELIST', 'PKGSIZE', 'IMAGESIZE'] # Percentage change to alert for numeric fields -monitor_numeric_threshold = 20 +monitor_numeric_threshold = 10 # Image files to monitor (note that image-info.txt is handled separately) img_monitor_files = ['installed-package-names.txt', 'files-in-image.txt'] # Related context fields for reporting (note: PE, PV & PR are always reported for monitored package fields)
Signed-off-by: Ross Burton <ross.burton@intel.com> --- meta/lib/oe/buildhistory_analysis.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)