Patchwork slang: change char type to signed char in macros

login
register
mail settings
Submitter rongqing.li@windriver.com
Date July 30, 2012, 9:08 a.m.
Message ID <1343639326-29842-1-git-send-email-rongqing.li@windriver.com>
Download mbox | patch
Permalink /patch/33277/
State New
Headers show

Comments

rongqing.li@windriver.com - July 30, 2012, 9:08 a.m.
From: Roy.Li <rongqing.li@windriver.com>

[YOCTO 2726]

The patch of converting char type to signed char is only applied to arm,
in fact it should be applied to powerpc too since powerpc has the same
assumption for char type. To x86 and mips, this patch has not impact.

Signed-off-by: Roy.Li <rongqing.li@windriver.com>
---
 meta/recipes-extended/slang/slang_2.2.4.bb |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Chris Larson - July 30, 2012, 4:55 p.m.
On Mon, Jul 30, 2012 at 2:08 AM,  <rongqing.li@windriver.com> wrote:
> -SRC_URI_append_arm = " file://change-char-type-to-signed-char-in-macros.patch"
> +SRC_URI_append = " file://change-char-type-to-signed-char-in-macros.patch"

Just move this into the main SRC_URI. There's no point retaining the
separate assignment.
rongqing.li@windriver.com - July 31, 2012, 3:27 a.m.
On 2012?07?31? 00:55, Chris Larson wrote:
> On Mon, Jul 30, 2012 at 2:08 AM,  <rongqing.li@windriver.com> wrote:
>> -SRC_URI_append_arm = " file://change-char-type-to-signed-char-in-macros.patch"
>> +SRC_URI_append = " file://change-char-type-to-signed-char-in-macros.patch"
>
> Just move this into the main SRC_URI. There's no point retaining the
> separate assignment.
>

Ok, thanks

-Roy

Patch

diff --git a/meta/recipes-extended/slang/slang_2.2.4.bb b/meta/recipes-extended/slang/slang_2.2.4.bb
index 7082611..e7d804c 100644
--- a/meta/recipes-extended/slang/slang_2.2.4.bb
+++ b/meta/recipes-extended/slang/slang_2.2.4.bb
@@ -10,7 +10,7 @@  to recode S-Lang procedures in C if you need to."
 HOMEPAGE = "http://www.jedsoft.org/slang/"
 SECTION = "libs"
 DEPENDS = "pcre"
-PR = "r10"
+PR = "r11"
 
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=a52a18a472d4f7e45479b06563717c02"
@@ -20,7 +20,7 @@  SRC_URI = "ftp://space.mit.edu/pub/davis/slang/v2.2/slang-${PV}.tar.bz2 \
            file://rpathfix.patch \
            file://fix-check-pcre.patch \
           "
-SRC_URI_append_arm = " file://change-char-type-to-signed-char-in-macros.patch"
+SRC_URI_append = " file://change-char-type-to-signed-char-in-macros.patch"
 
 inherit autotools