Patchwork owl-video_git.bb: fix compilation on Fedora 13 machine

login
register
mail settings
Submitter Matthew McClintock
Date July 26, 2012, 8:37 p.m.
Message ID <1343335023-28938-1-git-send-email-msm@freescale.com>
Download mbox | patch
Permalink /patch/33165/
State New
Headers show

Comments

Matthew McClintock - July 26, 2012, 8:37 p.m.
This adds libXrandr to the link step and fixes this issue:

| /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRGetOutputInfo'
| /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRGetScreenResourcesCurrent'
| /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRFreeOutputInfo'
| /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRFreeScreenResources'
| /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRGetOutputPrimary'
| /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRFreeCrtcInfo'
| /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRGetCrtcInfo'
| collect2: ld returned 1 exit status

Signed-off-by: Matthew McClintock <msm@freescale.com>
---
 .../owl-video/0001-add-dependency-for-xrandr.patch |   30 ++++++++++++++++++++
 .../recipes-sato/owl-video-widget/owl-video_git.bb |    5 ++--
 2 files changed, 33 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-sato/owl-video-widget/owl-video/0001-add-dependency-for-xrandr.patch
McClintock Matthew-B29882 - Aug. 8, 2012, 4:07 p.m.
Any comments on this?

-M

On Thu, Jul 26, 2012 at 3:37 PM, Matthew McClintock <msm@freescale.com> wrote:
> This adds libXrandr to the link step and fixes this issue:
>
> | /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRGetOutputInfo'
> | /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRGetScreenResourcesCurrent'
> | /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRFreeOutputInfo'
> | /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRFreeScreenResources'
> | /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRGetOutputPrimary'
> | /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRFreeCrtcInfo'
> | /opt/yocto/upstream/label/master/machine/atom-pc/poky/edison/tmp/sysroots/atom-pc/usr/lib/libgdk-x11-2.0.so: undefined reference to `XRRGetCrtcInfo'
> | collect2: ld returned 1 exit status
>
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>  .../owl-video/0001-add-dependency-for-xrandr.patch |   30 ++++++++++++++++++++
>  .../recipes-sato/owl-video-widget/owl-video_git.bb |    5 ++--
>  2 files changed, 33 insertions(+), 2 deletions(-)
>  create mode 100644 meta/recipes-sato/owl-video-widget/owl-video/0001-add-dependency-for-xrandr.patch
>
> diff --git a/meta/recipes-sato/owl-video-widget/owl-video/0001-add-dependency-for-xrandr.patch b/meta/recipes-sato/owl-video-widget/owl-video/0001-add-dependency-for-xrandr.patch
> new file mode 100644
> index 0000000..8c14578
> --- /dev/null
> +++ b/meta/recipes-sato/owl-video-widget/owl-video/0001-add-dependency-for-xrandr.patch
> @@ -0,0 +1,30 @@
> +Upstream-Status: Pending
> +
> +This patch should probably go upstream
> +
> +From 18bdd57b36489439dc5c18b20abd9d59c6778662 Mon Sep 17 00:00:00 2001
> +From: Matthew McClintock <msm@freescale.com>
> +Date: Wed, 25 Jul 2012 15:05:40 -0500
> +Subject: [PATCH] add dependency for xrandr
> +
> +Signed-off-by: Matthew McClintock <msm@freescale.com>
> +---
> + src/Makefile.am |    2 +-
> + 1 files changed, 1 insertions(+), 1 deletions(-)
> +
> +diff --git a/src/Makefile.am b/src/Makefile.am
> +index 60e845b..00e4b11 100644
> +--- a/src/Makefile.am
> ++++ b/src/Makefile.am
> +@@ -12,7 +12,7 @@ video_SOURCES = video.c      \
> +       owl-overlay-bin.c       \
> +       owl-overlay-bin.h
> +
> +-video_LDADD = $(VIDEO_LIBS)
> ++video_LDADD = $(VIDEO_LIBS) -lXrandr
> +
> + dist_pkgdata_DATA = gtk-fullscreen.png
> +
> +--
> +1.7.5.4
> +
> diff --git a/meta/recipes-sato/owl-video-widget/owl-video_git.bb b/meta/recipes-sato/owl-video-widget/owl-video_git.bb
> index bc63273..321b71b 100644
> --- a/meta/recipes-sato/owl-video-widget/owl-video_git.bb
> +++ b/meta/recipes-sato/owl-video-widget/owl-video_git.bb
> @@ -10,7 +10,7 @@ DEPENDS = "libowl-av"
>
>  SRCREV = "f133472318970796fae1ea3e98ac062156768baf"
>  PV = "0.1+git${SRCPV}"
> -PR = "r1"
> +PR = "r2"
>
>  S = "${WORKDIR}/git"
>
> @@ -23,7 +23,8 @@ SRC_URI = "git://git.yoctoproject.org/${BPN};protocol=git \
>             file://stock_volume-med.png \
>             file://stock_volume-max.png \
>             file://owl-video-widget.desktop \
> -          file://make-382.patch"
> +          file://make-382.patch \
> +          file://0001-add-dependency-for-xrandr.patch"
>
>  inherit autotools pkgconfig
>
> --
> 1.7.10
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Ross Burton - Aug. 10, 2012, 12:54 p.m.
On 8 August 2012 17:07, McClintock Matthew-B29882 <B29882@freescale.com> wrote:
> Any comments on this?

owl-video isn't pulling in Xrandr directly, so something is wrong with
the linker flags produced by GTK+.  I wonder if -Wl,--as-needed is
breaking this...  Can you replicate and provide the full build log?

Ross
McClintock Matthew-B29882 - Aug. 13, 2012, 6:06 p.m.
On Fri, Aug 10, 2012 at 7:54 AM, Burton, Ross <ross.burton@intel.com> wrote:
> On 8 August 2012 17:07, McClintock Matthew-B29882 <B29882@freescale.com> wrote:
>> Any comments on this?
>
> owl-video isn't pulling in Xrandr directly, so something is wrong with
> the linker flags produced by GTK+.  I wonder if -Wl,--as-needed is
> breaking this...  Can you replicate and provide the full build log?

Err, I went back and now I can't even reproduce this issue... I guess
we can ignore it for the time being.

-M

> Ross
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Ross Burton - Aug. 13, 2012, 6:56 p.m.
On 13 August 2012 19:06, McClintock Matthew-B29882 <B29882@freescale.com> wrote:
> On Fri, Aug 10, 2012 at 7:54 AM, Burton, Ross <ross.burton@intel.com> wrote:
>> On 8 August 2012 17:07, McClintock Matthew-B29882 <B29882@freescale.com> wrote:
>>> Any comments on this?
>>
>> owl-video isn't pulling in Xrandr directly, so something is wrong with
>> the linker flags produced by GTK+.  I wonder if -Wl,--as-needed is
>> breaking this...  Can you replicate and provide the full build log?
>
> Err, I went back and now I can't even reproduce this issue... I guess
> we can ignore it for the time being.

Oh good. :)  Thanks for attempting to replicate.

Ross

Patch

diff --git a/meta/recipes-sato/owl-video-widget/owl-video/0001-add-dependency-for-xrandr.patch b/meta/recipes-sato/owl-video-widget/owl-video/0001-add-dependency-for-xrandr.patch
new file mode 100644
index 0000000..8c14578
--- /dev/null
+++ b/meta/recipes-sato/owl-video-widget/owl-video/0001-add-dependency-for-xrandr.patch
@@ -0,0 +1,30 @@ 
+Upstream-Status: Pending
+
+This patch should probably go upstream
+
+From 18bdd57b36489439dc5c18b20abd9d59c6778662 Mon Sep 17 00:00:00 2001
+From: Matthew McClintock <msm@freescale.com>
+Date: Wed, 25 Jul 2012 15:05:40 -0500
+Subject: [PATCH] add dependency for xrandr
+
+Signed-off-by: Matthew McClintock <msm@freescale.com>
+---
+ src/Makefile.am |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/src/Makefile.am b/src/Makefile.am
+index 60e845b..00e4b11 100644
+--- a/src/Makefile.am
++++ b/src/Makefile.am
+@@ -12,7 +12,7 @@ video_SOURCES = video.c	\
+ 	owl-overlay-bin.c	\
+ 	owl-overlay-bin.h
+ 
+-video_LDADD = $(VIDEO_LIBS)
++video_LDADD = $(VIDEO_LIBS) -lXrandr
+ 
+ dist_pkgdata_DATA = gtk-fullscreen.png
+ 
+-- 
+1.7.5.4
+
diff --git a/meta/recipes-sato/owl-video-widget/owl-video_git.bb b/meta/recipes-sato/owl-video-widget/owl-video_git.bb
index bc63273..321b71b 100644
--- a/meta/recipes-sato/owl-video-widget/owl-video_git.bb
+++ b/meta/recipes-sato/owl-video-widget/owl-video_git.bb
@@ -10,7 +10,7 @@  DEPENDS = "libowl-av"
 
 SRCREV = "f133472318970796fae1ea3e98ac062156768baf"
 PV = "0.1+git${SRCPV}"
-PR = "r1"
+PR = "r2"
 
 S = "${WORKDIR}/git"
 
@@ -23,7 +23,8 @@  SRC_URI = "git://git.yoctoproject.org/${BPN};protocol=git \
            file://stock_volume-med.png \
            file://stock_volume-max.png \
            file://owl-video-widget.desktop \
-	   file://make-382.patch"
+	   file://make-382.patch \
+	   file://0001-add-dependency-for-xrandr.patch"
 
 inherit autotools pkgconfig