| Submitter | Bruce Ashfield |
|---|---|
| Date | July 26, 2012, 6:04 p.m. |
| Message ID | <15363b249e50ef40bad737d3a6c2a1c28d3a2dc9.1343325569.git.bruce.ashfield@windriver.com> |
| Download | mbox | patch |
| Permalink | /patch/33153/ |
| State | Accepted |
| Commit | a134efa7743edc3b7ca8abb651add6d2045c3b44 |
| Headers | show |
Comments
On 07/26/2012 11:04 AM, Bruce Ashfield wrote: > kernel.bbclass is a common class for many different kernel versions, > and as such the default module_autoload and module_conf values that > it contains are not relevant, or out of date for most builds. > > Individual kernel recipes or distros can better specify these > values to meet their needs. > > Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com> This makes sense to me. None of the below are likely to prevent boot and seem to be more along the lines of MACHINE policy. -- Darren > --- > meta/classes/kernel.bbclass | 19 ------------------- > 1 files changed, 0 insertions(+), 19 deletions(-) > > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass > index ab984e3..c647e9b 100644 > --- a/meta/classes/kernel.bbclass > +++ b/meta/classes/kernel.bbclass > @@ -293,25 +293,6 @@ if [ x"$D" = "x" ]; then > fi > } > > -# autoload defaults (alphabetically sorted) > -module_autoload_hidp = "hidp" > -module_autoload_ipv6 = "ipv6" > -module_autoload_ipsec = "ipsec" > -module_autoload_ircomm-tty = "ircomm-tty" > -module_autoload_rfcomm = "rfcomm" > -module_autoload_sa1100-rtc = "sa1100-rtc" > -# sa1100-rtc was renamed in 2.6.23 onwards > -module_autoload_rtc-sa1100 = "rtc-sa1100" > - > -# alias defaults (alphabetically sorted) > -module_conf_af_packet = "alias net-pf-17 af_packet" > -module_conf_bluez = "alias net-pf-31 bluez" > -module_conf_bnep = "alias bt-proto-4 bnep" > -module_conf_hci_uart = "alias tty-ldisc-15 hci_uart" > -module_conf_l2cap = "alias bt-proto-0 l2cap" > -module_conf_sco = "alias bt-proto-2 sco" > -module_conf_rfcomm = "alias bt-proto-3 rfcomm" > - > python populate_packages_prepend () { > def extract_modinfo(file): > import tempfile, re, subprocess >
On Jul 27, 2012, at 3:39 PM, Darren Hart <dvhart@linux.intel.com> wrote: >> kernel.bbclass is a common class for many different kernel versions, >> and as such the default module_autoload and module_conf values that >> it contains are not relevant, or out of date for most builds. >> >> Individual kernel recipes or distros can better specify these >> values to meet their needs. >> >> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com> > > This makes sense to me. None of the below are likely to prevent boot and > seem to be more along the lines of MACHINE policy. > This needs some soak time. For folks who are unknowingly depending on this.
On Wed, Aug 1, 2012 at 7:15 PM, Khem Raj <raj.khem@gmail.com> wrote: > > On Jul 27, 2012, at 3:39 PM, Darren Hart <dvhart@linux.intel.com> wrote: > >>> kernel.bbclass is a common class for many different kernel versions, >>> and as such the default module_autoload and module_conf values that >>> it contains are not relevant, or out of date for most builds. >>> >>> Individual kernel recipes or distros can better specify these >>> values to meet their needs. >>> >>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com> >> >> This makes sense to me. None of the below are likely to prevent boot and >> seem to be more along the lines of MACHINE policy. >> > > This needs some soak time. For folks who are unknowingly depending on this. Is there a good place to stage this to get more eyes on it ? I'm willing to help make sure no one is broken, but I'm @ 6 days and got a few comments, but nothing much .. so if we can do more, I'm all ears! Cheers, Bruce > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Wed, Aug 1, 2012 at 7:58 PM, Bruce Ashfield <bruce.ashfield@gmail.com> wrote: > On Wed, Aug 1, 2012 at 7:15 PM, Khem Raj <raj.khem@gmail.com> wrote: >> >> On Jul 27, 2012, at 3:39 PM, Darren Hart <dvhart@linux.intel.com> wrote: >> >>>> kernel.bbclass is a common class for many different kernel versions, >>>> and as such the default module_autoload and module_conf values that >>>> it contains are not relevant, or out of date for most builds. >>>> >>>> Individual kernel recipes or distros can better specify these >>>> values to meet their needs. >>>> >>>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com> >>> >>> This makes sense to me. None of the below are likely to prevent boot and >>> seem to be more along the lines of MACHINE policy. >>> >> >> This needs some soak time. For folks who are unknowingly depending on this. > > Is there a good place to stage this to get more eyes on it ? I'm willing to help > make sure no one is broken, but I'm @ 6 days and got a few comments, but > nothing much .. so if we can do more, I'm all ears! > Well I fixed my case :) > Cheers, > > Bruce > >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > > > -- > "Thou shalt not follow the NULL pointer, for chaos and madness await > thee at its end" > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Wed, Aug 1, 2012 at 11:12 PM, Khem Raj <raj.khem@gmail.com> wrote: > On Wed, Aug 1, 2012 at 7:58 PM, Bruce Ashfield <bruce.ashfield@gmail.com> wrote: >> On Wed, Aug 1, 2012 at 7:15 PM, Khem Raj <raj.khem@gmail.com> wrote: >>> >>> On Jul 27, 2012, at 3:39 PM, Darren Hart <dvhart@linux.intel.com> wrote: >>> >>>>> kernel.bbclass is a common class for many different kernel versions, >>>>> and as such the default module_autoload and module_conf values that >>>>> it contains are not relevant, or out of date for most builds. >>>>> >>>>> Individual kernel recipes or distros can better specify these >>>>> values to meet their needs. >>>>> >>>>> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com> >>>> >>>> This makes sense to me. None of the below are likely to prevent boot and >>>> seem to be more along the lines of MACHINE policy. >>>> >>> >>> This needs some soak time. For folks who are unknowingly depending on this. >> >> Is there a good place to stage this to get more eyes on it ? I'm willing to help >> make sure no one is broken, but I'm @ 6 days and got a few comments, but >> nothing much .. so if we can do more, I'm all ears! >> > > Well I fixed my case :) Ha! You should have just said that (I'm dense at times) :P So it's working as designed, let it soak! Cheers, Bruce > >> Cheers, >> >> Bruce >> >>> >>> _______________________________________________ >>> Openembedded-core mailing list >>> Openembedded-core@lists.openembedded.org >>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >> >> >> -- >> "Thou shalt not follow the NULL pointer, for chaos and madness await >> thee at its end" >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Patch
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass index ab984e3..c647e9b 100644 --- a/meta/classes/kernel.bbclass +++ b/meta/classes/kernel.bbclass @@ -293,25 +293,6 @@ if [ x"$D" = "x" ]; then fi } -# autoload defaults (alphabetically sorted) -module_autoload_hidp = "hidp" -module_autoload_ipv6 = "ipv6" -module_autoload_ipsec = "ipsec" -module_autoload_ircomm-tty = "ircomm-tty" -module_autoload_rfcomm = "rfcomm" -module_autoload_sa1100-rtc = "sa1100-rtc" -# sa1100-rtc was renamed in 2.6.23 onwards -module_autoload_rtc-sa1100 = "rtc-sa1100" - -# alias defaults (alphabetically sorted) -module_conf_af_packet = "alias net-pf-17 af_packet" -module_conf_bluez = "alias net-pf-31 bluez" -module_conf_bnep = "alias bt-proto-4 bnep" -module_conf_hci_uart = "alias tty-ldisc-15 hci_uart" -module_conf_l2cap = "alias bt-proto-0 l2cap" -module_conf_sco = "alias bt-proto-2 sco" -module_conf_rfcomm = "alias bt-proto-3 rfcomm" - python populate_packages_prepend () { def extract_modinfo(file): import tempfile, re, subprocess
kernel.bbclass is a common class for many different kernel versions, and as such the default module_autoload and module_conf values that it contains are not relevant, or out of date for most builds. Individual kernel recipes or distros can better specify these values to meet their needs. Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com> --- meta/classes/kernel.bbclass | 19 ------------------- 1 files changed, 0 insertions(+), 19 deletions(-)