From patchwork Mon Oct 30 03:47:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 33071 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FCCCC4332F for ; Mon, 30 Oct 2023 03:48:09 +0000 (UTC) Received: from codeconstruct.com.au (codeconstruct.com.au [203.29.241.158]) by mx.groups.io with SMTP id smtpd.web10.141866.1698637684539864040 for ; Sun, 29 Oct 2023 20:48:05 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="dkim: body hash did not verify" header.i=@codeconstruct.com.au header.s=2022a header.b=dbJN+BV7; spf=pass (domain: codeconstruct.com.au, ip: 203.29.241.158, mailfrom: andrew@codeconstruct.com.au) Received: from localhost.localdomain (ppp118-210-136-142.adl-adc-lon-bras33.tpg.internode.on.net [118.210.136.142]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 8E404200DB; Mon, 30 Oct 2023 11:48:02 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1698637682; bh=cxtciIbdlFseuGxGGWXseIRnrf++5KHxXPIO15fHAbM=; h=From:To:Cc:Subject:Date; b=dbJN+BV7A02wA+Dd1/imeoKwOuNdyw1qpuSClOveiEStuKoJARgtvbgVz7t7Vjh6f CO7nU+dJYARqbfBACL0y6XU5DSHMVAeJkYGAVOFzxvVWlQNWQaPgJyEiW5uMMbxCSY pyfy+2YXwZxASHAhtpiuGf2CjrNOd9CtjgYMriHhslOa7v6cnHQbTn+3uAJaCbULiQ MayYZc2T2/OWWL5Hg5MzUy7KWbe5Y89k4+s7821RUwc4mytfLxPQLg+/7yFq8/FYVa qy7jVcDDGYo95fAoEVMdBGQPC8WXxiVOmZNys19oPOTZKoOa8tfVvgOpxQCKICY8Ik caEGns5qVEsRQ== From: Andrew Jeffery To: openembedded-devel@lists.openembedded.org Cc: Andrew Jeffery Subject: [meta-networking][PATCH] mdio-tools: Add virtual/kernel dependency to avoid stale SPDX reference Date: Mon, 30 Oct 2023 14:17:53 +1030 Message-Id: <20231030034753.312182-1-andrew@codeconstruct.com.au> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 30 Oct 2023 03:48:09 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/105789 OpenBMC enables SPDX SBOM generation by default. For Meta's Bletchley platform we found that mdio-tools and its relationships with both mdio-netlink and the mdio-netlink kernel module break SPDX processing while generating the rootfs after a kernel bump. For example, the following output was generated by `bitbake obmc-phosphor-image`: ERROR: obmc-phosphor-image-1.0-r0 do_rootfs: Cannot find any SPDX file for document http://spdx.org/spdxdoc/kernel-module-mdio-netlink-6.5.4-da279e9-00089-gda279e98c07f-89187488-3164-50cb-94c5-8b76a30ea093 The error occurred after the following patch was applied (again, in the context of OpenBMC): diff --git a/meta-aspeed/recipes-kernel/linux/linux-aspeed_git.bb b/meta-aspeed/recipes-kernel/linux/linux-aspeed_git.bb index e6f98297c540..b852e993f0f6 100644 --- a/meta-aspeed/recipes-kernel/linux/linux-aspeed_git.bb +++ b/meta-aspeed/recipes-kernel/linux/linux-aspeed_git.bb @@ -1,6 +1,6 @@ KBRANCH ?= "dev-6.5" -LINUX_VERSION ?= "6.5.4" +LINUX_VERSION ?= "6.5.9" -SRCREV="da279e98c07f9c948c60a434ab0043a55c26ea1d" +SRCREV="fc8d4fdba5bd2b9b1cea2aa8a731531943c45aa7" require linux-aspeed.inc With the lack of a dependency the mdio-tools package is not rebuilt subsequent to the kernel bump and the package information remains stale, leading to an incorrect SPDX path being generated. Signed-off-by: Andrew Jeffery --- meta-networking/recipes-support/mdio-tools/mdio-tools_1.3.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta-networking/recipes-support/mdio-tools/mdio-tools_1.3.0.bb b/meta-networking/recipes-support/mdio-tools/mdio-tools_1.3.0.bb index cd4df3da05cb..0c64889bc390 100644 --- a/meta-networking/recipes-support/mdio-tools/mdio-tools_1.3.0.bb +++ b/meta-networking/recipes-support/mdio-tools/mdio-tools_1.3.0.bb @@ -1,6 +1,6 @@ require mdio-tools.inc -DEPENDS += "libmnl" +DEPENDS += "virtual/kernel libmnl" S = "${WORKDIR}/git"