Patchwork minimal.conf: Prefer libtool 2.4 with sysroot support

login
register
mail settings
Submitter Khem Raj
Date Dec. 9, 2010, 3:23 a.m.
Message ID <1291864997-30025-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/33/
State Superseded
Headers show

Comments

Khem Raj - Dec. 9, 2010, 3:23 a.m.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 conf/distro/minimal.conf |    9 ++++++++-
 1 files changed, 8 insertions(+), 1 deletions(-)
Martin Jansa - Dec. 9, 2010, 8:12 a.m.
On Wed, Dec 08, 2010 at 07:23:17PM -0800, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  conf/distro/minimal.conf |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> diff --git a/conf/distro/minimal.conf b/conf/distro/minimal.conf
> index 5b92a36..451d010 100644
> --- a/conf/distro/minimal.conf
> +++ b/conf/distro/minimal.conf
> @@ -102,13 +102,20 @@ require conf/distro/include/preferred-xorg-versions-X11R7.5.inc
>  
>  PREFERRED_PROVIDER_opkg ?= "opkg"
>  PREFERRED_PROVIDER_virtual/update-alternatives ?= "opkg"
> -PREFERRED_QT_VERSION ?= "4.7.1"
> +PREFERRED_QT_VERSION                 ?= "4.7.1"
> +PREFERRED_LIBTOOL_VERSION            ?= "2.4"
> +LIBTOOL_HAS_SYSROOT                  ?= "yes"

what about setting this libtool version in sane-toolchain.inc? with more
distros using it we'll get better test coverage and state of recipes
built with it seems good enough to me (SHR is using it for a while).
Khem Raj - Dec. 9, 2010, 3:55 p.m.
On Thu, Dec 9, 2010 at 12:12 AM, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Wed, Dec 08, 2010 at 07:23:17PM -0800, Khem Raj wrote:
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  conf/distro/minimal.conf |    9 ++++++++-
>>  1 files changed, 8 insertions(+), 1 deletions(-)
>>
>> diff --git a/conf/distro/minimal.conf b/conf/distro/minimal.conf
>> index 5b92a36..451d010 100644
>> --- a/conf/distro/minimal.conf
>> +++ b/conf/distro/minimal.conf
>> @@ -102,13 +102,20 @@ require conf/distro/include/preferred-xorg-versions-X11R7.5.inc
>>
>>  PREFERRED_PROVIDER_opkg ?= "opkg"
>>  PREFERRED_PROVIDER_virtual/update-alternatives ?= "opkg"
>> -PREFERRED_QT_VERSION ?= "4.7.1"
>> +PREFERRED_QT_VERSION                 ?= "4.7.1"
>> +PREFERRED_LIBTOOL_VERSION            ?= "2.4"
>> +LIBTOOL_HAS_SYSROOT                  ?= "yes"
>
> what about setting this libtool version in sane-toolchain.inc?

Initially I thought of that but then kept the sope to minimal only.
But I am fine to put it
in sane-toolchain.inc if no one sees any issues with it

with more
> distros using it we'll get better test coverage and state of recipes
> built with it seems good enough to me (SHR is using it for a while).
>



> --
> Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>

Patch

diff --git a/conf/distro/minimal.conf b/conf/distro/minimal.conf
index 5b92a36..451d010 100644
--- a/conf/distro/minimal.conf
+++ b/conf/distro/minimal.conf
@@ -102,13 +102,20 @@  require conf/distro/include/preferred-xorg-versions-X11R7.5.inc
 
 PREFERRED_PROVIDER_opkg ?= "opkg"
 PREFERRED_PROVIDER_virtual/update-alternatives ?= "opkg"
-PREFERRED_QT_VERSION ?= "4.7.1"
+PREFERRED_QT_VERSION                 ?= "4.7.1"
+PREFERRED_LIBTOOL_VERSION            ?= "2.4"
+LIBTOOL_HAS_SYSROOT                  ?= "yes"
 PREFERRED_VERSION_qt4-tools-native = "${PREFERRED_QT_VERSION}"
 PREFERRED_VERSION_qt4-tools-sdk = "${PREFERRED_QT_VERSION}"
 PREFERRED_VERSION_qt4-embedded = "${PREFERRED_QT_VERSION}"
 PREFERRED_VERSION_qt4-embedded-gles = "${PREFERRED_QT_VERSION}"
 PREFERRED_VERSION_qt4-x11-free = "${PREFERRED_QT_VERSION}"
 PREFERRED_VERSION_qt4-x11-free-gles = "${PREFERRED_QT_VERSION}"
+PREFERRED_VERSION_libtool = "${PREFERRED_LIBTOOL_VERSION}"
+PREFERRED_VERSION_libtool-cross = "${PREFERRED_LIBTOOL_VERSION}"
+PREFERRED_VERSION_libtool-native = "${PREFERRED_LIBTOOL_VERSION}"
+PREFERRED_VERSION_libtool-sdk = "${PREFERRED_LIBTOOL_VERSION}"
+PREFERRED_VERSION_libtool-nativesdk = "${PREFERRED_LIBTOOL_VERSION}"
 
 #############################################################################
 # CONTENTS