| Submitter | Song.Li@windriver.com |
|---|---|
| Date | July 24, 2012, 9:48 a.m. |
| Message ID | <500E6F68.7090506@windriver.com> |
| Download | mbox | patch |
| Permalink | /patch/32927/ |
| State | Not Applicable |
| Headers | show |
Comments
On Tuesday 24 July 2012 17:48:24 Song.Li wrote: > I sent this patch last week, didn't get any reply, just resent it to > confirm. Sorry we didn't get back to you sooner. However I notice the inner patch is missing an "Upstream-Status" field - could you please add this? https://wiki.yoctoproject.org/wiki/Best_Known_Methods_%28BKMs%29_for_Package_Updating#Patch_Upstreaming Thanks, Paul
On Tuesday 24 July 2012 12:03:52 Paul Eggleton wrote: > On Tuesday 24 July 2012 17:48:24 Song.Li wrote: > > I sent this patch last week, didn't get any reply, just resent it to > > confirm. > > Sorry we didn't get back to you sooner. However I notice the inner patch is > missing an "Upstream-Status" field - could you please add this? > > https://wiki.yoctoproject.org/wiki/Best_Known_Methods_%28BKMs%29_for_Package > _Updating#Patch_Upstreaming Also, the reason this was missed was probably because it wasn't sent to the right mailing list. Please send the updated version to openembedded- core@lists.openembedded.org rather than the openembedded-devel list. Thanks, Paul
Patch
diff --git a/meta/recipes-extended/sysstat/files/remove-s-option-of-LFLAGS.patch b/meta/recipes-extended/sysstat/files/remove-s-option-of-LFLAGS.patch new file mode 100644 index 0000000..5c23091 --- /dev/null +++ b/meta/recipes-extended/sysstat/files/remove-s-option-of-LFLAGS.patch @@ -0,0 +1,34 @@ +From 69f0088cbe300628f5d94b66505ac8ed07565229 Mon Sep 17 00:00:00 2001 +From: "Song.Li" <Song.Li@windriver.com> +Date: Fri, 13 Jul 2012 13:51:13 +0800 +Subject: [PATCH] remove -s option of LFLAGS + +sysstat Makefile shouldn't use -s option to strip binary +because we need debug info for dbg package. +The old way to remove -s option is passing LFLAGS='' +in make command line to clean all the LFLAGS variable in Makefile. +That will cause build failure when sensors lib is needed. +In fact,only "-s" should be removeed, others LFLAGS should be kept. + +[YOCTO #2740] + +Signed-off-by: Song.Li <Song.Li@windriver.com> +--- + Makefile.in | 1 - + 1 file changed, 1 deletion(-) + +diff --git a/Makefile.in b/Makefile.in +index d1ea853..ee6cbc1 100644 +--- a/Makefile.in ++++ b/Makefile.in +@@ -71,7 +71,6 @@ SYSCONFIG_DIR = @SYSCONFIG_DIR@ + # Compiler flags + CFLAGS = @CFLAGS@ -Wall -Wstrict-prototypes -pipe -O2 + DFLAGS = @DFLAGS@ +-LFLAGS = -s + DFLAGS += -DSA_DIR=\"$(SA_DIR)\" -DSADC_PATH=\"$(SADC_PATH)\" + DFLAGS += $(DFSENSORS) + +-- +1.7.9.5 + diff --git a/meta/recipes-extended/sysstat/sysstat.inc b/meta/recipes-extended/sysstat/sysstat.inc index 9da40a7..1c98101 100644 --- a/meta/recipes-extended/sysstat/sysstat.inc +++ b/meta/recipes-extended/sysstat/sysstat.inc @@ -5,11 +5,12 @@ LICENSE = "GPLv2+" SECTION = "console/utils" SRC_URI = "http://pagesperso-orange.fr/sebastien.godard/sysstat-${PV}.tar.gz \ - file://99_sysstat" + file://99_sysstat \ + file://remove-s-option-of-LFLAGS.patch \ + " inherit autotools gettext -EXTRA_OEMAKE += 'LFLAGS=""' do_install() { autotools_do_install diff --git a/meta/recipes-extended/sysstat/sysstat_10.0.3.bb b/meta/recipes-extended/sysstat/sysstat_10.0.3.bb index 7ef6c60..93fbe21 100644 --- a/meta/recipes-extended/sysstat/sysstat_10.0.3.bb +++ b/meta/recipes-extended/sysstat/sysstat_10.0.3.bb @@ -2,7 +2,7 @@ require sysstat.inc LIC_FILES_CHKSUM = "file://COPYING;md5=8ca43cbc842c2336e835926c2166c28b" -PR = "r1" +PR = "r2" SRC_URI[md5sum] = "0e1ed5200f31f69a3b90ff1e81c07745" SRC_URI[sha256sum] = "7c0dd172f09edaff100b33db29ef502e15e71867b505c6d519f76a24fabcc1f5"