Patchwork xinit_1.3.2: Remove broken, superfluous 'FILES_${PN} += "${libdir}X11/xinit"'

login
register
mail settings
Submitter Robert P. J. Day
Date July 24, 2012, 10:39 a.m.
Message ID <alpine.DEB.2.02.1207240636450.21023@oneiric>
Download mbox | patch
Permalink /patch/32925/
State New
Headers show

Comments

Robert P. J. Day - July 24, 2012, 10:39 a.m.
Besides being clearly broken, that line is unnecessary as that file is
already being picked up from this line in xorg-app-common.inc:

FILES_${PN} += " ${libdir}/X11/${BPN} ${datadir}/X11/app-defaults/"

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---
Saul Wold - July 26, 2012, 7:19 p.m.
On 07/24/2012 03:39 AM, Robert P. J. Day wrote:
>
> Besides being clearly broken, that line is unnecessary as that file is
> already being picked up from this line in xorg-app-common.inc:
>
> FILES_${PN} += " ${libdir}/X11/${BPN} ${datadir}/X11/app-defaults/"
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> diff --git a/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb b/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
> index 2008e79..5a97c3b 100644
> --- a/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
> +++ b/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
> @@ -19,5 +19,3 @@ SRC_URI[sha256sum] = "a1867fdaa83f68750b12ba4305c3c62f5992d0f52cfeb98e96c27a8e69
>   EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"
>
>   RDEPENDS_${PN} += "util-linux-mcookie"
> -
> -FILES_${PN} += "${libdir}X11/xinit"
>
Nice catch!

Merged into OE-Core

Thanks
	Sau!

Patch

diff --git a/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb b/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
index 2008e79..5a97c3b 100644
--- a/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
+++ b/meta/recipes-graphics/xorg-app/xinit_1.3.2.bb
@@ -19,5 +19,3 @@  SRC_URI[sha256sum] = "a1867fdaa83f68750b12ba4305c3c62f5992d0f52cfeb98e96c27a8e69
 EXTRA_OECONF = "ac_cv_path_MCOOKIE=${bindir}/mcookie"

 RDEPENDS_${PN} += "util-linux-mcookie"
-
-FILES_${PN} += "${libdir}X11/xinit"