| Message ID | 20231024141754.1528786-2-jstephan@baylibre.com |
|---|---|
| State | Accepted, archived |
| Commit | a37430f682bca9787d939b0722dd5d0d810c12c6 |
| Headers | show |
| Series | [RESEND,1/2] oeqa/selftest/devtool: abort if a local workspace already exist | expand |
Hello Julien, On Tue, 24 Oct 2023 16:17:54 +0200 "Julien Stephan" <jstephan@baylibre.com> wrote: > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > --- > meta/lib/oeqa/selftest/cases/devtool.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py > index c36b1efa78b..b5c488be8e8 100644 > --- a/meta/lib/oeqa/selftest/cases/devtool.py > +++ b/meta/lib/oeqa/selftest/cases/devtool.py > @@ -575,7 +575,7 @@ class DevtoolAddTests(DevtoolBase): > checkvars['S'] = '${WORKDIR}/MarkupSafe-%s' % testver > checkvars['SRC_URI'] = url > self._test_recipe_contents(recipefile, checkvars, []) > - > + This patch does not apply due to the '-' line above having no spaces after '-'. Perhaps your mailer mangled the content removing training whitespace (which, ironically, is what the patch itself aims at doing!). Using 'git send-email' is usually the best way to send patches without this sort of issues. Luca
Le mer. 25 oct. 2023 à 17:01, Luca Ceresoli <luca.ceresoli@bootlin.com> a écrit : > > Hello Julien, > > On Tue, 24 Oct 2023 16:17:54 +0200 > "Julien Stephan" <jstephan@baylibre.com> wrote: > > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > > --- > > meta/lib/oeqa/selftest/cases/devtool.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py > > index c36b1efa78b..b5c488be8e8 100644 > > --- a/meta/lib/oeqa/selftest/cases/devtool.py > > +++ b/meta/lib/oeqa/selftest/cases/devtool.py > > @@ -575,7 +575,7 @@ class DevtoolAddTests(DevtoolBase): > > checkvars['S'] = '${WORKDIR}/MarkupSafe-%s' % testver > > checkvars['SRC_URI'] = url > > self._test_recipe_contents(recipefile, checkvars, []) > > - > > + > > This patch does not apply due to the '-' line above having no spaces > after '-'. Perhaps your mailer mangled the content removing training > whitespace (which, ironically, is what the patch itself aims at doing!). > > Using 'git send-email' is usually the best way to send patches without > this sort of issues. > Hi Luca My editor mangled it.. I just resent it again. Thank you Cheers Julien > Luca > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com
diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py index c36b1efa78b..b5c488be8e8 100644 --- a/meta/lib/oeqa/selftest/cases/devtool.py +++ b/meta/lib/oeqa/selftest/cases/devtool.py @@ -575,7 +575,7 @@ class DevtoolAddTests(DevtoolBase): checkvars['S'] = '${WORKDIR}/MarkupSafe-%s' % testver checkvars['SRC_URI'] = url self._test_recipe_contents(recipefile, checkvars, []) - + def test_devtool_add_fetch_git(self): tempdir = tempfile.mkdtemp(prefix='devtoolqa') self.track_for_cleanup(tempdir)
Signed-off-by: Julien Stephan <jstephan@baylibre.com> --- meta/lib/oeqa/selftest/cases/devtool.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.41.0