Patchwork [v2,1/2] shadow-native: use 'users' group by default

login
register
mail settings
Submitter Otavio Salvador
Date July 23, 2012, 5:37 p.m.
Message ID <1343065037-13851-1-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/32865/
State New
Headers show

Comments

Otavio Salvador - July 23, 2012, 5:37 p.m.
The rootfs has 'users' group at number 100 and without this fix it
would assign to a non-existent group and if a group with gid as 1000
is created later it would own all files for users created.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 .../shadow/shadow-native_4.1.4.3.bb                |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
Saul Wold - July 26, 2012, 7:23 p.m.
On 07/23/2012 10:37 AM, Otavio Salvador wrote:
> The rootfs has 'users' group at number 100 and without this fix it
> would assign to a non-existent group and if a group with gid as 1000
> is created later it would own all files for users created.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>   .../shadow/shadow-native_4.1.4.3.bb                |    5 ++++-
>   1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-extended/shadow/shadow-native_4.1.4.3.bb b/meta/recipes-extended/shadow/shadow-native_4.1.4.3.bb
> index 1e071f1..cd5605f 100644
> --- a/meta/recipes-extended/shadow/shadow-native_4.1.4.3.bb
> +++ b/meta/recipes-extended/shadow/shadow-native_4.1.4.3.bb
> @@ -7,7 +7,7 @@ LICENSE = "BSD | Artistic-1.0"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=08c553a87d4e51bbed50b20e0adcaede \
>                       file://src/passwd.c;firstline=8;endline=30;md5=2899a045e90511d0e043b85a7db7e2fe"
>
> -PR = "r6"
> +PR = "r7"
>
>   SRC_URI = "http://pkg-shadow.alioth.debian.org/releases/${BPN}-${PV}.tar.bz2 \
>              file://shadow.automake-1.11.patch \
> @@ -46,4 +46,7 @@ do_install_append() {
>   	# Now we don't have a mail system. Disable mail creation for now.
>   	sed -i 's:/bin/bash:/bin/sh:g' ${D}${sysconfdir}/default/useradd
>   	sed -i '/^CREATE_MAIL_SPOOL/ s:^:#:' ${D}${sysconfdir}/default/useradd
> +
> +	# Use users group by default
> +	sed -i 's,^GROUP=1000,GROUP=100,g' ${D}${sysconfdir}/default/useradd
>   }
>

Merged these 2 into OE-Core

Thanks
	Sau!
Otavio Salvador - Aug. 2, 2012, 2:34 p.m.
On Mon, Jul 23, 2012 at 2:37 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The rootfs has 'users' group at number 100 and without this fix it
> would assign to a non-existent group and if a group with gid as 1000
> is created later it would own all files for users created.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Can this be included on 1.2.2?

Patch

diff --git a/meta/recipes-extended/shadow/shadow-native_4.1.4.3.bb b/meta/recipes-extended/shadow/shadow-native_4.1.4.3.bb
index 1e071f1..cd5605f 100644
--- a/meta/recipes-extended/shadow/shadow-native_4.1.4.3.bb
+++ b/meta/recipes-extended/shadow/shadow-native_4.1.4.3.bb
@@ -7,7 +7,7 @@  LICENSE = "BSD | Artistic-1.0"
 LIC_FILES_CHKSUM = "file://COPYING;md5=08c553a87d4e51bbed50b20e0adcaede \
                     file://src/passwd.c;firstline=8;endline=30;md5=2899a045e90511d0e043b85a7db7e2fe"
 
-PR = "r6"
+PR = "r7"
 
 SRC_URI = "http://pkg-shadow.alioth.debian.org/releases/${BPN}-${PV}.tar.bz2 \
            file://shadow.automake-1.11.patch \
@@ -46,4 +46,7 @@  do_install_append() {
 	# Now we don't have a mail system. Disable mail creation for now.
 	sed -i 's:/bin/bash:/bin/sh:g' ${D}${sysconfdir}/default/useradd
 	sed -i '/^CREATE_MAIL_SPOOL/ s:^:#:' ${D}${sysconfdir}/default/useradd
+
+	# Use users group by default
+	sed -i 's,^GROUP=1000,GROUP=100,g' ${D}${sysconfdir}/default/useradd
 }