Patchwork [v2,2/2] shadow: use 'users' group by default

login
register
mail settings
Submitter Otavio Salvador
Date July 23, 2012, 5:37 p.m.
Message ID <1343065037-13851-2-git-send-email-otavio@ossystems.com.br>
Download mbox | patch
Permalink /patch/32863/
State New
Headers show

Comments

Otavio Salvador - July 23, 2012, 5:37 p.m.
The rootfs has 'users' group at number 100 and without this fix it
would assign to a non-existent group and if a group with gid as 1000
is created later it would own all files for users created.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
 meta/recipes-extended/shadow/shadow_4.1.4.3.bb |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
Otavio Salvador - Aug. 2, 2012, 2:36 p.m.
On Mon, Jul 23, 2012 at 2:37 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The rootfs has 'users' group at number 100 and without this fix it
> would assign to a non-existent group and if a group with gid as 1000
> is created later it would own all files for users created.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>

Can it be included on 1.2.2?

Patch

diff --git a/meta/recipes-extended/shadow/shadow_4.1.4.3.bb b/meta/recipes-extended/shadow/shadow_4.1.4.3.bb
index 506f4e6..de10f64 100644
--- a/meta/recipes-extended/shadow/shadow_4.1.4.3.bb
+++ b/meta/recipes-extended/shadow/shadow_4.1.4.3.bb
@@ -9,7 +9,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=08c553a87d4e51bbed50b20e0adcaede \
 
 DEPENDS = "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
 RDEPENDS_${PN} = "shadow-securetty ${@base_contains('DISTRO_FEATURES', 'pam', '${PAM_PLUGINS}', '', d)}"
-PR = "r10"
+PR = "r11"
 
 SRC_URI = "http://pkg-shadow.alioth.debian.org/releases/${BPN}-${PV}.tar.bz2 \
            file://login_defs_pam.sed \
@@ -85,6 +85,9 @@  do_install_append() {
 	sed -i 's:/bin/bash:/bin/sh:g' ${D}${sysconfdir}/default/useradd
 	sed -i '/^CREATE_MAIL_SPOOL/ s:^:#:' ${D}${sysconfdir}/default/useradd
 
+	# Use users group by default
+	sed -i 's,^GROUP=1000,GROUP=100,g' ${D}${sysconfdir}/default/useradd
+
 	install -d ${D}${sbindir} ${D}${base_sbindir} ${D}${base_bindir} 
 
 	# Move binaries to the locations we want