Patchwork [1/1] quota 4.00: add DEPENDS gettext-native

login
register
mail settings
Submitter jackie huang
Date July 23, 2012, 8:38 a.m.
Message ID <5e873b2c99606b089ed82777f64049837a30beb0.1343032359.git.jackie.huang@windriver.com>
Download mbox | patch
Permalink /patch/32829/
State Accepted
Commit f12f75aa57cacc73a0428cedba970076f0abb9f8
Headers show

Comments

jackie huang - July 23, 2012, 8:38 a.m.
From: Jackie Huang <jackie.huang@windriver.com>

do_install needs command 'msgfmt', it would fail if the command
doesn't exist on the host, add DEPENDS gettext-native to fix this.

[YOCTO #2811]

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 meta/recipes-extended/quota/quota_4.00.bb |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Richard Purdie - July 23, 2012, 10 a.m.
On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
> 
> do_install needs command 'msgfmt', it would fail if the command
> doesn't exist on the host, add DEPENDS gettext-native to fix this.
> 
> [YOCTO #2811]
> 
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  meta/recipes-extended/quota/quota_4.00.bb |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-extended/quota/quota_4.00.bb b/meta/recipes-extended/quota/quota_4.00.bb
> index 5fef9cb..25f6381 100644
> --- a/meta/recipes-extended/quota/quota_4.00.bb
> +++ b/meta/recipes-extended/quota/quota_4.00.bb
> @@ -15,6 +15,8 @@ SRC_URI[sha256sum] = "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f
>  
>  S = "${WORKDIR}/quota-tools"
>  
> +DEPENDS = "gettext-native"
> +
>  inherit autotools
>  
>  EXTRA_OEMAKE += 'STRIP=""'

Shouldn't this be "inherit gettext" ?

Cheers,

Richard
jackie huang - July 24, 2012, 5:17 a.m.
On 7/23/2012 6:00 PM, Richard Purdie wrote:
> On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote:
>> From: Jackie Huang<jackie.huang@windriver.com>
>>
>> do_install needs command 'msgfmt', it would fail if the command
>> doesn't exist on the host, add DEPENDS gettext-native to fix this.
>>
>> [YOCTO #2811]
>>
>> Signed-off-by: Jackie Huang<jackie.huang@windriver.com>
>> ---
>>   meta/recipes-extended/quota/quota_4.00.bb |    2 ++
>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/meta/recipes-extended/quota/quota_4.00.bb b/meta/recipes-extended/quota/quota_4.00.bb
>> index 5fef9cb..25f6381 100644
>> --- a/meta/recipes-extended/quota/quota_4.00.bb
>> +++ b/meta/recipes-extended/quota/quota_4.00.bb
>> @@ -15,6 +15,8 @@ SRC_URI[sha256sum] = "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f
>>
>>   S = "${WORKDIR}/quota-tools"
>>
>> +DEPENDS = "gettext-native"
>> +
>>   inherit autotools
>>
>>   EXTRA_OEMAKE += 'STRIP=""'
>
> Shouldn't this be "inherit gettext" ?

No, quota doesn't depend on gettext at runtime, so I don't think we need 
'inherit gettext'.

Thanks,
Jackie

>
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
jackie huang - Aug. 24, 2012, 3:18 a.m.
On 7/24/2012 1:17 PM, jhuang0 wrote:
>
>
> On 7/23/2012 6:00 PM, Richard Purdie wrote:
>> On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote:
>>> From: Jackie Huang<jackie.huang@windriver.com>
>>>
>>> do_install needs command 'msgfmt', it would fail if the command
>>> doesn't exist on the host, add DEPENDS gettext-native to fix this.
>>>
>>> [YOCTO #2811]
>>>
>>> Signed-off-by: Jackie Huang<jackie.huang@windriver.com>
>>> ---
>>>   meta/recipes-extended/quota/quota_4.00.bb |    2 ++
>>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/meta/recipes-extended/quota/quota_4.00.bb
>>> b/meta/recipes-extended/quota/quota_4.00.bb
>>> index 5fef9cb..25f6381 100644
>>> --- a/meta/recipes-extended/quota/quota_4.00.bb
>>> +++ b/meta/recipes-extended/quota/quota_4.00.bb
>>> @@ -15,6 +15,8 @@ SRC_URI[sha256sum] =
>>> "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f
>>>
>>>   S = "${WORKDIR}/quota-tools"
>>>
>>> +DEPENDS = "gettext-native"
>>> +
>>>   inherit autotools
>>>
>>>   EXTRA_OEMAKE += 'STRIP=""'
>>
>> Shouldn't this be "inherit gettext" ?
>
> No, quota doesn't depend on gettext at runtime, so I don't think we need
> 'inherit gettext'.

quota only needs command 'msgfmt' which provied by gettext in 
do_install, so I don't think we need 'inherit gettext' to both depends 
on gettext-native and virtual/gettext. Could anyone explain why we 
should use 'inherit gettext' instead of just depending on gettext-native?

Thanks,
Jackie

>
> Thanks,
> Jackie
>
>>
>> Cheers,
>>
>> Richard
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>>
>
Noor Ahsan - Sept. 6, 2012, 2 p.m.
Hello,

Kindly someone merge this patch. We are hitting this issue.

Regards,
Noor

-----Original Message-----
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of jhuang0
Sent: Friday, August 24, 2012 8:18 AM
To: Patches and discussions about the oe-core layer
Cc: Zhao, Zhenfeng; Yang, Liezhi
Subject: Re: [OE-core] [PATCH 1/1] quota 4.00: add DEPENDS gettext-native



On 7/24/2012 1:17 PM, jhuang0 wrote:
>
>
> On 7/23/2012 6:00 PM, Richard Purdie wrote:
>> On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote:
>>> From: Jackie Huang<jackie.huang@windriver.com>
>>>
>>> do_install needs command 'msgfmt', it would fail if the command 
>>> doesn't exist on the host, add DEPENDS gettext-native to fix this.
>>>
>>> [YOCTO #2811]
>>>
>>> Signed-off-by: Jackie Huang<jackie.huang@windriver.com>
>>> ---
>>>   meta/recipes-extended/quota/quota_4.00.bb |    2 ++
>>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/meta/recipes-extended/quota/quota_4.00.bb
>>> b/meta/recipes-extended/quota/quota_4.00.bb
>>> index 5fef9cb..25f6381 100644
>>> --- a/meta/recipes-extended/quota/quota_4.00.bb
>>> +++ b/meta/recipes-extended/quota/quota_4.00.bb
>>> @@ -15,6 +15,8 @@ SRC_URI[sha256sum] = 
>>> "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f
>>>
>>>   S = "${WORKDIR}/quota-tools"
>>>
>>> +DEPENDS = "gettext-native"
>>> +
>>>   inherit autotools
>>>
>>>   EXTRA_OEMAKE += 'STRIP=""'
>>
>> Shouldn't this be "inherit gettext" ?
>
> No, quota doesn't depend on gettext at runtime, so I don't think we 
> need 'inherit gettext'.

quota only needs command 'msgfmt' which provied by gettext in do_install, so I don't think we need 'inherit gettext' to both depends on gettext-native and virtual/gettext. Could anyone explain why we should use 'inherit gettext' instead of just depending on gettext-native?

Thanks,
Jackie

>
> Thanks,
> Jackie
>
>>
>> Cheers,
>>
>> Richard
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>>
>

--
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily@hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745
Richard Purdie - Sept. 12, 2012, 2:02 p.m.
On Mon, 2012-07-23 at 16:38 +0800, jackie.huang@windriver.com wrote:
> From: Jackie Huang <jackie.huang@windriver.com>
> 
> do_install needs command 'msgfmt', it would fail if the command
> doesn't exist on the host, add DEPENDS gettext-native to fix this.
> 
> [YOCTO #2811]
> 
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  meta/recipes-extended/quota/quota_4.00.bb |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)

Merged to master, thanks. Sorry for the delay on this on, the patch is
the correct fix in this case (just a little unusual).

Cheers,

Richard

Patch

diff --git a/meta/recipes-extended/quota/quota_4.00.bb b/meta/recipes-extended/quota/quota_4.00.bb
index 5fef9cb..25f6381 100644
--- a/meta/recipes-extended/quota/quota_4.00.bb
+++ b/meta/recipes-extended/quota/quota_4.00.bb
@@ -15,6 +15,8 @@  SRC_URI[sha256sum] = "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f
 
 S = "${WORKDIR}/quota-tools"
 
+DEPENDS = "gettext-native"
+
 inherit autotools
 
 EXTRA_OEMAKE += 'STRIP=""'