Patchwork [meta-systemd] systemd_git.bb: Dont inherit vala and gitpkgv

login
register
mail settings
Submitter Khem Raj
Date July 21, 2012, 7:41 p.m.
Message ID <1342899684-4450-1-git-send-email-raj.khem@gmail.com>
Download mbox | patch
Permalink /patch/32791/
State Rejected
Headers show

Comments

Khem Raj - July 21, 2012, 7:41 p.m.
In an effort to use meta-systemd without meta-oe
layer (purely on OE-Core) I ran into these classes not being there in
OE-Core

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-systemd/recipes-core/systemd/systemd_git.bb |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)
Koen Kooi - July 22, 2012, 7:12 a.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 21-07-12 21:41, Khem Raj schreef:
> In an effort to use meta-systemd without meta-oe layer (purely on
> OE-Core) I ran into these classes not being there in OE-Core

The vala one isn't needed anymore, the GUI bits are a seperate project now,
but the gitpkgv needs to stay. We can symlink the class from meta-oe into
meta-systemd

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQC6fpMkyGM64RGpERAq6pAKCr+1GPYZLT4WeM0CZP+Amt/8e1kwCeLbUO
YgNIUkEEms/mtTUB2Qat2Sg=
=oLXc
-----END PGP SIGNATURE-----
Khem Raj - July 22, 2012, 4:35 p.m.
On Sun, Jul 22, 2012 at 12:12 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
>
> The vala one isn't needed anymore, the GUI bits are a seperate project now,
> but the gitpkgv needs to stay. We can symlink the class from meta-oe into
> meta-systemd

why do we need gitpkgv it creates unnecessary dependency on meta-oe it
would be better
to avoid it. What are downsides of not using gitpkgv ?
Paul Eggleton - July 22, 2012, 4:38 p.m.
On Sunday 22 July 2012 09:12:41 Koen Kooi wrote:
> Op 21-07-12 21:41, Khem Raj schreef:
> > In an effort to use meta-systemd without meta-oe layer (purely on
> > OE-Core) I ran into these classes not being there in OE-Core
> 
> The vala one isn't needed anymore, the GUI bits are a seperate project now,
> but the gitpkgv needs to stay. 

Why? I can't see how gitpkgv has anything to do with systemd...

Cheers,
Paul
Koen Kooi - July 22, 2012, 5:47 p.m.
Op 22 jul. 2012, om 18:38 heeft Paul Eggleton het volgende geschreven:

> On Sunday 22 July 2012 09:12:41 Koen Kooi wrote:
>> Op 21-07-12 21:41, Khem Raj schreef:
>>> In an effort to use meta-systemd without meta-oe layer (purely on
>>> OE-Core) I ran into these classes not being there in OE-Core
>> 
>> The vala one isn't needed anymore, the GUI bits are a seperate project now,
>> but the gitpkgv needs to stay. 
> 
> Why? I can't see how gitpkgv has anything to do with systemd...

Because it's used to set PV automatically:

inherit gitpkgv
PKGV = "v${GITPKGVTAG}"
Koen Kooi - July 22, 2012, 5:48 p.m.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 22-07-12 18:35, Khem Raj schreef:
> On Sun, Jul 22, 2012 at 12:12 AM, Koen Kooi <koen@dominion.thruhere.net>
> wrote:
>> 
>> The vala one isn't needed anymore, the GUI bits are a seperate project
>> now, but the gitpkgv needs to stay. We can symlink the class from
>> meta-oe into meta-systemd
> 
> why do we need gitpkgv it creates unnecessary dependency on meta-oe it 
> would be better to avoid it. What are downsides of not using gitpkgv ?

Right now we automatically get the proper version, removing gitpkgv would be
a regression. Why not symlink the class into meta-systemd?


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQDDztMkyGM64RGpERAvIzAJ41okNJo/onPU8pmnyBj+Rfge4KMACfUFBU
0rD0duRR+5QpyI9094ommXc=
=oJ9z
-----END PGP SIGNATURE-----
Khem Raj - July 22, 2012, 6:58 p.m.
On Sun, Jul 22, 2012 at 10:48 AM, Koen Kooi <koen@dominion.thruhere.net> wrote:
> Right now we automatically get the proper version, removing gitpkgv would be
> a regression. Why not symlink the class into meta-systemd?

symlink would work since both layers are in same repo but logically it
may not be right thing
secondly if one day we would want to make systemd as default init
system in OE-Core then
either gitpkgv has to go into OE-Core or it be dropped. I think with
advent of autopr these all
may become less important in time anyway.

Patch

diff --git a/meta-systemd/recipes-core/systemd/systemd_git.bb b/meta-systemd/recipes-core/systemd/systemd_git.bb
index 9cbdd76..6ae9abb 100644
--- a/meta-systemd/recipes-core/systemd/systemd_git.bb
+++ b/meta-systemd/recipes-core/systemd/systemd_git.bb
@@ -15,13 +15,13 @@  SERIAL_CONSOLE ?= "115200 /dev/ttyS0"
 
 SECTION = "base/shell"
 
-inherit gitpkgv
-PKGV = "v${GITPKGVTAG}"
+#inherit gitpkgv
+#PKGV = "v${GITPKGVTAG}"
 
-PV = "git"
-PR = "r2"
+PV = "git${SRCPV}"
+PR = "r3"
 
-inherit useradd pkgconfig autotools vala perlnative
+inherit useradd pkgconfig autotools perlnative
 
 SRCREV = "cd96b3b86abb4a88cac2722bdfb6e5d4413f6831"