Patchwork gtk-doc: Ensure we run gtkdocize else we could see build failures (e.g. evolution-data-server)

login
register
mail settings
Submitter Richard Purdie
Date July 20, 2012, 3:55 p.m.
Message ID <1342799746.21788.37.camel@ted>
Download mbox | patch
Permalink /patch/32739/
State Accepted
Commit aaf762bf20635a92d16e7aad6c154891d9d689c4
Headers show

Comments

Richard Purdie - July 20, 2012, 3:55 p.m.
This is a fix to Ross' series, we need to run gtkdocize in case anything
was built from source control and the appropriate files are missing.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
Ross Burton - July 20, 2012, 7:29 p.m.
On Friday, 20 July 2012 at 16:55, Richard Purdie wrote:
> This is a fix to Ross' series, we need to run gtkdocize in case anything
> was built from source control and the appropriate files are missing.

Good point but I'm curious how the build was succeeding/what broke before this.

Ross
Richard Purdie - July 22, 2012, 12:13 p.m.
On Fri, 2012-07-20 at 20:29 +0100, Ross Burton wrote:
> On Friday, 20 July 2012 at 16:55, Richard Purdie wrote:
> > This is a fix to Ross' series, we need to run gtkdocize in case anything
> > was built from source control and the appropriate files are missing.
> 
> Good point but I'm curious how the build was succeeding/what broke before this.

Probably you used an existing build which already had the gtk-doc.make
file touched and your didn't bump PR. The file therefore hung around. It
would only happen on something built from SCM (evolution-data-server is
a git recipe).

I'm guessing if you clean eds, it would show up.

Cheers,

Richard

Patch

diff --git a/meta/classes/gtk-doc.bbclass b/meta/classes/gtk-doc.bbclass
index 603b191..8a312f5 100644
--- a/meta/classes/gtk-doc.bbclass
+++ b/meta/classes/gtk-doc.bbclass
@@ -14,3 +14,7 @@  EXTRA_OECONF_append = "\
   --disable-gtk-doc-html \
   --disable-gtk-doc-pdf \
 "
+
+do_configure_prepend () {
+	gtkdocize
+}