Patchwork [2/2] createrepo 0.4.11: fix the RDEPENDS

login
register
mail settings
Submitter Robert Yang
Date July 20, 2012, 9:49 a.m.
Message ID <5735964eb9bdb685cf35d2ecdbb1694f5f6a5036.1342772908.git.liezhi.yang@windriver.com>
Download mbox | patch
Permalink /patch/32707/
State Accepted
Commit 77f4cc3ccb1aff467004e63cf80320534e02c01b
Headers show

Comments

Robert Yang - July 20, 2012, 9:49 a.m.
The libxml2-native and rpm-native should be ready before createrepo
runs since it needs "import libxml2 rpm".

The target createrepo needs libxml2-python when run, but the libxml2
doesn't generate the python module (disabled). We may need to fix it
or rename the recipe to createrepo-native_0.4.11.bb.

This recipe is only for the rpm backend system.

[YOCTO #2753]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 .../createrepo/createrepo_0.4.11.bb                |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Saul Wold - July 21, 2012, 12:18 a.m.
On 07/20/2012 02:49 AM, Robert Yang wrote:
> The libxml2-native and rpm-native should be ready before createrepo
> runs since it needs "import libxml2 rpm".
>
> The target createrepo needs libxml2-python when run, but the libxml2
> doesn't generate the python module (disabled). We may need to fix it
> or rename the recipe to createrepo-native_0.4.11.bb.
>
> This recipe is only for the rpm backend system.
>
> [YOCTO #2753]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>   .../createrepo/createrepo_0.4.11.bb                |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-support/createrepo/createrepo_0.4.11.bb b/meta/recipes-support/createrepo/createrepo_0.4.11.bb
> index 060ed59..7a4d059 100644
> --- a/meta/recipes-support/createrepo/createrepo_0.4.11.bb
> +++ b/meta/recipes-support/createrepo/createrepo_0.4.11.bb
> @@ -4,7 +4,9 @@ HOMEPAGE = "http://createrepo.baseurl.org/"
>   LICENSE = "GPLv2+"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760"
>
> -PR = "r3"
> +RDEPENDS_${PN}_virtclass-native += "libxml2-native rpm-native"
> +
This should not be required here since the package_rpm.bbclass contains 
a line:
PACKAGEINDEXDEPS += "rpm-native:do_populate_sysroot"

We might need to add libxml2-native to the PACKAGEINDEXDEPS

This was merged into OE-0Core, but the real issue turned out to be 
sstate across different distros.

Sau!



> +PR = "r4"
>
>   SRC_URI= "http://createrepo.baseurl.org/download/${BP}.tar.gz \
>             file://fix-native-install.patch \
>
Richard Purdie - July 22, 2012, 10:37 a.m.
On Fri, 2012-07-20 at 17:18 -0700, Saul Wold wrote:
> On 07/20/2012 02:49 AM, Robert Yang wrote:
> > The libxml2-native and rpm-native should be ready before createrepo
> > runs since it needs "import libxml2 rpm".
> >
> > The target createrepo needs libxml2-python when run, but the libxml2
> > doesn't generate the python module (disabled). We may need to fix it
> > or rename the recipe to createrepo-native_0.4.11.bb.
> >
> > This recipe is only for the rpm backend system.
> >
> > [YOCTO #2753]
> >
> > Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> > ---
> >   .../createrepo/createrepo_0.4.11.bb                |    4 +++-
> >   1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/recipes-support/createrepo/createrepo_0.4.11.bb b/meta/recipes-support/createrepo/createrepo_0.4.11.bb
> > index 060ed59..7a4d059 100644
> > --- a/meta/recipes-support/createrepo/createrepo_0.4.11.bb
> > +++ b/meta/recipes-support/createrepo/createrepo_0.4.11.bb
> > @@ -4,7 +4,9 @@ HOMEPAGE = "http://createrepo.baseurl.org/"
> >   LICENSE = "GPLv2+"
> >   LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760"
> >
> > -PR = "r3"
> > +RDEPENDS_${PN}_virtclass-native += "libxml2-native rpm-native"
> > +
> This should not be required here since the package_rpm.bbclass contains 
> a line:
> PACKAGEINDEXDEPS += "rpm-native:do_populate_sysroot"
> 
> We might need to add libxml2-native to the PACKAGEINDEXDEPS

FWIW, having correct RDEPENDS in the recipes is important so this fix is
a good one regardless of whether it fixes the other issue or not.

Cheers,

Richard
Robert Yang - July 23, 2012, 2:21 a.m.
On 07/21/2012 08:18 AM, Saul Wold wrote:
> On 07/20/2012 02:49 AM, Robert Yang wrote:
>> The libxml2-native and rpm-native should be ready before createrepo
>> runs since it needs "import libxml2 rpm".
>>
>> The target createrepo needs libxml2-python when run, but the libxml2
>> doesn't generate the python module (disabled). We may need to fix it
>> or rename the recipe to createrepo-native_0.4.11.bb.
>>
>> This recipe is only for the rpm backend system.
>>
>> [YOCTO #2753]
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   .../createrepo/createrepo_0.4.11.bb                |    4 +++-
>>   1 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta/recipes-support/createrepo/createrepo_0.4.11.bb
>> b/meta/recipes-support/createrepo/createrepo_0.4.11.bb
>> index 060ed59..7a4d059 100644
>> --- a/meta/recipes-support/createrepo/createrepo_0.4.11.bb
>> +++ b/meta/recipes-support/createrepo/createrepo_0.4.11.bb
>> @@ -4,7 +4,9 @@ HOMEPAGE = "http://createrepo.baseurl.org/"
>>   LICENSE = "GPLv2+"
>>   LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760"
>>
>> -PR = "r3"
>> +RDEPENDS_${PN}_virtclass-native += "libxml2-native rpm-native"
>> +
> This should not be required here since the package_rpm.bbclass contains a line:
> PACKAGEINDEXDEPS += "rpm-native:do_populate_sysroot"
>
> We might need to add libxml2-native to the PACKAGEINDEXDEPS
>

Thanks, but we may manually run createrepo, if we just "bitbake createrepo" and
manually run createrepo, it would be failed if rpm-native is not ready.

> This was merged into OE-0Core, but the real issue turned out to be sstate across
> different distros.
>

I had tried to use sstate across different distros (ubuntu 12.04 64bit and FC 17 
64 bit),
there were strange errors.

// Robert

> Sau!
>
>
>
>> +PR = "r4"
>>
>>   SRC_URI= "http://createrepo.baseurl.org/download/${BP}.tar.gz \
>>             file://fix-native-install.patch \
>>
>
>
>

Patch

diff --git a/meta/recipes-support/createrepo/createrepo_0.4.11.bb b/meta/recipes-support/createrepo/createrepo_0.4.11.bb
index 060ed59..7a4d059 100644
--- a/meta/recipes-support/createrepo/createrepo_0.4.11.bb
+++ b/meta/recipes-support/createrepo/createrepo_0.4.11.bb
@@ -4,7 +4,9 @@  HOMEPAGE = "http://createrepo.baseurl.org/"
 LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=18810669f13b87348459e611d31ab760"
 
-PR = "r3"
+RDEPENDS_${PN}_virtclass-native += "libxml2-native rpm-native"
+
+PR = "r4"
 
 SRC_URI= "http://createrepo.baseurl.org/download/${BP}.tar.gz \
           file://fix-native-install.patch \