| Message ID | 20231019132843.2623456-1-sean@geanix.com |
|---|---|
| State | New |
| Headers | show |
| Series | [mickledore] weston: default to launcher-seatd | expand |
On Thu, Oct 19, 2023 at 3:28 AM Sean Nyekjaer <sean@geanix.com> wrote: > > Lets use the launcher-seatd as default, launcher-logind is "sometimes" > failing to provide input events. Further more is the launcher-logind > depricated in newer versions of weston. Changing behaviour is typically not allowed in stable branches. In any event, this change would need to go into the master branch before it could be backported to stable branches. So please submit this for the master branch! Steve > > Signed-off-by: Sean Nyekjaer <sean@geanix.com> > --- > meta/recipes-graphics/wayland/weston_11.0.1.bb | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/recipes-graphics/wayland/weston_11.0.1.bb b/meta/recipes-graphics/wayland/weston_11.0.1.bb > index 0838791a6b..09753e7c51 100644 > --- a/meta/recipes-graphics/wayland/weston_11.0.1.bb > +++ b/meta/recipes-graphics/wayland/weston_11.0.1.bb > @@ -37,7 +37,7 @@ PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'kms wayla > ${@bb.utils.contains('DISTRO_FEATURES', 'x11 wayland', 'xwayland', '', d)} \ > ${@bb.utils.filter('DISTRO_FEATURES', 'systemd x11', d)} \ > ${@bb.utils.contains_any('DISTRO_FEATURES', 'wayland x11', '', 'headless', d)} \ > - ${@oe.utils.conditional('VIRTUAL-RUNTIME_init_manager', 'sysvinit', 'launcher-libseat', '', d)} \ > + launcher-libseat \ > image-jpeg \ > screenshare \ > shell-desktop \ > @@ -71,7 +71,7 @@ PACKAGECONFIG[lcms] = "-Dcolor-management-lcms=true,-Dcolor-management-lcms=fals > # Weston with webp support > PACKAGECONFIG[webp] = "-Dimage-webp=true,-Dimage-webp=false,libwebp" > # Weston with systemd-login support > -PACKAGECONFIG[systemd] = "-Dsystemd=true -Dlauncher-logind=true,-Dsystemd=false -Dlauncher-logind=false,systemd dbus" > +PACKAGECONFIG[systemd] = "-Dsystemd=true,-Dsystemd=false,systemd dbus" > # Weston with Xwayland support (requires X11 and Wayland) > PACKAGECONFIG[xwayland] = "-Dxwayland=true,-Dxwayland=false,libxcb libxcursor xwayland" > # colord CMS support > -- > 2.42.0 >
Quoting Steve Sakoman <steve@sakoman.com>: > On Thu, Oct 19, 2023 at 3:28 AM Sean Nyekjaer <sean@geanix.com> wrote: >> >> Lets use the launcher-seatd as default, launcher-logind is "sometimes" >> failing to provide input events. Further more is the launcher-logind >> depricated in newer versions of weston. > > Changing behaviour is typically not allowed in stable branches. > > In any event, this change would need to go into the master branch > before it could be backported to stable branches. So please submit > this for the master branch! > > Steve Hi Steve, It is part of the master branch be7da75 “weston: update 11.0.1 - 12.0.1” /Sean > >> >> Signed-off-by: Sean Nyekjaer <sean@geanix.com> >> --- >> meta/recipes-graphics/wayland/weston_11.0.1.bb | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/meta/recipes-graphics/wayland/weston_11.0.1.bb >> b/meta/recipes-graphics/wayland/weston_11.0.1.bb >> index 0838791a6b..09753e7c51 100644 >> --- a/meta/recipes-graphics/wayland/weston_11.0.1.bb >> +++ b/meta/recipes-graphics/wayland/weston_11.0.1.bb >> @@ -37,7 +37,7 @@ PACKAGECONFIG ??= >> "${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'kms wayla >> ${@bb.utils.contains('DISTRO_FEATURES', 'x11 >> wayland', 'xwayland', '', d)} \ >> ${@bb.utils.filter('DISTRO_FEATURES', 'systemd >> x11', d)} \ >> ${@bb.utils.contains_any('DISTRO_FEATURES', >> 'wayland x11', '', 'headless', d)} \ >> - >> ${@oe.utils.conditional('VIRTUAL-RUNTIME_init_manager', 'sysvinit', >> 'launcher-libseat', '', d)} \ >> + launcher-libseat \ >> image-jpeg \ >> screenshare \ >> shell-desktop \ >> @@ -71,7 +71,7 @@ PACKAGECONFIG[lcms] = >> "-Dcolor-management-lcms=true,-Dcolor-management-lcms=fals >> # Weston with webp support >> PACKAGECONFIG[webp] = "-Dimage-webp=true,-Dimage-webp=false,libwebp" >> # Weston with systemd-login support >> -PACKAGECONFIG[systemd] = "-Dsystemd=true >> -Dlauncher-logind=true,-Dsystemd=false >> -Dlauncher-logind=false,systemd dbus" >> +PACKAGECONFIG[systemd] = "-Dsystemd=true,-Dsystemd=false,systemd dbus" >> # Weston with Xwayland support (requires X11 and Wayland) >> PACKAGECONFIG[xwayland] = "-Dxwayland=true,-Dxwayland=false,libxcb >> libxcursor xwayland" >> # colord CMS support >> -- >> 2.42.0 >>
On Fri, Oct 20, 2023 at 7:26 AM <sean@geanix.com> wrote: > > Quoting Steve Sakoman <steve@sakoman.com>: > > > On Thu, Oct 19, 2023 at 3:28 AM Sean Nyekjaer <sean@geanix.com> wrote: > >> > >> Lets use the launcher-seatd as default, launcher-logind is "sometimes" > >> failing to provide input events. Further more is the launcher-logind > >> depricated in newer versions of weston. > > > > Changing behaviour is typically not allowed in stable branches. > > > > In any event, this change would need to go into the master branch > > before it could be backported to stable branches. So please submit > > this for the master branch! > > > > Steve > > Hi Steve, > > It is part of the master branch be7da75 “weston: update 11.0.1 - 12.0.1” OK, then no need to submit for master :-) I'm still not able to take this for mickledore though, since it would cause a behaviour change for people already shipping product with mickledore. Steve > >> Signed-off-by: Sean Nyekjaer <sean@geanix.com> > >> --- > >> meta/recipes-graphics/wayland/weston_11.0.1.bb | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/meta/recipes-graphics/wayland/weston_11.0.1.bb > >> b/meta/recipes-graphics/wayland/weston_11.0.1.bb > >> index 0838791a6b..09753e7c51 100644 > >> --- a/meta/recipes-graphics/wayland/weston_11.0.1.bb > >> +++ b/meta/recipes-graphics/wayland/weston_11.0.1.bb > >> @@ -37,7 +37,7 @@ PACKAGECONFIG ??= > >> "${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'kms wayla > >> ${@bb.utils.contains('DISTRO_FEATURES', 'x11 > >> wayland', 'xwayland', '', d)} \ > >> ${@bb.utils.filter('DISTRO_FEATURES', 'systemd > >> x11', d)} \ > >> ${@bb.utils.contains_any('DISTRO_FEATURES', > >> 'wayland x11', '', 'headless', d)} \ > >> - > >> ${@oe.utils.conditional('VIRTUAL-RUNTIME_init_manager', 'sysvinit', > >> 'launcher-libseat', '', d)} \ > >> + launcher-libseat \ > >> image-jpeg \ > >> screenshare \ > >> shell-desktop \ > >> @@ -71,7 +71,7 @@ PACKAGECONFIG[lcms] = > >> "-Dcolor-management-lcms=true,-Dcolor-management-lcms=fals > >> # Weston with webp support > >> PACKAGECONFIG[webp] = "-Dimage-webp=true,-Dimage-webp=false,libwebp" > >> # Weston with systemd-login support > >> -PACKAGECONFIG[systemd] = "-Dsystemd=true > >> -Dlauncher-logind=true,-Dsystemd=false > >> -Dlauncher-logind=false,systemd dbus" > >> +PACKAGECONFIG[systemd] = "-Dsystemd=true,-Dsystemd=false,systemd dbus" > >> # Weston with Xwayland support (requires X11 and Wayland) > >> PACKAGECONFIG[xwayland] = "-Dxwayland=true,-Dxwayland=false,libxcb > >> libxcursor xwayland" > >> # colord CMS support > >> -- > >> 2.42.0 > >> > > >
diff --git a/meta/recipes-graphics/wayland/weston_11.0.1.bb b/meta/recipes-graphics/wayland/weston_11.0.1.bb index 0838791a6b..09753e7c51 100644 --- a/meta/recipes-graphics/wayland/weston_11.0.1.bb +++ b/meta/recipes-graphics/wayland/weston_11.0.1.bb @@ -37,7 +37,7 @@ PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'kms wayla ${@bb.utils.contains('DISTRO_FEATURES', 'x11 wayland', 'xwayland', '', d)} \ ${@bb.utils.filter('DISTRO_FEATURES', 'systemd x11', d)} \ ${@bb.utils.contains_any('DISTRO_FEATURES', 'wayland x11', '', 'headless', d)} \ - ${@oe.utils.conditional('VIRTUAL-RUNTIME_init_manager', 'sysvinit', 'launcher-libseat', '', d)} \ + launcher-libseat \ image-jpeg \ screenshare \ shell-desktop \ @@ -71,7 +71,7 @@ PACKAGECONFIG[lcms] = "-Dcolor-management-lcms=true,-Dcolor-management-lcms=fals # Weston with webp support PACKAGECONFIG[webp] = "-Dimage-webp=true,-Dimage-webp=false,libwebp" # Weston with systemd-login support -PACKAGECONFIG[systemd] = "-Dsystemd=true -Dlauncher-logind=true,-Dsystemd=false -Dlauncher-logind=false,systemd dbus" +PACKAGECONFIG[systemd] = "-Dsystemd=true,-Dsystemd=false,systemd dbus" # Weston with Xwayland support (requires X11 and Wayland) PACKAGECONFIG[xwayland] = "-Dxwayland=true,-Dxwayland=false,libxcb libxcursor xwayland" # colord CMS support
Lets use the launcher-seatd as default, launcher-logind is "sometimes" failing to provide input events. Further more is the launcher-logind depricated in newer versions of weston. Signed-off-by: Sean Nyekjaer <sean@geanix.com> --- meta/recipes-graphics/wayland/weston_11.0.1.bb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)