From patchwork Mon Oct 16 11:22:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Schulz X-Patchwork-Id: 32369 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D1BCDB465 for ; Mon, 16 Oct 2023 11:22:49 +0000 (UTC) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by mx.groups.io with SMTP id smtpd.web11.118083.1697455366975499779 for ; Mon, 16 Oct 2023 04:22:47 -0700 Authentication-Results: mx.groups.io; dkim=none (message not signed); spf=none, err=permanent DNS error (domain: 0leil.net, ip: 217.70.183.196, mailfrom: foss+yocto@0leil.net) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3CA4EE0008; Mon, 16 Oct 2023 11:22:43 +0000 (UTC) From: Quentin Schulz To: twoerner@gmail.com Cc: yocto@lists.yoctoproject.org, Quentin Schulz , Quentin Schulz Subject: [meta-rockchip][kirkstone][PATCH] bsp: rkbin: fix default COMPATIBLE_MACHINE matching all Date: Mon, 16 Oct 2023 13:22:33 +0200 Message-ID: <20231016112233.221066-1-foss+yocto@0leil.net> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-GND-Sasl: foss@0leil.net List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 16 Oct 2023 11:22:49 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/yocto/message/61345 From: Quentin Schulz The goal of the default COMPATIBLE_MACHINE was to not allow rockchip-rkbin to be even parsed if a MACHINE isn't part of the COMPATIBLE_MACHINE. However, COMPATIBLE_MACHINE is a regexp checked using Python's re module approximately like: """ if re.match(COMPATIBLE_MACHINE, MACHINE): return True """ and re.match() returns a match whatever MACHINE is if COMPATIBLE_MACHINE is the empty string. Therefore, let's change it to `^$` which only matches the empty string, which shouldn't be possible for anything in MACHINEOVERRIDES, and if it is there are probably bigger problems than parsing rockchip-rkbin. Fixes: 3c7f532c2e25 ("rk3588(s): add") Cc: Quentin Schulz Signed-off-by: Quentin Schulz --- recipes-bsp/rkbin/rockchip-rkbin_git.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/recipes-bsp/rkbin/rockchip-rkbin_git.bb b/recipes-bsp/rkbin/rockchip-rkbin_git.bb index 7fefb01..f9e680d 100644 --- a/recipes-bsp/rkbin/rockchip-rkbin_git.bb +++ b/recipes-bsp/rkbin/rockchip-rkbin_git.bb @@ -12,7 +12,7 @@ inherit bin_package deploy S = "${WORKDIR}/git" -COMPATIBLE_MACHINE = "" +COMPATIBLE_MACHINE = "^$" COMPATIBLE_MACHINE:rk3588s = "rk3588s" PACKAGE_ARCH = "${MACHINE_ARCH}"