| Submitter | rongqing.li@windriver.com |
|---|---|
| Date | July 18, 2012, 2:15 a.m. |
| Message ID | <1342577756-11891-1-git-send-email-rongqing.li@windriver.com> |
| Download | mbox | patch |
| Permalink | /patch/32349/ |
| State | Accepted |
| Commit | 25745cf72056efc2250e8fdd99d6f30384472694 |
| Headers | show |
Comments
On 07/17/2012 07:15 PM, rongqing.li@windriver.com wrote: > From: Roy.Li <rongqing.li@windriver.com> > > Add description, Signed-off-by and Upstream-Status to > change-char-type-to-signed-char-in-macros.patch > > Signed-off-by: Roy.Li <rongqing.li@windriver.com> > --- > ...change-char-type-to-signed-char-in-macros.patch | 16 ++++++++++++++++ > 1 files changed, 16 insertions(+), 0 deletions(-) > > diff --git a/meta/recipes-extended/slang/slang/change-char-type-to-signed-char-in-macros.patch b/meta/recipes-extended/slang/slang/change-char-type-to-signed-char-in-macros.patch > index 18dea13..2ea1ffd 100644 > --- a/meta/recipes-extended/slang/slang/change-char-type-to-signed-char-in-macros.patch > +++ b/meta/recipes-extended/slang/slang/change-char-type-to-signed-char-in-macros.patch > @@ -1,3 +1,19 @@ > +slang: change char type to signed char in macros > + > +C language has 3 distinct char types: > + char > + unsigned char > + signed char > +A char has the same range of values as signed char on X86, > +but same as unsigned char on ARM which made Slang's typecast() > +and array_sort() unable to work for char value on ARM, since > +Slang is assuming "char" as "signed char". > + > +Now we change "char" as "signed char" explicitly in > +util/mkslarith2.sl, and use it to regenerate src/slarith2.inc > + > +Upstream-Status: Submitted > +Signed-off-by: Roy.Li <rongqing.li@windriver.com> > --- > src/slarith2.inc | 72 ++++++++++++++++++++++++------------------------- > src/util/mkslarith2.sl | 2 - > Merged into OE-Core Thanks Sau!
Patch
diff --git a/meta/recipes-extended/slang/slang/change-char-type-to-signed-char-in-macros.patch b/meta/recipes-extended/slang/slang/change-char-type-to-signed-char-in-macros.patch index 18dea13..2ea1ffd 100644 --- a/meta/recipes-extended/slang/slang/change-char-type-to-signed-char-in-macros.patch +++ b/meta/recipes-extended/slang/slang/change-char-type-to-signed-char-in-macros.patch @@ -1,3 +1,19 @@ +slang: change char type to signed char in macros + +C language has 3 distinct char types: + char + unsigned char + signed char +A char has the same range of values as signed char on X86, +but same as unsigned char on ARM which made Slang's typecast() +and array_sort() unable to work for char value on ARM, since +Slang is assuming "char" as "signed char". + +Now we change "char" as "signed char" explicitly in +util/mkslarith2.sl, and use it to regenerate src/slarith2.inc + +Upstream-Status: Submitted +Signed-off-by: Roy.Li <rongqing.li@windriver.com> --- src/slarith2.inc | 72 ++++++++++++++++++++++++------------------------- src/util/mkslarith2.sl | 2 -