| Submitter | Saul Wold |
|---|---|
| Date | July 16, 2012, 3:47 p.m. |
| Message ID | <d67e47bd457de90b19428245644dc64ecf4ba11a.1342453118.git.sgw@linux.intel.com> |
| Download | mbox | patch |
| Permalink | /patch/32127/ |
| State | New |
| Headers | show |
Comments
On Mon, Jul 16, 2012 at 11:47 AM, Saul Wold <sgw@linux.intel.com> wrote: > From: Bogdan Marinescu <bogdan.a.marinescu@intel.com> > > Tested by building core-image-sato-sdk. We've never gone to this level of granularity in the past, since -stable updates to the kernel are not going to change something in the libc-headers exports. As far as I'm concerned, bumping this for each stable release is too much churn. Sorry I missed this during the original review/posting. Cheers, Bruce > > Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com> > Signed-off-by: Saul Wold <sgw@linux.intel.com> > --- > meta/conf/distro/include/tcmode-default.inc | 2 +- > .../linux-libc-headers/linux-libc-headers_3.4.3.bb | 6 ++++++ > .../linux-libc-headers/linux-libc-headers_3.4.bb | 6 ------ > 3 files changed, 7 insertions(+), 7 deletions(-) > create mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > delete mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > > diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc > index f11e687..0a068be 100644 > --- a/meta/conf/distro/include/tcmode-default.inc > +++ b/meta/conf/distro/include/tcmode-default.inc > @@ -22,7 +22,7 @@ SDKGCCVERSION ?= "${GCCVERSION}" > BINUVERSION ?= "2.22" > EGLIBCVERSION ?= "2.15" > UCLIBCVERSION ?= "0.9.33" > -LINUXLIBCVERSION ?= "3.4" > +LINUXLIBCVERSION ?= "3.4.3" > > PREFERRED_VERSION_gcc ?= "${GCCVERSION}" > PREFERRED_VERSION_gcc-cross ?= "${GCCVERSION}" > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > new file mode 100644 > index 0000000..6f8d9e8 > --- /dev/null > +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > @@ -0,0 +1,6 @@ > +require linux-libc-headers.inc > + > +PR = "r0" > + > +SRC_URI[md5sum] = "3aefa02db55715d627ed23a01667057d" > +SRC_URI[sha256sum] = "17f1256daa289dde1a0a587c9753556d37a52770f7c4efcf2666fd4796a6eacc" > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > deleted file mode 100644 > index 9e8c88f..0000000 > --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > +++ /dev/null > @@ -1,6 +0,0 @@ > -require linux-libc-headers.inc > - > -PR = "r0" > - > -SRC_URI[md5sum] = "146af0160fc7a60cf9acf44aec13482b" > -SRC_URI[sha256sum] = "a797a15d0b6228381507c14ecf4eec4a6cc5c77cfd521ba3b3e1325e85b5b16d" > -- > 1.7.7.6 > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Mon, Jul 16, 2012 at 11:58:52AM -0400, Bruce Ashfield wrote: > On Mon, Jul 16, 2012 at 11:47 AM, Saul Wold <sgw@linux.intel.com> wrote: > > From: Bogdan Marinescu <bogdan.a.marinescu@intel.com> > > > > Tested by building core-image-sato-sdk. > > We've never gone to this level of granularity in the past, since > -stable updates to > the kernel are not going to change something in the libc-headers exports. > > As far as I'm concerned, bumping this for each stable release is too much churn. But this time it's quite usefull after http://git.openembedded.org/openembedded-core/commit/?id=2a4ab6fc2ef10202d13568aba5d7633e88aa71e5 removed some headers from sysroots and some packages (like IIRC udev) were failing to build until someone rebuilt linux-libc-headers manually to fixup staged headers in machine sysroot.. Cheers, > > Sorry I missed this during the original review/posting. > > Cheers, > > Bruce > > > > > Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com> > > Signed-off-by: Saul Wold <sgw@linux.intel.com> > > --- > > meta/conf/distro/include/tcmode-default.inc | 2 +- > > .../linux-libc-headers/linux-libc-headers_3.4.3.bb | 6 ++++++ > > .../linux-libc-headers/linux-libc-headers_3.4.bb | 6 ------ > > 3 files changed, 7 insertions(+), 7 deletions(-) > > create mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > > delete mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > > > > diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc > > index f11e687..0a068be 100644 > > --- a/meta/conf/distro/include/tcmode-default.inc > > +++ b/meta/conf/distro/include/tcmode-default.inc > > @@ -22,7 +22,7 @@ SDKGCCVERSION ?= "${GCCVERSION}" > > BINUVERSION ?= "2.22" > > EGLIBCVERSION ?= "2.15" > > UCLIBCVERSION ?= "0.9.33" > > -LINUXLIBCVERSION ?= "3.4" > > +LINUXLIBCVERSION ?= "3.4.3" > > > > PREFERRED_VERSION_gcc ?= "${GCCVERSION}" > > PREFERRED_VERSION_gcc-cross ?= "${GCCVERSION}" > > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > > new file mode 100644 > > index 0000000..6f8d9e8 > > --- /dev/null > > +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > > @@ -0,0 +1,6 @@ > > +require linux-libc-headers.inc > > + > > +PR = "r0" > > + > > +SRC_URI[md5sum] = "3aefa02db55715d627ed23a01667057d" > > +SRC_URI[sha256sum] = "17f1256daa289dde1a0a587c9753556d37a52770f7c4efcf2666fd4796a6eacc" > > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > > deleted file mode 100644 > > index 9e8c88f..0000000 > > --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > > +++ /dev/null > > @@ -1,6 +0,0 @@ > > -require linux-libc-headers.inc > > - > > -PR = "r0" > > - > > -SRC_URI[md5sum] = "146af0160fc7a60cf9acf44aec13482b" > > -SRC_URI[sha256sum] = "a797a15d0b6228381507c14ecf4eec4a6cc5c77cfd521ba3b3e1325e85b5b16d" > > -- > > 1.7.7.6 > > > > > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > > > -- > "Thou shalt not follow the NULL pointer, for chaos and madness await > thee at its end" > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Mon, Jul 16, 2012 at 12:04 PM, Martin Jansa <martin.jansa@gmail.com> wrote: > On Mon, Jul 16, 2012 at 11:58:52AM -0400, Bruce Ashfield wrote: >> On Mon, Jul 16, 2012 at 11:47 AM, Saul Wold <sgw@linux.intel.com> wrote: >> > From: Bogdan Marinescu <bogdan.a.marinescu@intel.com> >> > >> > Tested by building core-image-sato-sdk. >> >> We've never gone to this level of granularity in the past, since >> -stable updates to >> the kernel are not going to change something in the libc-headers exports. >> >> As far as I'm concerned, bumping this for each stable release is too much churn. > > But this time it's quite usefull after > http://git.openembedded.org/openembedded-core/commit/?id=2a4ab6fc2ef10202d13568aba5d7633e88aa71e5 > removed some headers from sysroots and some packages (like IIRC udev) > were failing to build until someone rebuilt linux-libc-headers manually > to fixup staged headers in machine sysroot.. I'm not following completely .. is that specific to the .3 in 3.4.x ? Doesn't look like it to me. I don't recall Greg changing the mtd exports in 3.4.3 .. but that wouldn't be the first time something like that slipped in. Cheers, Bruce > > Cheers, > >> >> Sorry I missed this during the original review/posting. >> >> Cheers, >> >> Bruce >> >> > >> > Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com> >> > Signed-off-by: Saul Wold <sgw@linux.intel.com> >> > --- >> > meta/conf/distro/include/tcmode-default.inc | 2 +- >> > .../linux-libc-headers/linux-libc-headers_3.4.3.bb | 6 ++++++ >> > .../linux-libc-headers/linux-libc-headers_3.4.bb | 6 ------ >> > 3 files changed, 7 insertions(+), 7 deletions(-) >> > create mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb >> > delete mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb >> > >> > diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc >> > index f11e687..0a068be 100644 >> > --- a/meta/conf/distro/include/tcmode-default.inc >> > +++ b/meta/conf/distro/include/tcmode-default.inc >> > @@ -22,7 +22,7 @@ SDKGCCVERSION ?= "${GCCVERSION}" >> > BINUVERSION ?= "2.22" >> > EGLIBCVERSION ?= "2.15" >> > UCLIBCVERSION ?= "0.9.33" >> > -LINUXLIBCVERSION ?= "3.4" >> > +LINUXLIBCVERSION ?= "3.4.3" >> > >> > PREFERRED_VERSION_gcc ?= "${GCCVERSION}" >> > PREFERRED_VERSION_gcc-cross ?= "${GCCVERSION}" >> > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb >> > new file mode 100644 >> > index 0000000..6f8d9e8 >> > --- /dev/null >> > +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb >> > @@ -0,0 +1,6 @@ >> > +require linux-libc-headers.inc >> > + >> > +PR = "r0" >> > + >> > +SRC_URI[md5sum] = "3aefa02db55715d627ed23a01667057d" >> > +SRC_URI[sha256sum] = "17f1256daa289dde1a0a587c9753556d37a52770f7c4efcf2666fd4796a6eacc" >> > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb >> > deleted file mode 100644 >> > index 9e8c88f..0000000 >> > --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb >> > +++ /dev/null >> > @@ -1,6 +0,0 @@ >> > -require linux-libc-headers.inc >> > - >> > -PR = "r0" >> > - >> > -SRC_URI[md5sum] = "146af0160fc7a60cf9acf44aec13482b" >> > -SRC_URI[sha256sum] = "a797a15d0b6228381507c14ecf4eec4a6cc5c77cfd521ba3b3e1325e85b5b16d" >> > -- >> > 1.7.7.6 >> > >> > >> > _______________________________________________ >> > Openembedded-core mailing list >> > Openembedded-core@lists.openembedded.org >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >> >> >> -- >> "Thou shalt not follow the NULL pointer, for chaos and madness await >> thee at its end" >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > -- > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
On Mon, Jul 16, 2012 at 12:08:10PM -0400, Bruce Ashfield wrote: > On Mon, Jul 16, 2012 at 12:04 PM, Martin Jansa <martin.jansa@gmail.com> wrote: > > On Mon, Jul 16, 2012 at 11:58:52AM -0400, Bruce Ashfield wrote: > >> On Mon, Jul 16, 2012 at 11:47 AM, Saul Wold <sgw@linux.intel.com> wrote: > >> > From: Bogdan Marinescu <bogdan.a.marinescu@intel.com> > >> > > >> > Tested by building core-image-sato-sdk. > >> > >> We've never gone to this level of granularity in the past, since > >> -stable updates to > >> the kernel are not going to change something in the libc-headers exports. > >> > >> As far as I'm concerned, bumping this for each stable release is too much churn. > > > > But this time it's quite usefull after > > http://git.openembedded.org/openembedded-core/commit/?id=2a4ab6fc2ef10202d13568aba5d7633e88aa71e5 > > removed some headers from sysroots and some packages (like IIRC udev) > > were failing to build until someone rebuilt linux-libc-headers manually > > to fixup staged headers in machine sysroot.. > > I'm not following completely .. is that specific to the .3 in 3.4.x ? > Doesn't look > like it to me. No it's not specific to any version.. just before referenced patch there was e.g. ubi-user.h in sysroot "owned" by linux-libc-headers and mtd-utils recipe. That patch caused mtd-utils to be rebuilt and restaged again, but this time without ubi-user.h and IMHO this doesn't track that ubi-user.h is also "owned by linux-libc-headers recipe so we end without any ubi-user.h in sysroot until someone rebuilds linux-libc-headers to stage ubi-user.h again. Staging the same file from different recipes should imho show some warning or keep track of all "owners" so ubi-user.h is not removed unless someone cleansstate both mtd-utils and linux-libc-headers. Cheers, > > I don't recall Greg changing the mtd exports in 3.4.3 .. but that > wouldn't be the > first time something like that slipped in. > > Cheers, > > Bruce > > > > > Cheers, > > > >> > >> Sorry I missed this during the original review/posting. > >> > >> Cheers, > >> > >> Bruce > >> > >> > > >> > Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com> > >> > Signed-off-by: Saul Wold <sgw@linux.intel.com> > >> > --- > >> > meta/conf/distro/include/tcmode-default.inc | 2 +- > >> > .../linux-libc-headers/linux-libc-headers_3.4.3.bb | 6 ++++++ > >> > .../linux-libc-headers/linux-libc-headers_3.4.bb | 6 ------ > >> > 3 files changed, 7 insertions(+), 7 deletions(-) > >> > create mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > >> > delete mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > >> > > >> > diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc > >> > index f11e687..0a068be 100644 > >> > --- a/meta/conf/distro/include/tcmode-default.inc > >> > +++ b/meta/conf/distro/include/tcmode-default.inc > >> > @@ -22,7 +22,7 @@ SDKGCCVERSION ?= "${GCCVERSION}" > >> > BINUVERSION ?= "2.22" > >> > EGLIBCVERSION ?= "2.15" > >> > UCLIBCVERSION ?= "0.9.33" > >> > -LINUXLIBCVERSION ?= "3.4" > >> > +LINUXLIBCVERSION ?= "3.4.3" > >> > > >> > PREFERRED_VERSION_gcc ?= "${GCCVERSION}" > >> > PREFERRED_VERSION_gcc-cross ?= "${GCCVERSION}" > >> > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > >> > new file mode 100644 > >> > index 0000000..6f8d9e8 > >> > --- /dev/null > >> > +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > >> > @@ -0,0 +1,6 @@ > >> > +require linux-libc-headers.inc > >> > + > >> > +PR = "r0" > >> > + > >> > +SRC_URI[md5sum] = "3aefa02db55715d627ed23a01667057d" > >> > +SRC_URI[sha256sum] = "17f1256daa289dde1a0a587c9753556d37a52770f7c4efcf2666fd4796a6eacc" > >> > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > >> > deleted file mode 100644 > >> > index 9e8c88f..0000000 > >> > --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > >> > +++ /dev/null > >> > @@ -1,6 +0,0 @@ > >> > -require linux-libc-headers.inc > >> > - > >> > -PR = "r0" > >> > - > >> > -SRC_URI[md5sum] = "146af0160fc7a60cf9acf44aec13482b" > >> > -SRC_URI[sha256sum] = "a797a15d0b6228381507c14ecf4eec4a6cc5c77cfd521ba3b3e1325e85b5b16d" > >> > -- > >> > 1.7.7.6 > >> > > >> > > >> > _______________________________________________ > >> > Openembedded-core mailing list > >> > Openembedded-core@lists.openembedded.org > >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > >> > >> > >> > >> -- > >> "Thou shalt not follow the NULL pointer, for chaos and madness await > >> thee at its end" > >> > >> _______________________________________________ > >> Openembedded-core mailing list > >> Openembedded-core@lists.openembedded.org > >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > > > -- > > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com > > > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > > > > > -- > "Thou shalt not follow the NULL pointer, for chaos and madness await > thee at its end" > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Mon, Jul 16, 2012 at 12:29 PM, Martin Jansa <martin.jansa@gmail.com> wrote: > On Mon, Jul 16, 2012 at 12:08:10PM -0400, Bruce Ashfield wrote: >> On Mon, Jul 16, 2012 at 12:04 PM, Martin Jansa <martin.jansa@gmail.com> wrote: >> > On Mon, Jul 16, 2012 at 11:58:52AM -0400, Bruce Ashfield wrote: >> >> On Mon, Jul 16, 2012 at 11:47 AM, Saul Wold <sgw@linux.intel.com> wrote: >> >> > From: Bogdan Marinescu <bogdan.a.marinescu@intel.com> >> >> > >> >> > Tested by building core-image-sato-sdk. >> >> >> >> We've never gone to this level of granularity in the past, since >> >> -stable updates to >> >> the kernel are not going to change something in the libc-headers exports. >> >> >> >> As far as I'm concerned, bumping this for each stable release is too much churn. >> > >> > But this time it's quite usefull after >> > http://git.openembedded.org/openembedded-core/commit/?id=2a4ab6fc2ef10202d13568aba5d7633e88aa71e5 >> > removed some headers from sysroots and some packages (like IIRC udev) >> > were failing to build until someone rebuilt linux-libc-headers manually >> > to fixup staged headers in machine sysroot.. >> >> I'm not following completely .. is that specific to the .3 in 3.4.x ? >> Doesn't look >> like it to me. > > No it's not specific to any version.. just before referenced patch there > was e.g. ubi-user.h in sysroot "owned" by linux-libc-headers and > mtd-utils recipe. > > That patch caused mtd-utils to be rebuilt and restaged again, but this > time without ubi-user.h and IMHO this doesn't track that ubi-user.h > is also "owned by linux-libc-headers recipe so we end without any > ubi-user.h in sysroot until someone rebuilds linux-libc-headers to stage > ubi-user.h again. > > Staging the same file from different recipes should imho show some > warning or keep track of all "owners" so ubi-user.h is not removed > unless someone cleansstate both mtd-utils and linux-libc-headers. ok .. this is what I thought you meant. I'm not a packaging expert by any stretch of the imagination, but I assume that someone bumping the PR or PE of the libc-headers package but leaving it on 3.4 would have also fixed this to not require manual intervention ? Cheers, Bruce > > Cheers, > >> >> I don't recall Greg changing the mtd exports in 3.4.3 .. but that >> wouldn't be the >> first time something like that slipped in. >> >> Cheers, >> >> Bruce >> >> > >> > Cheers, >> > >> >> >> >> Sorry I missed this during the original review/posting. >> >> >> >> Cheers, >> >> >> >> Bruce >> >> >> >> > >> >> > Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com> >> >> > Signed-off-by: Saul Wold <sgw@linux.intel.com> >> >> > --- >> >> > meta/conf/distro/include/tcmode-default.inc | 2 +- >> >> > .../linux-libc-headers/linux-libc-headers_3.4.3.bb | 6 ++++++ >> >> > .../linux-libc-headers/linux-libc-headers_3.4.bb | 6 ------ >> >> > 3 files changed, 7 insertions(+), 7 deletions(-) >> >> > create mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb >> >> > delete mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb >> >> > >> >> > diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc >> >> > index f11e687..0a068be 100644 >> >> > --- a/meta/conf/distro/include/tcmode-default.inc >> >> > +++ b/meta/conf/distro/include/tcmode-default.inc >> >> > @@ -22,7 +22,7 @@ SDKGCCVERSION ?= "${GCCVERSION}" >> >> > BINUVERSION ?= "2.22" >> >> > EGLIBCVERSION ?= "2.15" >> >> > UCLIBCVERSION ?= "0.9.33" >> >> > -LINUXLIBCVERSION ?= "3.4" >> >> > +LINUXLIBCVERSION ?= "3.4.3" >> >> > >> >> > PREFERRED_VERSION_gcc ?= "${GCCVERSION}" >> >> > PREFERRED_VERSION_gcc-cross ?= "${GCCVERSION}" >> >> > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb >> >> > new file mode 100644 >> >> > index 0000000..6f8d9e8 >> >> > --- /dev/null >> >> > +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb >> >> > @@ -0,0 +1,6 @@ >> >> > +require linux-libc-headers.inc >> >> > + >> >> > +PR = "r0" >> >> > + >> >> > +SRC_URI[md5sum] = "3aefa02db55715d627ed23a01667057d" >> >> > +SRC_URI[sha256sum] = "17f1256daa289dde1a0a587c9753556d37a52770f7c4efcf2666fd4796a6eacc" >> >> > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb >> >> > deleted file mode 100644 >> >> > index 9e8c88f..0000000 >> >> > --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb >> >> > +++ /dev/null >> >> > @@ -1,6 +0,0 @@ >> >> > -require linux-libc-headers.inc >> >> > - >> >> > -PR = "r0" >> >> > - >> >> > -SRC_URI[md5sum] = "146af0160fc7a60cf9acf44aec13482b" >> >> > -SRC_URI[sha256sum] = "a797a15d0b6228381507c14ecf4eec4a6cc5c77cfd521ba3b3e1325e85b5b16d" >> >> > -- >> >> > 1.7.7.6 >> >> > >> >> > >> >> > _______________________________________________ >> >> > Openembedded-core mailing list >> >> > Openembedded-core@lists.openembedded.org >> >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >> >> >> >> >> >> >> -- >> >> "Thou shalt not follow the NULL pointer, for chaos and madness await >> >> thee at its end" >> >> >> >> _______________________________________________ >> >> Openembedded-core mailing list >> >> Openembedded-core@lists.openembedded.org >> >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> > >> > -- >> > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com >> > >> > _______________________________________________ >> > Openembedded-core mailing list >> > Openembedded-core@lists.openembedded.org >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> > >> >> >> >> -- >> "Thou shalt not follow the NULL pointer, for chaos and madness await >> thee at its end" >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > -- > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
On Mon, Jul 16, 2012 at 12:36:07PM -0400, Bruce Ashfield wrote: > On Mon, Jul 16, 2012 at 12:29 PM, Martin Jansa <martin.jansa@gmail.com> wrote: > > On Mon, Jul 16, 2012 at 12:08:10PM -0400, Bruce Ashfield wrote: > >> On Mon, Jul 16, 2012 at 12:04 PM, Martin Jansa <martin.jansa@gmail.com> wrote: > >> > On Mon, Jul 16, 2012 at 11:58:52AM -0400, Bruce Ashfield wrote: > >> >> On Mon, Jul 16, 2012 at 11:47 AM, Saul Wold <sgw@linux.intel.com> wrote: > >> >> > From: Bogdan Marinescu <bogdan.a.marinescu@intel.com> > >> >> > > >> >> > Tested by building core-image-sato-sdk. > >> >> > >> >> We've never gone to this level of granularity in the past, since > >> >> -stable updates to > >> >> the kernel are not going to change something in the libc-headers exports. > >> >> > >> >> As far as I'm concerned, bumping this for each stable release is too much churn. > >> > > >> > But this time it's quite usefull after > >> > http://git.openembedded.org/openembedded-core/commit/?id=2a4ab6fc2ef10202d13568aba5d7633e88aa71e5 > >> > removed some headers from sysroots and some packages (like IIRC udev) > >> > were failing to build until someone rebuilt linux-libc-headers manually > >> > to fixup staged headers in machine sysroot.. > >> > >> I'm not following completely .. is that specific to the .3 in 3.4.x ? > >> Doesn't look > >> like it to me. > > > > No it's not specific to any version.. just before referenced patch there > > was e.g. ubi-user.h in sysroot "owned" by linux-libc-headers and > > mtd-utils recipe. > > > > That patch caused mtd-utils to be rebuilt and restaged again, but this > > time without ubi-user.h and IMHO this doesn't track that ubi-user.h > > is also "owned by linux-libc-headers recipe so we end without any > > ubi-user.h in sysroot until someone rebuilds linux-libc-headers to stage > > ubi-user.h again. > > > > Staging the same file from different recipes should imho show some > > warning or keep track of all "owners" so ubi-user.h is not removed > > unless someone cleansstate both mtd-utils and linux-libc-headers. > > ok .. this is what I thought you meant. I'm not a packaging expert by any > stretch of the imagination, but I assume that someone bumping the PR or > PE of the libc-headers package but leaving it on 3.4 would have also fixed > this to not require manual intervention ? yes.. I was thinking about sending PR bump patch after I've rebuilt it manually for all machines on both my builders.. but then noticed this patch and decided to wait for this instead of just PR bump.. Cheers, > > Cheers, > > Bruce > > > > > Cheers, > > > >> > >> I don't recall Greg changing the mtd exports in 3.4.3 .. but that > >> wouldn't be the > >> first time something like that slipped in. > >> > >> Cheers, > >> > >> Bruce > >> > >> > > >> > Cheers, > >> > > >> >> > >> >> Sorry I missed this during the original review/posting. > >> >> > >> >> Cheers, > >> >> > >> >> Bruce > >> >> > >> >> > > >> >> > Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com> > >> >> > Signed-off-by: Saul Wold <sgw@linux.intel.com> > >> >> > --- > >> >> > meta/conf/distro/include/tcmode-default.inc | 2 +- > >> >> > .../linux-libc-headers/linux-libc-headers_3.4.3.bb | 6 ++++++ > >> >> > .../linux-libc-headers/linux-libc-headers_3.4.bb | 6 ------ > >> >> > 3 files changed, 7 insertions(+), 7 deletions(-) > >> >> > create mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > >> >> > delete mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > >> >> > > >> >> > diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc > >> >> > index f11e687..0a068be 100644 > >> >> > --- a/meta/conf/distro/include/tcmode-default.inc > >> >> > +++ b/meta/conf/distro/include/tcmode-default.inc > >> >> > @@ -22,7 +22,7 @@ SDKGCCVERSION ?= "${GCCVERSION}" > >> >> > BINUVERSION ?= "2.22" > >> >> > EGLIBCVERSION ?= "2.15" > >> >> > UCLIBCVERSION ?= "0.9.33" > >> >> > -LINUXLIBCVERSION ?= "3.4" > >> >> > +LINUXLIBCVERSION ?= "3.4.3" > >> >> > > >> >> > PREFERRED_VERSION_gcc ?= "${GCCVERSION}" > >> >> > PREFERRED_VERSION_gcc-cross ?= "${GCCVERSION}" > >> >> > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > >> >> > new file mode 100644 > >> >> > index 0000000..6f8d9e8 > >> >> > --- /dev/null > >> >> > +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb > >> >> > @@ -0,0 +1,6 @@ > >> >> > +require linux-libc-headers.inc > >> >> > + > >> >> > +PR = "r0" > >> >> > + > >> >> > +SRC_URI[md5sum] = "3aefa02db55715d627ed23a01667057d" > >> >> > +SRC_URI[sha256sum] = "17f1256daa289dde1a0a587c9753556d37a52770f7c4efcf2666fd4796a6eacc" > >> >> > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > >> >> > deleted file mode 100644 > >> >> > index 9e8c88f..0000000 > >> >> > --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb > >> >> > +++ /dev/null > >> >> > @@ -1,6 +0,0 @@ > >> >> > -require linux-libc-headers.inc > >> >> > - > >> >> > -PR = "r0" > >> >> > - > >> >> > -SRC_URI[md5sum] = "146af0160fc7a60cf9acf44aec13482b" > >> >> > -SRC_URI[sha256sum] = "a797a15d0b6228381507c14ecf4eec4a6cc5c77cfd521ba3b3e1325e85b5b16d" > >> >> > -- > >> >> > 1.7.7.6 > >> >> > > >> >> > > >> >> > _______________________________________________ > >> >> > Openembedded-core mailing list > >> >> > Openembedded-core@lists.openembedded.org > >> >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > >> >> > >> >> > >> >> > >> >> -- > >> >> "Thou shalt not follow the NULL pointer, for chaos and madness await > >> >> thee at its end" > >> >> > >> >> _______________________________________________ > >> >> Openembedded-core mailing list > >> >> Openembedded-core@lists.openembedded.org > >> >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > >> > > >> > -- > >> > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com > >> > > >> > _______________________________________________ > >> > Openembedded-core mailing list > >> > Openembedded-core@lists.openembedded.org > >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > >> > > >> > >> > >> > >> -- > >> "Thou shalt not follow the NULL pointer, for chaos and madness await > >> thee at its end" > >> > >> _______________________________________________ > >> Openembedded-core mailing list > >> Openembedded-core@lists.openembedded.org > >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > > > -- > > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com > > > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > > > > > -- > "Thou shalt not follow the NULL pointer, for chaos and madness await > thee at its end" > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Mon, Jul 16, 2012 at 12:38 PM, Martin Jansa <martin.jansa@gmail.com> wrote: > On Mon, Jul 16, 2012 at 12:36:07PM -0400, Bruce Ashfield wrote: >> On Mon, Jul 16, 2012 at 12:29 PM, Martin Jansa <martin.jansa@gmail.com> wrote: >> > On Mon, Jul 16, 2012 at 12:08:10PM -0400, Bruce Ashfield wrote: >> >> On Mon, Jul 16, 2012 at 12:04 PM, Martin Jansa <martin.jansa@gmail.com> wrote: >> >> > On Mon, Jul 16, 2012 at 11:58:52AM -0400, Bruce Ashfield wrote: >> >> >> On Mon, Jul 16, 2012 at 11:47 AM, Saul Wold <sgw@linux.intel.com> wrote: >> >> >> > From: Bogdan Marinescu <bogdan.a.marinescu@intel.com> >> >> >> > >> >> >> > Tested by building core-image-sato-sdk. >> >> >> >> >> >> We've never gone to this level of granularity in the past, since >> >> >> -stable updates to >> >> >> the kernel are not going to change something in the libc-headers exports. >> >> >> >> >> >> As far as I'm concerned, bumping this for each stable release is too much churn. >> >> > >> >> > But this time it's quite usefull after >> >> > http://git.openembedded.org/openembedded-core/commit/?id=2a4ab6fc2ef10202d13568aba5d7633e88aa71e5 >> >> > removed some headers from sysroots and some packages (like IIRC udev) >> >> > were failing to build until someone rebuilt linux-libc-headers manually >> >> > to fixup staged headers in machine sysroot.. >> >> >> >> I'm not following completely .. is that specific to the .3 in 3.4.x ? >> >> Doesn't look >> >> like it to me. >> > >> > No it's not specific to any version.. just before referenced patch there >> > was e.g. ubi-user.h in sysroot "owned" by linux-libc-headers and >> > mtd-utils recipe. >> > >> > That patch caused mtd-utils to be rebuilt and restaged again, but this >> > time without ubi-user.h and IMHO this doesn't track that ubi-user.h >> > is also "owned by linux-libc-headers recipe so we end without any >> > ubi-user.h in sysroot until someone rebuilds linux-libc-headers to stage >> > ubi-user.h again. >> > >> > Staging the same file from different recipes should imho show some >> > warning or keep track of all "owners" so ubi-user.h is not removed >> > unless someone cleansstate both mtd-utils and linux-libc-headers. >> >> ok .. this is what I thought you meant. I'm not a packaging expert by any >> stretch of the imagination, but I assume that someone bumping the PR or >> PE of the libc-headers package but leaving it on 3.4 would have also fixed >> this to not require manual intervention ? > > yes.. I was thinking about sending PR bump patch after I've rebuilt it > manually for all machines on both my builders.. but then noticed this patch > and decided to wait for this instead of just PR bump.. Great, so I did properly understand this :) My comment about the churning of the headers for every -stable update still stands (and the fact that the 3.4 is at 3.4.4+ anyway), but as does your comment about something needing to be done to solve the mtd-headers issue. If this is dropped, then we obviously do need that PR bump. I'm not adamantly against this, but inconsistently picking -stable updates for libc-header refreshes (and only doing it for one, but not all of the kernel versions that are in oe-core) .. poses a completely different question and problem. Cheers, Bruce > > Cheers, > >> >> Cheers, >> >> Bruce >> >> > >> > Cheers, >> > >> >> >> >> I don't recall Greg changing the mtd exports in 3.4.3 .. but that >> >> wouldn't be the >> >> first time something like that slipped in. >> >> >> >> Cheers, >> >> >> >> Bruce >> >> >> >> > >> >> > Cheers, >> >> > >> >> >> >> >> >> Sorry I missed this during the original review/posting. >> >> >> >> >> >> Cheers, >> >> >> >> >> >> Bruce >> >> >> >> >> >> > >> >> >> > Signed-off-by: Bogdan Marinescu <bogdan.a.marinescu@intel.com> >> >> >> > Signed-off-by: Saul Wold <sgw@linux.intel.com> >> >> >> > --- >> >> >> > meta/conf/distro/include/tcmode-default.inc | 2 +- >> >> >> > .../linux-libc-headers/linux-libc-headers_3.4.3.bb | 6 ++++++ >> >> >> > .../linux-libc-headers/linux-libc-headers_3.4.bb | 6 ------ >> >> >> > 3 files changed, 7 insertions(+), 7 deletions(-) >> >> >> > create mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb >> >> >> > delete mode 100644 meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb >> >> >> > >> >> >> > diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc >> >> >> > index f11e687..0a068be 100644 >> >> >> > --- a/meta/conf/distro/include/tcmode-default.inc >> >> >> > +++ b/meta/conf/distro/include/tcmode-default.inc >> >> >> > @@ -22,7 +22,7 @@ SDKGCCVERSION ?= "${GCCVERSION}" >> >> >> > BINUVERSION ?= "2.22" >> >> >> > EGLIBCVERSION ?= "2.15" >> >> >> > UCLIBCVERSION ?= "0.9.33" >> >> >> > -LINUXLIBCVERSION ?= "3.4" >> >> >> > +LINUXLIBCVERSION ?= "3.4.3" >> >> >> > >> >> >> > PREFERRED_VERSION_gcc ?= "${GCCVERSION}" >> >> >> > PREFERRED_VERSION_gcc-cross ?= "${GCCVERSION}" >> >> >> > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb >> >> >> > new file mode 100644 >> >> >> > index 0000000..6f8d9e8 >> >> >> > --- /dev/null >> >> >> > +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb >> >> >> > @@ -0,0 +1,6 @@ >> >> >> > +require linux-libc-headers.inc >> >> >> > + >> >> >> > +PR = "r0" >> >> >> > + >> >> >> > +SRC_URI[md5sum] = "3aefa02db55715d627ed23a01667057d" >> >> >> > +SRC_URI[sha256sum] = "17f1256daa289dde1a0a587c9753556d37a52770f7c4efcf2666fd4796a6eacc" >> >> >> > diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb >> >> >> > deleted file mode 100644 >> >> >> > index 9e8c88f..0000000 >> >> >> > --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb >> >> >> > +++ /dev/null >> >> >> > @@ -1,6 +0,0 @@ >> >> >> > -require linux-libc-headers.inc >> >> >> > - >> >> >> > -PR = "r0" >> >> >> > - >> >> >> > -SRC_URI[md5sum] = "146af0160fc7a60cf9acf44aec13482b" >> >> >> > -SRC_URI[sha256sum] = "a797a15d0b6228381507c14ecf4eec4a6cc5c77cfd521ba3b3e1325e85b5b16d" >> >> >> > -- >> >> >> > 1.7.7.6 >> >> >> > >> >> >> > >> >> >> > _______________________________________________ >> >> >> > Openembedded-core mailing list >> >> >> > Openembedded-core@lists.openembedded.org >> >> >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >> >> >> >> >> >> >> >> >> >> >> -- >> >> >> "Thou shalt not follow the NULL pointer, for chaos and madness await >> >> >> thee at its end" >> >> >> >> >> >> _______________________________________________ >> >> >> Openembedded-core mailing list >> >> >> Openembedded-core@lists.openembedded.org >> >> >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >> > >> >> > -- >> >> > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com >> >> > >> >> > _______________________________________________ >> >> > Openembedded-core mailing list >> >> > Openembedded-core@lists.openembedded.org >> >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >> > >> >> >> >> >> >> >> >> -- >> >> "Thou shalt not follow the NULL pointer, for chaos and madness await >> >> thee at its end" >> >> >> >> _______________________________________________ >> >> Openembedded-core mailing list >> >> Openembedded-core@lists.openembedded.org >> >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> > >> > -- >> > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com >> > >> > _______________________________________________ >> > Openembedded-core mailing list >> > Openembedded-core@lists.openembedded.org >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> > >> >> >> >> -- >> "Thou shalt not follow the NULL pointer, for chaos and madness await >> thee at its end" >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > -- > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
Patch
diff --git a/meta/conf/distro/include/tcmode-default.inc b/meta/conf/distro/include/tcmode-default.inc index f11e687..0a068be 100644 --- a/meta/conf/distro/include/tcmode-default.inc +++ b/meta/conf/distro/include/tcmode-default.inc @@ -22,7 +22,7 @@ SDKGCCVERSION ?= "${GCCVERSION}" BINUVERSION ?= "2.22" EGLIBCVERSION ?= "2.15" UCLIBCVERSION ?= "0.9.33" -LINUXLIBCVERSION ?= "3.4" +LINUXLIBCVERSION ?= "3.4.3" PREFERRED_VERSION_gcc ?= "${GCCVERSION}" PREFERRED_VERSION_gcc-cross ?= "${GCCVERSION}" diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb new file mode 100644 index 0000000..6f8d9e8 --- /dev/null +++ b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.3.bb @@ -0,0 +1,6 @@ +require linux-libc-headers.inc + +PR = "r0" + +SRC_URI[md5sum] = "3aefa02db55715d627ed23a01667057d" +SRC_URI[sha256sum] = "17f1256daa289dde1a0a587c9753556d37a52770f7c4efcf2666fd4796a6eacc" diff --git a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb b/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb deleted file mode 100644 index 9e8c88f..0000000 --- a/meta/recipes-kernel/linux-libc-headers/linux-libc-headers_3.4.bb +++ /dev/null @@ -1,6 +0,0 @@ -require linux-libc-headers.inc - -PR = "r0" - -SRC_URI[md5sum] = "146af0160fc7a60cf9acf44aec13482b" -SRC_URI[sha256sum] = "a797a15d0b6228381507c14ecf4eec4a6cc5c77cfd521ba3b3e1325e85b5b16d"