From patchwork Sun Jul 15 20:55:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: kernel-yocto.bbclass: Delete superfluous creation of ${S}/.git directory Date: Sun, 15 Jul 2012 20:55:05 -0000 From: Robert P. J. Day X-Patchwork-Id: 32079 Message-Id: To: OE Core mailing list In do_kernel_checkout(), replace the creation of ${S}/.git with just the creation of ${S} since the .git subdirectory is created only a few lines later using a "mv". Here's the original code: rm -rf ${S} mkdir -p ${S}/.git echo "WARNING. ${WORKDIR}/git is not a bare clone." echo "Ensure that the SRC_URI includes the 'bareclone=1' option." # we can fix up the kernel repository, but at the least the meta # branch must be present. The machine branch may be created later. mv ${WORKDIR}/git/.git ${S} <-- See? There it is. There's no functional change here, it's just less confusing. Signed-off-by: Robert P. J. Day --- yes, i realize this doesn't change anything, but it's potentially confusing for the code to explicitly create ${S}/.git, shortly before it whomps over top of that directory anyway. i spent a couple minutes puzzling over the above trying to figure out if there was something subtle happening i didn't understand. rday diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass index 48c8974..8e010e0 100644 --- a/meta/classes/kernel-yocto.bbclass +++ b/meta/classes/kernel-yocto.bbclass @@ -106,7 +106,7 @@ do_kernel_checkout() { if [ -d "${WORKDIR}/git/" ] && [ -d "${WORKDIR}/git/.git" ]; then # we build out of {S}, so ensure that ${S} is clean and present rm -rf ${S} - mkdir -p ${S}/.git + mkdir -p ${S} echo "WARNING. ${WORKDIR}/git is not a bare clone." echo "Ensure that the SRC_URI includes the 'bareclone=1' option."