| Submitter | Matthew McClintock |
|---|---|
| Date | July 13, 2012, 8:06 p.m. |
| Message ID | <1342210017-26817-1-git-send-email-msm@freescale.com> |
| Download | mbox | patch |
| Permalink | /patch/32057/ |
| State | Accepted |
| Commit | c7beda1b779ce189c614fcce13e9ccf2c1b4ca6c |
| Headers | show |
Comments
On Fri, Jul 13, 2012 at 1:06 PM, Matthew McClintock <msm@freescale.com> wrote: > This prevents kexec from building for this part since it does not work > > Signed-off-by: Matthew McClintock <msm@freescale.com> > --- > meta/recipes-core/tasks/task-core-tools-testapps.bb | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/meta/recipes-core/tasks/task-core-tools-testapps.bb b/meta/recipes-core/tasks/task-core-tools-testapps.bb > index b5847f8..bdd0d05 100644 > --- a/meta/recipes-core/tasks/task-core-tools-testapps.bb > +++ b/meta/recipes-core/tasks/task-core-tools-testapps.bb > @@ -22,6 +22,7 @@ KEXECTOOLS ?= "kexec" > KEXECTOOLS_mips ?= "" > KEXECTOOLS_mipsel ?= "" > KEXECTOOLS_powerpc ?= "" > +KEXECTOOLS_e5500-64b ?= "" you should use arch override here this is not machine specific recipe probably KEXECTOOLS_powerpc64 ?= "" is better > > RDEPENDS_${PN} = "\ > blktool \ > -- > 1.7.10 > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Fri, Jul 13, 2012 at 3:43 PM, Khem Raj <raj.khem@gmail.com> wrote: > On Fri, Jul 13, 2012 at 1:06 PM, Matthew McClintock <msm@freescale.com> wrote: >> This prevents kexec from building for this part since it does not work >> >> Signed-off-by: Matthew McClintock <msm@freescale.com> >> --- >> meta/recipes-core/tasks/task-core-tools-testapps.bb | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/meta/recipes-core/tasks/task-core-tools-testapps.bb b/meta/recipes-core/tasks/task-core-tools-testapps.bb >> index b5847f8..bdd0d05 100644 >> --- a/meta/recipes-core/tasks/task-core-tools-testapps.bb >> +++ b/meta/recipes-core/tasks/task-core-tools-testapps.bb >> @@ -22,6 +22,7 @@ KEXECTOOLS ?= "kexec" >> KEXECTOOLS_mips ?= "" >> KEXECTOOLS_mipsel ?= "" >> KEXECTOOLS_powerpc ?= "" >> +KEXECTOOLS_e5500-64b ?= "" > > you should use arch override here this is not machine specific recipe probably > > KEXECTOOLS_powerpc64 ?= "" > > is better I thought about that at first, but there are plenty of powerpc64 machines that do support kexec ;) It's really just the Freescale variant. -M > >> >> RDEPENDS_${PN} = "\ >> blktool \ >> -- >> 1.7.10 >> >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
On Friday, July 13, 2012, McClintock Matthew-B29882 <B29882@freescale.com> wrote: > On Fri, Jul 13, 2012 at 3:43 PM, Khem Raj <raj.khem@gmail.com> wrote: >> On Fri, Jul 13, 2012 at 1:06 PM, Matthew McClintock <msm@freescale.com> wrote: >>> This prevents kexec from building for this part since it does not work >>> >>> Signed-off-by: Matthew McClintock <msm@freescale.com> >>> --- >>> meta/recipes-core/tasks/task-core-tools-testapps.bb | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/meta/recipes-core/tasks/task-core-tools-testapps.bbb/meta/recipes-core/tasks/ task-core-tools-testapps.bb >>> index b5847f8..bdd0d05 100644 >>> --- a/meta/recipes-core/tasks/task-core-tools-testapps.bb >>> +++ b/meta/recipes-core/tasks/task-core-tools-testapps.bb >>> @@ -22,6 +22,7 @@ KEXECTOOLS ?= "kexec" >>> KEXECTOOLS_mips ?= "" >>> KEXECTOOLS_mipsel ?= "" >>> KEXECTOOLS_powerpc ?= "" >>> +KEXECTOOLS_e5500-64b ?= "" >> >> you should use arch override here this is not machine specific recipe probably >> >> KEXECTOOLS_powerpc64 ?= "" >> >> is better > > I thought about that at first, but there are plenty of powerpc64 > machines that do support kexec ;) It's really just the Freescale > variant. OK I see I thought PowerPC 32 bit is ignored already so chances of 64 bit working are even less but as you say it works on some of them so be it > > -M > >> >>> >>> RDEPENDS_${PN} = "\ >>> blktool \ >>> -- >>> 1.7.10 >>> >>> >>> >>> _______________________________________________ >>> Openembedded-core mailing list >>> Openembedded-core@lists.openembedded.org >>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
On Jul 13, 2012 6:24 PM, "Khem Raj" <raj.khem@gmail.com<mailto:raj.khem@gmail.com>> wrote: > > > > On Friday, July 13, 2012, McClintock Matthew-B29882 <B29882@freescale.com<mailto:B29882@freescale.com>> wrote: > > On Fri, Jul 13, 2012 at 3:43 PM, Khem Raj <raj.khem@gmail.com<mailto:raj.khem@gmail.com>> wrote: > >> On Fri, Jul 13, 2012 at 1:06 PM, Matthew McClintock <msm@freescale.com<mailto:msm@freescale.com>> wrote: > >>> This prevents kexec from building for this part since it does not work > >>> > >>> Signed-off-by: Matthew McClintock <msm@freescale.com<mailto:msm@freescale.com>> > >>> --- > >>> meta/recipes-core/tasks/task-core-tools-testapps.bb<http://task-core-tools-testapps.bb> | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/meta/recipes-core/tasks/task-core-tools-testapps.bb<http://task-core-tools-testapps.bb> b/meta/recipes-core/tasks/task-core-tools-testapps.bb<http://task-core-tools-testapps.bb> > >>> index b5847f8..bdd0d05 100644 > >>> --- a/meta/recipes-core/tasks/task-core-tools-testapps.bb<http://task-core-tools-testapps.bb> > >>> +++ b/meta/recipes-core/tasks/task-core-tools-testapps.bb<http://task-core-tools-testapps.bb> > >>> @@ -22,6 +22,7 @@ KEXECTOOLS ?= "kexec" > >>> KEXECTOOLS_mips ?= "" > >>> KEXECTOOLS_mipsel ?= "" > >>> KEXECTOOLS_powerpc ?= "" > >>> +KEXECTOOLS_e5500-64b ?= "" > >> > >> you should use arch override here this is not machine specific recipe probably > >> > >> KEXECTOOLS_powerpc64 ?= "" > >> > >> is better > > > > I thought about that at first, but there are plenty of powerpc64 > > machines that do support kexec ;) It's really just the Freescale > > variant. > > OK I see I thought PowerPC 32 bit is ignored already so chances of 64 bit working are even less but as you say it works on some of them so be it Actually some freescale 32 bits parts work with kexec as I did some of that enablement. I just need to test it out and change the other line. -M > > > > > -M > > > >> > >>> > >>> RDEPENDS_${PN} = "\ > >>> blktool \ > >>> -- > >>> 1.7.10 > >>> > >>> > >>> > >>> _______________________________________________ > >>> Openembedded-core mailing list > >>> Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org> > >>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > >> > >> _______________________________________________ > >> Openembedded-core mailing list > >> Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org> > >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > > > _______________________________________________ > > Openembedded-core mailing list > > Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org> > > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org<mailto:Openembedded-core@lists.openembedded.org> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >
On Friday, July 13, 2012, McClintock Matthew-B29882 <B29882@freescale.com> wrote: > > On Jul 13, 2012 6:24 PM, "Khem Raj" <raj.khem@gmail.com> wrote: >> >> >> >> On Friday, July 13, 2012, McClintock Matthew-B29882 <B29882@freescale.com> wrote: >> > On Fri, Jul 13, 2012 at 3:43 PM, Khem Raj <raj.khem@gmail.com> wrote: >> >> On Fri, Jul 13, 2012 at 1:06 PM, Matthew McClintock <msm@freescale.com> wrote: >> >>> This prevents kexec from building for this part since it does not work >> >>> >> >>> Signed-off-by: Matthew McClintock <msm@freescale.com> >> >>> --- >> >>> meta/recipes-core/tasks/task-core-tools-testapps.bb | 1 + >> >>> 1 file changed, 1 insertion(+) >> >>> >> >>> diff --git a/meta/recipes-core/tasks/task-core-tools-testapps.bbb/meta/recipes-core/tasks/ task-core-tools-testapps.bb >> >>> index b5847f8..bdd0d05 100644 >> >>> --- a/meta/recipes-core/tasks/task-core-tools-testapps.bb >> >>> +++ b/meta/recipes-core/tasks/task-core-tools-testapps.bb >> >>> @@ -22,6 +22,7 @@ KEXECTOOLS ?= "kexec" >> >>> KEXECTOOLS_mips ?= "" >> >>> KEXECTOOLS_mipsel ?= "" >> >>> KEXECTOOLS_powerpc ?= "" >> >>> +KEXECTOOLS_e5500-64b ?= "" >> >> >> >> you should use arch override here this is not machine specific recipe probably >> >> >> >> KEXECTOOLS_powerpc64 ?= "" >> >> >> >> is better >> > >> > I thought about that at first, but there are plenty of powerpc64 >> > machines that do support kexec ;) It's really just the Freescale >> > variant. >> >> OK I see I thought PowerPC 32 bit is ignored already so chances of 64 bit working are even less but as you say it works on some of them so be it > > Actually some freescale 32 bits parts work with kexec as I did some of that enablement. I just need to test it out and change the other line. So will ppc64 get fixed some time soon ? > > -M > >> >> > >> > -M >> > >> >> >> >>> >> >>> RDEPENDS_${PN} = "\ >> >>> blktool \ >> >>> -- >> >>> 1.7.10 >> >>> >> >>> >> >>> >> >>> _______________________________________________ >> >>> Openembedded-core mailing list >> >>> Openembedded-core@lists.openembedded.org >> >>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >> >> >> _______________________________________________ >> >> Openembedded-core mailing list >> >> Openembedded-core@lists.openembedded.org >> >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> > >> > _______________________________________________ >> > Openembedded-core mailing list >> > Openembedded-core@lists.openembedded.org >> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> > >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core >> >
Patch
diff --git a/meta/recipes-core/tasks/task-core-tools-testapps.bb b/meta/recipes-core/tasks/task-core-tools-testapps.bb index b5847f8..bdd0d05 100644 --- a/meta/recipes-core/tasks/task-core-tools-testapps.bb +++ b/meta/recipes-core/tasks/task-core-tools-testapps.bb @@ -22,6 +22,7 @@ KEXECTOOLS ?= "kexec" KEXECTOOLS_mips ?= "" KEXECTOOLS_mipsel ?= "" KEXECTOOLS_powerpc ?= "" +KEXECTOOLS_e5500-64b ?= "" RDEPENDS_${PN} = "\ blktool \
This prevents kexec from building for this part since it does not work Signed-off-by: Matthew McClintock <msm@freescale.com> --- meta/recipes-core/tasks/task-core-tools-testapps.bb | 1 + 1 file changed, 1 insertion(+)