Patchwork gcc-package-runtime.inc: Fix QA warning

login
mail settings
Submitter Matthew McClintock
Date July 13, 2012, 6:36 p.m.
Message ID <1342204577-9605-1-git-send-email-msm@freescale.com>
Download mbox | patch
Permalink /patch/32053/
State New
Headers show

Comments

Matthew McClintock - July 13, 2012, 6:36 p.m.
> ERROR: QA Issue: gcc-runtime: Files/directories were installed but not shipped
>   /usr/lib/libgomp.so.1.0.0
>   /usr/lib/libgomp.so.1

Signed-off-by: Matthew McClintock <msm@freescale.com>
---
 meta/recipes-devtools/gcc/gcc-4.7.inc             |    2 +-
 meta/recipes-devtools/gcc/gcc-package-runtime.inc |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Khem Raj - July 13, 2012, 6:40 p.m.
On Fri, Jul 13, 2012 at 11:36 AM, Matthew McClintock <msm@freescale.com> wrote:
>> ERROR: QA Issue: gcc-runtime: Files/directories were installed but not shipped
>>   /usr/lib/libgomp.so.1.0.0
>>   /usr/lib/libgomp.so.1
>

that should go into the real libgomp package not -dev package


>  FILES_libgomp-dev = "\
> -  ${libdir}/libgomp*.so \
> +  ${libdir}/libgomp*.so* \
>    ${libdir}/libgomp*.la \
>    ${libdir}/libgomp.spec \
>    ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h \
> --
> 1.7.10
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
McClintock Matthew-B29882 - July 13, 2012, 6:43 p.m.
On Fri, Jul 13, 2012 at 1:40 PM, Khem Raj <raj.khem@gmail.com> wrote:
> On Fri, Jul 13, 2012 at 11:36 AM, Matthew McClintock <msm@freescale.com> wrote:
>>> ERROR: QA Issue: gcc-runtime: Files/directories were installed but not shipped
>>>   /usr/lib/libgomp.so.1.0.0
>>>   /usr/lib/libgomp.so.1
>>
>
> that should go into the real libgomp package not -dev package

Err... all the so files? Or just the new ones?

-M

>
>
>>  FILES_libgomp-dev = "\
>> -  ${libdir}/libgomp*.so \
>> +  ${libdir}/libgomp*.so* \
>>    ${libdir}/libgomp*.la \
>>    ${libdir}/libgomp.spec \
>>    ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h \
>> --
>> 1.7.10
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Khem Raj - July 13, 2012, 6:47 p.m.
On Fri, Jul 13, 2012 at 11:43 AM, McClintock Matthew-B29882
<B29882@freescale.com> wrote:
> On Fri, Jul 13, 2012 at 1:40 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Fri, Jul 13, 2012 at 11:36 AM, Matthew McClintock <msm@freescale.com> wrote:
>>>> ERROR: QA Issue: gcc-runtime: Files/directories were installed but not shipped
>>>>   /usr/lib/libgomp.so.1.0.0
>>>>   /usr/lib/libgomp.so.1
>>>
>>
>> that should go into the real libgomp package not -dev package
>
> Err... all the so files? Or just the new ones?

the ones that end with .so.* especially the above two.
.so will go into -dev

>
> -M
>
>>
>>
>>>  FILES_libgomp-dev = "\
>>> -  ${libdir}/libgomp*.so \
>>> +  ${libdir}/libgomp*.so* \
>>>    ${libdir}/libgomp*.la \
>>>    ${libdir}/libgomp.spec \
>>>    ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h \
>>> --
>>> 1.7.10
>>>
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Saul Wold - July 13, 2012, 6:54 p.m.
On 07/13/2012 11:47 AM, Khem Raj wrote:
> On Fri, Jul 13, 2012 at 11:43 AM, McClintock Matthew-B29882
> <B29882@freescale.com> wrote:
>> On Fri, Jul 13, 2012 at 1:40 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>> On Fri, Jul 13, 2012 at 11:36 AM, Matthew McClintock <msm@freescale.com> wrote:
>>>>> ERROR: QA Issue: gcc-runtime: Files/directories were installed but not shipped
>>>>>    /usr/lib/libgomp.so.1.0.0
>>>>>    /usr/lib/libgomp.so.1
>>>>
>>>
>>> that should go into the real libgomp package not -dev package
>>
>> Err... all the so files? Or just the new ones?
>
> the ones that end with .so.* especially the above two.
> .so will go into -dev
>
Yes, Khem is right, I thought you had them originally in the -dev for a 
reason, so that's where the SOLIBDEV and SOLIB extension can used as 
they define .so and .so.* respectively

Sau!

>>
>> -M
>>
>>>
>>>
>>>>   FILES_libgomp-dev = "\
>>>> -  ${libdir}/libgomp*.so \
>>>> +  ${libdir}/libgomp*.so* \
>>>>     ${libdir}/libgomp*.la \
>>>>     ${libdir}/libgomp.spec \
>>>>     ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h \
>>>> --
>>>> 1.7.10
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>

Patch

diff --git a/meta/recipes-devtools/gcc/gcc-4.7.inc b/meta/recipes-devtools/gcc/gcc-4.7.inc
index 0e40533..b3012d7 100644
--- a/meta/recipes-devtools/gcc/gcc-4.7.inc
+++ b/meta/recipes-devtools/gcc/gcc-4.7.inc
@@ -1,6 +1,6 @@ 
 require gcc-common.inc
 
-PR = "r5"
+PR = "r6"
 
 # Third digit in PV should be incremented after a minor release
 # happens from this branch on gcc e.g. currently its 4.7.1
diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
index a81e3b7..6c77fc3 100644
--- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
+++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
@@ -65,7 +65,7 @@  FILES_libmudflap-dev = "\
   ${libdir}/libmudflap*.la"
 
 FILES_libgomp-dev = "\
-  ${libdir}/libgomp*.so \
+  ${libdir}/libgomp*.so* \
   ${libdir}/libgomp*.la \
   ${libdir}/libgomp.spec \
   ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h \