diff mbox series

PATCH: dev-manual/new-recipe.rst: add missing parenthesis to "Patching Code" section

Message ID 09705a7fc497768ca30a5de2b500e573@crashcourse.ca
State New
Headers show
Series PATCH: dev-manual/new-recipe.rst: add missing parenthesis to "Patching Code" section | expand

Commit Message

Robert P. J. Day Oct. 12, 2023, 12:14 p.m. UTC
Add missing parenthesis, and another example of a compressed patch 
filename.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>

---

testing a new mail client so hoping it doesn't mangle patch submissions

Comments

Michael Opdenacker Oct. 16, 2023, 1:29 p.m. UTC | #1
Hi Robert

On 12.10.23 at 14:14, Robert P. J. Day wrote:
> Add missing parenthesis, and another example of a compressed patch 
> filename.
>
> Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
>
> ---
>
> testing a new mail client so hoping it doesn't mangle patch submissions


Thanks for the patch.
Not totally right, though, as you should have "[PATCH]" instead of just 
"PATCH". Otherwise, you get "PATCH" in the commit title.

Don't you use "git format-patch" and "git send-email" to prepare your 
patches? It's more fail-safe.

Anyway, I see that your next patch doesn't have this issue :)

After editing the subject
Reviewed-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
and merged into master-next.

Thanks again
Michael
diff mbox series

Patch

diff --git a/documentation/dev-manual/new-recipe.rst 
b/documentation/dev-manual/new-recipe.rst
index 02bb08474..e741cef0e 100644
--- a/documentation/dev-manual/new-recipe.rst
+++ b/documentation/dev-manual/new-recipe.rst
@@ -409,8 +409,8 @@  Patching Code

  Sometimes it is necessary to patch code after it has been fetched. Any
  files mentioned in :term:`SRC_URI` whose names end in ``.patch`` or
-``.diff`` or compressed versions of these suffixes (e.g. ``diff.gz`` 
are
-treated as patches. The
+``.diff`` or compressed versions of these suffixes (e.g. ``diff.gz``,
+``patch.bz2``, etc.) are treated as patches. The
  :ref:`ref-tasks-patch` task
  automatically applies these patches.