Patchwork [0/1] poky-default-revisions: move SRCREV to every recipe

login
register
mail settings
Submitter Frans Meulenbroeks
Date May 4, 2011, 2:24 p.m.
Message ID <BANLkTinduv4VofN2=adDN2-HZozYTO45ew@mail.gmail.com>
Download mbox | patch
Permalink /patch/3185/
State New, archived
Headers show

Comments

Frans Meulenbroeks - May 4, 2011, 2:24 p.m.
2011/5/4 Richard Purdie <richard.purdie@linuxfoundation.org>

> On Wed, 2011-05-04 at 22:05 +0800, Yu Ke wrote:
> > From: Yu Ke <ke.yu@intel.com>
> >
> > move the SRCREV from poky-default-revisions.inc to its corresponding
> recipe,
> > in this case, those non poky distro can also use its SRCREV.
> >
> > Pull URL: git://git.pokylinux.org/poky-contrib.git
> >   Branch: kyu3/srcrev-recipe
> >   Browse:
> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kyu3/srcrev-recipe
> >
> > Thanks,
> >     Yu Ke <ke.yu@intel.com>
> > ---
> >
> >
> > Yu Ke (1):
> >   poky-default-revisions: move the SRCREV to recipe file
>
> Merged to master, thanks for resolving this issue! :)
>
> Cheers,
>
> Richard
>
> I would have preferred a more standardised placement of SRCREV.
Most of the time the SRCREV is before the PV, but not always (and sometimes
separated with an empty line and sometimes not).

Also there is at least one error introduced:

That should be SRCDATE. There might be more of these, my eye just fell on
this one.

Frans

PS: speaking of yaffs2 utils: it could be considered to move to a somewhat
newer version (not that I care as I do not use yaffs2)
Richard Purdie - May 4, 2011, 4 p.m.
On Wed, 2011-05-04 at 16:24 +0200, Frans Meulenbroeks wrote:
> Most of the time the SRCREV is before the PV, but not always (and sometimes
> separated with an empty line and sometimes not).

Patches welcome...

> Also there is at least one error introduced:
> 
> diff --git a/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bbb/meta/recipes-devtools/yaffs2/
> yaffs2-utils_cvs.bb
> index 6171fe5..c729c7c 100644
> --- a/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb<http://git.pokylinux.org/cgit.cgi/poky-contrib/tree/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb?h=kyu3/srcrev-recipe&id=d2e078aa046ae6c4f169695f546cf229db5be1f7>
> +++ b/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb<http://git.pokylinux.org/cgit.cgi/poky-contrib/tree/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb?h=kyu3/srcrev-recipe&id=c75b49ff5cfd10f5187af2b66a0a8d5513460374>
> @@ -1,3 +1,4 @@
> require yaffs2-utils.inc
> PR = "r1"
> +SRCDAT = "20071107"
> 
> That should be SRCDATE. There might be more of these, my eye just fell on
> this one.

Good catch, we need to fix that.

> Frans
> 
> PS: speaking of yaffs2 utils: it could be considered to move to a somewhat
> newer version (not that I care as I do not use yaffs2)

It is something we should look at going, yes although I don't think
yaffs2 has changed that much in a while.

Cheers,

Richard
Frans Meulenbroeks - May 4, 2011, 5:10 p.m.
2011/5/4 Richard Purdie <richard.purdie@linuxfoundation.org>

> On Wed, 2011-05-04 at 16:24 +0200, Frans Meulenbroeks wrote:
> > Most of the time the SRCREV is before the PV, but not always (and
> sometimes
> > separated with an empty line and sometimes not).
>
> Patches welcome...
>

I know. It was more a hint for future changes.
Also this probably should be part of a more global style cleanup to make
things more according to the style guide.

[...]

> >
> > PS: speaking of yaffs2 utils: it could be considered to move to a
> somewhat
> > newer version (not that I care as I do not use yaffs2)
>
> It is something we should look at going, yes although I don't think
> yaffs2 has changed that much in a while.
>
> The latest changes are about 13 months old, but there seem to be quite some
changes since 2007 (although quite some seem cosmetical).

(btw there is also an abiword cvs recipe with a srcdate of 2007; somehow odd
given the number of regular releases abiword has).

Frans.
Yu Ke - May 5, 2011, 12:50 a.m.
on 2011-5-4 22:24, Frans Meulenbroeks wrote:
> 2011/5/4 Richard Purdie<richard.purdie@linuxfoundation.org>
>
>> On Wed, 2011-05-04 at 22:05 +0800, Yu Ke wrote:
>>> From: Yu Ke<ke.yu@intel.com>
>>>
>>> move the SRCREV from poky-default-revisions.inc to its corresponding
>> recipe,
>>> in this case, those non poky distro can also use its SRCREV.
>>>
>>> Pull URL: git://git.pokylinux.org/poky-contrib.git
>>>    Branch: kyu3/srcrev-recipe
>>>    Browse:
>> http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kyu3/srcrev-recipe
>>>
>>> Thanks,
>>>      Yu Ke<ke.yu@intel.com>
>>> ---
>>>
>>>
>>> Yu Ke (1):
>>>    poky-default-revisions: move the SRCREV to recipe file
>>
>> Merged to master, thanks for resolving this issue! :)
>>
>> Cheers,
>>
>> Richard
>>
>> I would have preferred a more standardised placement of SRCREV.
> Most of the time the SRCREV is before the PV, but not always (and sometimes
> separated with an empty line and sometimes not).
>
> Also there is at least one error introduced:
>
> diff --git a/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bbb/meta/recipes-devtools/yaffs2/
> yaffs2-utils_cvs.bb
> index 6171fe5..c729c7c 100644
> --- a/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb<http://git.pokylinux.org/cgit.cgi/poky-contrib/tree/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb?h=kyu3/srcrev-recipe&id=d2e078aa046ae6c4f169695f546cf229db5be1f7>
> +++ b/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb<http://git.pokylinux.org/cgit.cgi/poky-contrib/tree/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb?h=kyu3/srcrev-recipe&id=c75b49ff5cfd10f5187af2b66a0a8d5513460374>
> @@ -1,3 +1,4 @@
> require yaffs2-utils.inc
> PR = "r1"
> +SRCDAT = "20071107"
>
> That should be SRCDATE. There might be more of these, my eye just fell on
> this one.

Thanks for pointing it out. For unknown reason, my proxy does not work 
in cvs fetcher , so this recipe is untested. I should take more care on 
this. A patch is just sent out to fix it.

Regards
Ke

>
> Frans
>
> PS: speaking of yaffs2 utils: it could be considered to move to a somewhat
> newer version (not that I care as I do not use yaffs2)
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>

Patch

diff --git a/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bbb/meta/recipes-devtools/yaffs2/
yaffs2-utils_cvs.bb
index 6171fe5..c729c7c 100644
--- a/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb<http://git.pokylinux.org/cgit.cgi/poky-contrib/tree/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb?h=kyu3/srcrev-recipe&id=d2e078aa046ae6c4f169695f546cf229db5be1f7>
+++ b/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb<http://git.pokylinux.org/cgit.cgi/poky-contrib/tree/meta/recipes-devtools/yaffs2/yaffs2-utils_cvs.bb?h=kyu3/srcrev-recipe&id=c75b49ff5cfd10f5187af2b66a0a8d5513460374>
@@ -1,3 +1,4 @@ 
require yaffs2-utils.inc
PR = "r1"
+SRCDAT = "20071107"