Patchwork task-core-sdk.bb: add libgomp and libgomp-dev

login
register
mail settings
Submitter Zhenhua Luo
Date July 11, 2012, 12:01 p.m.
Message ID <1342008111-24810-1-git-send-email-b19537@freescale.com>
Download mbox | patch
Permalink /patch/31745/
State Superseded
Headers show

Comments

Zhenhua Luo - July 11, 2012, 12:01 p.m.
From: Zhenhua Luo <b19537@freescale.com>

Signed-off-by: Zhenhua Luo <b19537@freescale.com>
---
 meta/recipes-core/tasks/task-core-sdk.bb |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)
Richard Purdie - July 11, 2012, 1:28 p.m.
On Wed, 2012-07-11 at 20:01 +0800, b19537@freescale.com wrote:
> From: Zhenhua Luo <b19537@freescale.com>
> 
> Signed-off-by: Zhenhua Luo <b19537@freescale.com>
> ---
>  meta/recipes-core/tasks/task-core-sdk.bb |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-core/tasks/task-core-sdk.bb b/meta/recipes-core/tasks/task-core-sdk.bb
> index ec6cdcc..3ee29ce 100644
> --- a/meta/recipes-core/tasks/task-core-sdk.bb
> +++ b/meta/recipes-core/tasks/task-core-sdk.bb
> @@ -7,7 +7,7 @@ LICENSE = "MIT"
>  LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>                      file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>  DEPENDS = "task-core-console"
> -PR = "r7"
> +PR = "r8"
>  
>  ALLOW_EMPTY = "1"
>  #PACKAGEFUNCS =+ 'generate_sdk_pkgs'
> @@ -34,6 +34,8 @@ RDEPENDS_task-core-sdk = "\
>      gettext \
>      make \
>      intltool \
> +    libgomp \
> +    libgomp-dev \
>      libstdc++ \
>      libstdc++-dev \
>      libtool \

This will break for architectures which don't build libgomp (anything
not powerpc).

You could add a RRECOMMENDS?

Cheers,

Richard
Zhenhua Luo - July 11, 2012, 1:52 p.m.
Richard, 

Thanks for your comments, I will submit new version to use RRECOMMENDS. 


Best Regards,

Zhenhua

> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Richard Purdie
> Sent: Wednesday, July 11, 2012 9:29 PM
> To: Patches and discussions about the oe-core layer
> Subject: Re: [OE-core] [PATCH] task-core-sdk.bb: add libgomp and libgomp-
> dev
> 
> On Wed, 2012-07-11 at 20:01 +0800, b19537@freescale.com wrote:
> > From: Zhenhua Luo <b19537@freescale.com>
> >
> > Signed-off-by: Zhenhua Luo <b19537@freescale.com>
> > ---
> >  meta/recipes-core/tasks/task-core-sdk.bb |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/meta/recipes-core/tasks/task-core-sdk.bb
> > b/meta/recipes-core/tasks/task-core-sdk.bb
> > index ec6cdcc..3ee29ce 100644
> > --- a/meta/recipes-core/tasks/task-core-sdk.bb
> > +++ b/meta/recipes-core/tasks/task-core-sdk.bb
> > @@ -7,7 +7,7 @@ LICENSE = "MIT"
> >  LIC_FILES_CHKSUM =
> "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> >
> file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> >  DEPENDS = "task-core-console"
> > -PR = "r7"
> > +PR = "r8"
> >
> >  ALLOW_EMPTY = "1"
> >  #PACKAGEFUNCS =+ 'generate_sdk_pkgs'
> > @@ -34,6 +34,8 @@ RDEPENDS_task-core-sdk = "\
> >      gettext \
> >      make \
> >      intltool \
> > +    libgomp \
> > +    libgomp-dev \
> >      libstdc++ \
> >      libstdc++-dev \
> >      libtool \
> 
> This will break for architectures which don't build libgomp (anything not
> powerpc).
> 
> You could add a RRECOMMENDS?
> 
> Cheers,
> 
> Richard
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-core/tasks/task-core-sdk.bb b/meta/recipes-core/tasks/task-core-sdk.bb
index ec6cdcc..3ee29ce 100644
--- a/meta/recipes-core/tasks/task-core-sdk.bb
+++ b/meta/recipes-core/tasks/task-core-sdk.bb
@@ -7,7 +7,7 @@  LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
                     file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 DEPENDS = "task-core-console"
-PR = "r7"
+PR = "r8"
 
 ALLOW_EMPTY = "1"
 #PACKAGEFUNCS =+ 'generate_sdk_pkgs'
@@ -34,6 +34,8 @@  RDEPENDS_task-core-sdk = "\
     gettext \
     make \
     intltool \
+    libgomp \
+    libgomp-dev \
     libstdc++ \
     libstdc++-dev \
     libtool \