| Submitter | Raymond Danks |
|---|---|
| Date | July 10, 2012, 2:35 p.m. |
| Message ID | <1341930923-26277-1-git-send-email-ray.danks@se-eng.com> |
| Download | mbox | patch |
| Permalink | /patch/31635/ |
| State | New |
| Headers | show |
Comments
On 07/10/2012 07:35 AM, Raymond Danks wrote: > Address QA issue: Files/directories were installed but not shipped. > New revision contains patch to mkelfimage removing > /usr/share/mkelfImage/elf32-i386 directory from Makefile install target. > > http://review.coreboot.org/#/c/1195/ > > Signed-off-by: Raymond Danks <ray.danks@se-eng.com> > --- > v2: > Reword commit log > I hate to do this, but I am looking at the summary and it really does not tell me anything, a better summary would be something like: mkelfimage: corrected packaging issue in upstream ... Thanks Sau! > meta/recipes-devtools/mkelfimage/mkelfimage_git.bb | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb b/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb > index 1224a63..4b45c67 100644 > --- a/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb > +++ b/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb > @@ -4,7 +4,7 @@ SECTION = "devel" > LICENSE = "GPLv2" > LIC_FILES_CHKSUM = "file://COPYING;md5=ea5bed2f60d357618ca161ad539f7c0a" > > -SRCREV = "e13632a939e7dde8d7d44fc73e73a41dae8060c3" > +SRCREV = "e1e6a91ce0738400fa1615179de88ebc0df29f66" > PV = "1.0.0+gitr${SRCPV}" > PR = "r1" > >
On 07/10/2012 09:01 AM, Saul Wold wrote: > On 07/10/2012 07:35 AM, Raymond Danks wrote: >> Address QA issue: Files/directories were installed but not shipped. >> New revision contains patch to mkelfimage removing >> /usr/share/mkelfImage/elf32-i386 directory from Makefile install target. >> >> http://review.coreboot.org/#/c/1195/ >> >> Signed-off-by: Raymond Danks <ray.danks@se-eng.com> >> --- >> v2: >> Reword commit log >> > I hate to do this, but I am looking at the summary and it really does > not tell me anything, a better summary would be something like: > > mkelfimage: corrected packaging issue in upstream Saul, That's basically what the comment said before it was nacked. I'm not attached to the summary or the commit log. Feel free to do with it what you want. The change to the .bb file fixes the issue. Thanks, Ray > > ... > > Thanks > Sau! > >> meta/recipes-devtools/mkelfimage/mkelfimage_git.bb | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb >> b/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb >> index 1224a63..4b45c67 100644 >> --- a/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb >> +++ b/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb >> @@ -4,7 +4,7 @@ SECTION = "devel" >> LICENSE = "GPLv2" >> LIC_FILES_CHKSUM = >> "file://COPYING;md5=ea5bed2f60d357618ca161ad539f7c0a" >> >> -SRCREV = "e13632a939e7dde8d7d44fc73e73a41dae8060c3" >> +SRCREV = "e1e6a91ce0738400fa1615179de88ebc0df29f66" >> PV = "1.0.0+gitr${SRCPV}" >> PR = "r1" >> >> >
Patch
diff --git a/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb b/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb index 1224a63..4b45c67 100644 --- a/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb +++ b/meta/recipes-devtools/mkelfimage/mkelfimage_git.bb @@ -4,7 +4,7 @@ SECTION = "devel" LICENSE = "GPLv2" LIC_FILES_CHKSUM = "file://COPYING;md5=ea5bed2f60d357618ca161ad539f7c0a" -SRCREV = "e13632a939e7dde8d7d44fc73e73a41dae8060c3" +SRCREV = "e1e6a91ce0738400fa1615179de88ebc0df29f66" PV = "1.0.0+gitr${SRCPV}" PR = "r1"
Address QA issue: Files/directories were installed but not shipped. New revision contains patch to mkelfimage removing /usr/share/mkelfImage/elf32-i386 directory from Makefile install target. http://review.coreboot.org/#/c/1195/ Signed-off-by: Raymond Danks <ray.danks@se-eng.com> --- v2: Reword commit log meta/recipes-devtools/mkelfimage/mkelfimage_git.bb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)