Patchwork [bitbake-devel,5/5] fetch2/svn.py: Use "protocol" parameter and warn user if recipe is using "proto"

login
register
mail settings
Submitter Andrei Gherzan
Date July 10, 2012, 11:16 a.m.
Message ID <b6e8ccee34d81d6d11089a008d2d2996ed934c80.1341918809.git.andrei@gherzan.ro>
Download mbox | patch
Permalink /patch/31617/
State New
Headers show

Comments

Andrei Gherzan - July 10, 2012, 11:16 a.m.
If SRC_URI uses the parameter "proto" while specifying the protocol, use this
value but warn the user about this problem.

Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>
---
 bitbake/lib/bb/fetch2/svn.py |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Patch

diff --git a/bitbake/lib/bb/fetch2/svn.py b/bitbake/lib/bb/fetch2/svn.py
index bc5b96b..48adce8 100644
--- a/bitbake/lib/bb/fetch2/svn.py
+++ b/bitbake/lib/bb/fetch2/svn.py
@@ -71,7 +71,12 @@  class Svn(FetchMethod):
         command is "fetch", "update", "info"
         """
 
-        proto = ud.parm.get('proto', 'svn')
+        proto = ud.parm.get('protocol', 'svn')
+
+        if ud.parm.get('proto') is not None:
+            logger.warn('Update %s recipe to use "protocol" not "proto".', d.getVar('PN', True))
+            # Use proto value for now
+            proto =  ud.parm.get('proto')
 
         svn_rsh = None
         if proto == "svn+ssh" and "rsh" in ud.parm: