Patchwork [v2,2/2] libgomp: add libgomp (openmp) library, and build for powerpc targets by default

login
register
mail settings
Submitter Matthew McClintock
Date July 10, 2012, 4:29 a.m.
Message ID <1341894563-32675-2-git-send-email-msm@freescale.com>
Download mbox | patch
Permalink /patch/31599/
State New
Headers show

Comments

Matthew McClintock - July 10, 2012, 4:29 a.m.
Signed-off-by: Matthew McClintock <msm@freescale.com>
---
 meta/recipes-devtools/gcc/gcc-4.7.inc               |    2 +-
 meta/recipes-devtools/gcc/gcc-configure-runtime.inc |   10 ++++++++++
 meta/recipes-devtools/gcc/gcc-package-runtime.inc   |   14 +++++++++++++-
 3 files changed, 24 insertions(+), 2 deletions(-)
Khem Raj - July 10, 2012, 5:15 a.m.
On Mon, Jul 9, 2012 at 9:29 PM, Matthew McClintock <msm@freescale.com> wrote:
> +
> +       # clean up extra libgomp files
> +       if [[ "${RUNTIMETARGET}" =~ "libgomp" ]]; then

This seems bashism.

if could just check the valued of $d in the loop instead something like


> +               rm -rf ${D}${datadir}/info/libgomp.info ${D}${datadir}/info/dir
> +               rmdir --ignore-fail-on-non-empty -p ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/finclude
> +               rmdir --ignore-fail-on-non-empty -p ${D}${datadir}/info
> +       fi
> +
McClintock Matthew-B29882 - July 10, 2012, 2:52 p.m.
On Tue, Jul 10, 2012 at 12:15 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Mon, Jul 9, 2012 at 9:29 PM, Matthew McClintock <msm@freescale.com> wrote:
>> +
>> +       # clean up extra libgomp files
>> +       if [[ "${RUNTIMETARGET}" =~ "libgomp" ]]; then
>
> This seems bashism.
>
> if could just check the valued of $d in the loop instead something like

v3 sent.

-M

>
>
>> +               rm -rf ${D}${datadir}/info/libgomp.info ${D}${datadir}/info/dir
>> +               rmdir --ignore-fail-on-non-empty -p ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/finclude
>> +               rmdir --ignore-fail-on-non-empty -p ${D}${datadir}/info
>> +       fi
>> +
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Patch

diff --git a/meta/recipes-devtools/gcc/gcc-4.7.inc b/meta/recipes-devtools/gcc/gcc-4.7.inc
index c7dbc3c..be142a1 100644
--- a/meta/recipes-devtools/gcc/gcc-4.7.inc
+++ b/meta/recipes-devtools/gcc/gcc-4.7.inc
@@ -1,6 +1,6 @@ 
 require gcc-common.inc
 
-PR = "r3"
+PR = "r4"
 
 # Third digit in PV should be incremented after a minor release
 # happens from this branch on gcc e.g. currently its 4.7.1
diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
index 095d6c1..d0e49ce 100644
--- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
+++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
@@ -8,6 +8,8 @@  EXTRA_OECONF_PATHS = " \
     --with-build-sysroot=${STAGING_DIR_TARGET}"
 
 RUNTIMETARGET = "libssp libstdc++-v3"
+RUNTIMETARGET_append_powerpc = " libgomp"
+RUNTIMETARGET_append_powerpc64 = " libgomp"
 #  ?
 # libiberty
 # libmudflap
@@ -42,6 +44,14 @@  do_install () {
 		cd ${B}/$target/$d/
 		oe_runmake 'DESTDIR=${D}' MULTIBUILDTOP=${B}/$target/$d/ install
 	done
+
+	# clean up extra libgomp files
+	if [[ "${RUNTIMETARGET}" =~ "libgomp" ]]; then
+		rm -rf ${D}${datadir}/info/libgomp.info ${D}${datadir}/info/dir
+		rmdir --ignore-fail-on-non-empty -p ${D}${libdir}/gcc/${TARGET_SYS}/${BINV}/finclude
+		rmdir --ignore-fail-on-non-empty -p ${D}${datadir}/info
+	fi
+
 	chown -R root:root ${D}
 }
 
diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
index e0cb51b..a81e3b7 100644
--- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
+++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
@@ -13,6 +13,9 @@  PACKAGES = "\
   libgfortran-dev \
   libmudflap \
   libmudflap-dev \
+  libgomp \
+  libgomp-dev \
+  libgomp-staticdev \
 "
 # The base package doesn't exist, so we clear the recommends.
 RRECOMMENDS_${PN}-dbg = ""
@@ -61,7 +64,16 @@  FILES_libmudflap-dev = "\
   ${libdir}/libmudflap*.a \
   ${libdir}/libmudflap*.la"
 
+FILES_libgomp-dev = "\
+  ${libdir}/libgomp*.so \
+  ${libdir}/libgomp*.la \
+  ${libdir}/libgomp.spec \
+  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h \
+  "
+FILES_libgomp-staticdev = "\
+  ${libdir}/libgomp*.a \
+  "
+
 do_package_write_ipk[depends] += "virtual/${MLPREFIX}libc:do_package"
 do_package_write_deb[depends] += "virtual/${MLPREFIX}libc:do_package"
 do_package_write_rpm[depends] += "virtual/${MLPREFIX}libc:do_package"
-