Patchwork gnupg: ensure deterministic build by disabling libcurl

login
register
mail settings
Submitter Saul Wold
Date July 9, 2012, 10:04 p.m.
Message ID <1341871474-8719-1-git-send-email-sgw@linux.intel.com>
Download mbox | patch
Permalink /patch/31581/
State Accepted
Commit 44ea2cf548ca20488449d347f8f3b7d49f7e7493
Headers show

Comments

Saul Wold - July 9, 2012, 10:04 p.m.
gnupg has it's own fake curl, since we use gnupg with zypper, there does not
seem to be a strong reason to add curl to the depends list.

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-support/gnupg/gnupg_2.0.19.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
Khem Raj - July 9, 2012, 10:43 p.m.
On Mon, Jul 9, 2012 at 3:04 PM, Saul Wold <sgw@linux.intel.com> wrote:
> gnupg has it's own fake curl, since we use gnupg with zypper, there does not
> seem to be a strong reason to add curl to the depends list.

what does disabling curl has to do with gnupg being used with zypper ?
Saul Wold - July 9, 2012, 11:45 p.m.
On 07/09/2012 03:43 PM, Khem Raj wrote:
> On Mon, Jul 9, 2012 at 3:04 PM, Saul Wold <sgw@linux.intel.com> wrote:
>> gnupg has it's own fake curl, since we use gnupg with zypper, there does not
>> seem to be a strong reason to add curl to the depends list.
>
> what does disabling curl has to do with gnupg being used with zypper ?
>
I was looking for where gnupg was used within oe-core and it's usage 
model to see if it made sense to go with the extra dependency for gnupg, 
let me know your reasoning.  Generally especially for natives we look 
for ways to reduce the initial build time.

Sau!

> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
Khem Raj - July 10, 2012, 1:21 a.m.
On Mon, Jul 9, 2012 at 4:45 PM, Saul Wold <sgw@linux.intel.com> wrote:
> On 07/09/2012 03:43 PM, Khem Raj wrote:
>>
>> On Mon, Jul 9, 2012 at 3:04 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>>
>>> gnupg has it's own fake curl, since we use gnupg with zypper, there does
>>> not
>>> seem to be a strong reason to add curl to the depends list.
>>
>>
>> what does disabling curl has to do with gnupg being used with zypper ?
>>
> I was looking for where gnupg was used within oe-core and it's usage model
> to see if it made sense to go with the extra dependency for gnupg, let me
> know your reasoning.  Generally especially for natives we look for ways to
> reduce the initial build time.

I am all for it. I wanted to understand the context thanks for that.
On another note
it would be interesting to know what are we losing if we disable curl
or external curl

>
> Sau!
>
>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>>
>
Saul Wold - July 10, 2012, 6:26 p.m.
On 07/09/2012 06:21 PM, Khem Raj wrote:
> On Mon, Jul 9, 2012 at 4:45 PM, Saul Wold <sgw@linux.intel.com> wrote:
>> On 07/09/2012 03:43 PM, Khem Raj wrote:
>>>
>>> On Mon, Jul 9, 2012 at 3:04 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>>>
>>>> gnupg has it's own fake curl, since we use gnupg with zypper, there does
>>>> not
>>>> seem to be a strong reason to add curl to the depends list.
>>>
>>>
>>> what does disabling curl has to do with gnupg being used with zypper ?
>>>
>> I was looking for where gnupg was used within oe-core and it's usage model
>> to see if it made sense to go with the extra dependency for gnupg, let me
>> know your reasoning.  Generally especially for natives we look for ways to
>> reduce the initial build time.
>
> I am all for it. I wanted to understand the context thanks for that.
> On another note
Do you want me to amend the commit message?


> it would be interesting to know what are we losing if we disable curl
> or external curl
>
gnupg seems to use a very small subset of curl and the curl_shim that it 
provides covers what's need in a very basic manner (including handling 
proxy setups).  I would guess (after a cursory look) that we would lose 
better error handling and performance for the gpgkeys_curl command line 
interface.

I think that acceptable.

Sau!

>>
>> Sau!
>>
>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>>
>>>
>>
>
Khem Raj - July 10, 2012, 6:52 p.m.
On Tue, Jul 10, 2012 at 11:26 AM, Saul Wold <sgw@linux.intel.com> wrote:
> On 07/09/2012 06:21 PM, Khem Raj wrote:
>>
>> On Mon, Jul 9, 2012 at 4:45 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>>
>>> On 07/09/2012 03:43 PM, Khem Raj wrote:
>>>>
>>>>
>>>> On Mon, Jul 9, 2012 at 3:04 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>>>>
>>>>>
>>>>> gnupg has it's own fake curl, since we use gnupg with zypper, there
>>>>> does
>>>>> not
>>>>> seem to be a strong reason to add curl to the depends list.
>>>>
>>>>
>>>>
>>>> what does disabling curl has to do with gnupg being used with zypper ?
>>>>
>>> I was looking for where gnupg was used within oe-core and it's usage
>>> model
>>> to see if it made sense to go with the extra dependency for gnupg, let me
>>> know your reasoning.  Generally especially for natives we look for ways
>>> to
>>> reduce the initial build time.
>>
>>
>> I am all for it. I wanted to understand the context thanks for that.
>> On another note
>
> Do you want me to amend the commit message?
>
>
>
>> it would be interesting to know what are we losing if we disable curl
>> or external curl
>>
> gnupg seems to use a very small subset of curl and the curl_shim that it
> provides covers what's need in a very basic manner (including handling proxy
> setups).  I would guess (after a cursory look) that we would lose better
> error handling and performance for the gpgkeys_curl command line interface.
>
> I think that acceptable.
>


yes add good summary of this to commit log would help in future references

Patch

diff --git a/meta/recipes-support/gnupg/gnupg_2.0.19.bb b/meta/recipes-support/gnupg/gnupg_2.0.19.bb
index 24219a8..996a8e8 100644
--- a/meta/recipes-support/gnupg/gnupg_2.0.19.bb
+++ b/meta/recipes-support/gnupg/gnupg_2.0.19.bb
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=f27defe1e96c2e1ecd4e0c9be8967949 \
 DEPENDS = "${PTH} libassuan libksba zlib bzip2 readline libgcrypt"
 PTH = "pth"
 PTH_libc-uclibc = "npth"
-PR = "r3"
+PR = "r4"
 
 inherit autotools gettext
 
@@ -18,6 +18,7 @@  SRC_URI[sha256sum] = "efa23a8a925adb51c7d3b708c25b6d000300f5ce37de9bdec6453be7b4
 
 EXTRA_OECONF = "--disable-ldap \
 		--disable-ccid-driver \
+                --without-libcurl \
 		--with-zlib=${STAGING_LIBDIR}/.. \
 		--with-bzip2=${STAGING_LIBDIR}/.. \
                 --with-readline=${STAGING_LIBDIR}/.. \