Patchwork [15/15] pango: fix dependencies to avoid build issue

login
register
mail settings
Submitter Nitin A Kamble
Date July 9, 2012, 4:26 p.m.
Message ID <45d7793f0e3092f3ba4e03c52195ea13179ad1d8.1341850982.git.nitin.a.kamble@intel.com>
Download mbox | patch
Permalink /patch/31541/
State New
Headers show

Comments

Nitin A Kamble - July 9, 2012, 4:26 p.m.
From: Nitin A Kamble <nitin.a.kamble@intel.com>

this commit avoids this build issue:

| /srv/home/nitin/builds/build-gcc47/tmp/sysroots/x86_64-linux/usr/libexec/i586-poky-linux/gcc/i586-poky-linux/4.7.1/ld: cannot find -lelf
| collect2: error: ld returned 1 exit status
...
| make: *** [all] Error 2
| ERROR: oe_runmake failed
NOTE: package pango-1.28.4-r7: task do_compile: Failed

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
---
 meta/recipes-graphics/pango/pango.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Khem Raj - July 10, 2012, 5:20 a.m.
On Mon, Jul 9, 2012 at 9:26 AM,  <nitin.a.kamble@intel.com> wrote:
>
> | /srv/home/nitin/builds/build-gcc47/tmp/sysroots/x86_64-linux/usr/libexec/i586-poky-linux/gcc/i586-poky-linux/4.7.1/ld: cannot find -lelf
> | collect2: error: ld returned 1 exit status

I wonder why this is not seen generally. Is there something in your
build box thats triggering pango to ask for libelf ?
Richard Purdie - July 10, 2012, 12:12 p.m.
On Mon, 2012-07-09 at 09:26 -0700, nitin.a.kamble@intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble@intel.com>
> 
> this commit avoids this build issue:
> 
> | /srv/home/nitin/builds/build-gcc47/tmp/sysroots/x86_64-linux/usr/libexec/i586-poky-linux/gcc/i586-poky-linux/4.7.1/ld: cannot find -lelf
> | collect2: error: ld returned 1 exit status
> ...
> | make: *** [all] Error 2
> | ERROR: oe_runmake failed
> NOTE: package pango-1.28.4-r7: task do_compile: Failed
> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
> ---
>  meta/recipes-graphics/pango/pango.inc |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-graphics/pango/pango.inc b/meta/recipes-graphics/pango/pango.inc
> index fbf5027..754a720 100644
> --- a/meta/recipes-graphics/pango/pango.inc
> +++ b/meta/recipes-graphics/pango/pango.inc
> @@ -10,7 +10,7 @@ SECTION = "libs"
>  LICENSE = "LGPLv2.0+"
>  
>  X11DEPENDS = "virtual/libx11 libxft"
> -DEPENDS = "glib-2.0 fontconfig freetype zlib virtual/libiconv gtk-doc-native cairo "
> +DEPENDS = "glib-2.0 fontconfig freetype zlib virtual/libiconv gtk-doc-native cairo elfutils"
>  
>  PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"
>  PACKAGECONFIG[x11] = "--with-x,--without-x,${X11DEPENDS}"

I think rather than blindly adding the dependency, we need to figure out
what this is needed for. We had a similar issue with glib-2.0:

http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=38da655788361e949d605bebfab45cf5830df613

so I'm leaning to disabling this here.

Cheers,

Richard

Patch

diff --git a/meta/recipes-graphics/pango/pango.inc b/meta/recipes-graphics/pango/pango.inc
index fbf5027..754a720 100644
--- a/meta/recipes-graphics/pango/pango.inc
+++ b/meta/recipes-graphics/pango/pango.inc
@@ -10,7 +10,7 @@  SECTION = "libs"
 LICENSE = "LGPLv2.0+"
 
 X11DEPENDS = "virtual/libx11 libxft"
-DEPENDS = "glib-2.0 fontconfig freetype zlib virtual/libiconv gtk-doc-native cairo "
+DEPENDS = "glib-2.0 fontconfig freetype zlib virtual/libiconv gtk-doc-native cairo elfutils"
 
 PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"
 PACKAGECONFIG[x11] = "--with-x,--without-x,${X11DEPENDS}"