From patchwork Mon Jul 9 15:47:24 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [CONSOLIDATED, PULL, 10/41] gcc-common: Don't use "is" for comparing strings, use "==" Date: Mon, 09 Jul 2012 15:47:24 -0000 From: Saul Wold X-Patchwork-Id: 31447 Message-Id: <5221aabbe8f040f9264554febbc00e0926893beb.1341802889.git.sgw@linux.intel.com> To: openembedded-core@lists.openembedded.org From: Kartik Mohta Needed because the equality check was failing here even though upon printing the LHS and RHS were the same. As per http://stackoverflow.com/a/2987975/64537, using "is" compares the memory addresses of the two objects which is not what we want here. We just want to compare the values. Signed-off-by: Kartik Mohta --- meta/recipes-devtools/gcc/gcc-common.inc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/meta/recipes-devtools/gcc/gcc-common.inc b/meta/recipes-devtools/gcc/gcc-common.inc index 45828bb..0a9324a 100644 --- a/meta/recipes-devtools/gcc/gcc-common.inc +++ b/meta/recipes-devtools/gcc/gcc-common.inc @@ -10,7 +10,7 @@ inherit autotools gettext FILESDIR = "${@os.path.dirname(d.getVar('FILE',1))}/gcc-${PV}" def get_gcc_fpu_setting(bb, d): - if d.getVar('ARMPKGSFX_EABI', True) is "hf" and d.getVar('TRANSLATED_TARGET_ARCH', True) is "arm": + if d.getVar('ARMPKGSFX_EABI', True) == "hf" and d.getVar('TRANSLATED_TARGET_ARCH', True) == "arm": return "--with-float=hard" if d.getVar('TARGET_FPU', True) in [ 'soft' ]: return "--with-float=soft"