Patchwork [CONSOLIDATED,PULL,10/41] gcc-common: Don't use "is" for comparing strings, use "=="

mail settings
Submitter Saul Wold
Date July 9, 2012, 3:47 p.m.
Message ID <>
Download mbox | patch
Permalink /patch/31447/
State New
Headers show


Saul Wold - July 9, 2012, 3:47 p.m.
From: Kartik Mohta <>

Needed because the equality check was failing here even though upon
printing the LHS and RHS were the same.
As per, using "is" compares the
memory addresses of the two objects which is not what we want here. We
just want to compare the values.

Signed-off-by: Kartik Mohta <>
 meta/recipes-devtools/gcc/ |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


diff --git a/meta/recipes-devtools/gcc/ b/meta/recipes-devtools/gcc/
index 45828bb..0a9324a 100644
--- a/meta/recipes-devtools/gcc/
+++ b/meta/recipes-devtools/gcc/
@@ -10,7 +10,7 @@  inherit autotools gettext
 FILESDIR = "${@os.path.dirname(d.getVar('FILE',1))}/gcc-${PV}"
 def get_gcc_fpu_setting(bb, d):
-    if d.getVar('ARMPKGSFX_EABI', True) is "hf" and  d.getVar('TRANSLATED_TARGET_ARCH', True) is "arm":
+    if d.getVar('ARMPKGSFX_EABI', True) == "hf" and d.getVar('TRANSLATED_TARGET_ARCH', True) == "arm":
         return "--with-float=hard"
     if d.getVar('TARGET_FPU', True) in [ 'soft' ]:
         return "--with-float=soft"