Patchwork libgomp: add libgomp (openmp) library, and build for powerpc targets by default

login
register
mail settings
Submitter Matthew McClintock
Date July 6, 2012, 4:32 a.m.
Message ID <1341549155-30728-1-git-send-email-msm@freescale.com>
Download mbox | patch
Permalink /patch/31313/
State New
Headers show

Comments

Matthew McClintock - July 6, 2012, 4:32 a.m.
Signed-off-by: Matthew McClintock <msm@freescale.com>
---
 meta/recipes-devtools/gcc/gcc-4.6.inc               |    2 +-
 meta/recipes-devtools/gcc/gcc-configure-runtime.inc |    2 ++
 meta/recipes-devtools/gcc/gcc-package-runtime.inc   |    9 +++++++++
 3 files changed, 12 insertions(+), 1 deletion(-)
Khem Raj - July 6, 2012, 5:25 a.m.
On Thu, Jul 5, 2012 at 9:32 PM, Matthew McClintock <msm@freescale.com> wrote:
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>  meta/recipes-devtools/gcc/gcc-4.6.inc               |    2 +-
>  meta/recipes-devtools/gcc/gcc-configure-runtime.inc |    2 ++
>  meta/recipes-devtools/gcc/gcc-package-runtime.inc   |    9 +++++++++
>  3 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
> index 020e21b..32545eb 100644
> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
> @@ -1,6 +1,6 @@
>  require gcc-common.inc
>
> -PR = "r25"
> +PR = "r26"
>
>  # Third digit in PV should be incremented after a minor release
>  # happens from this branch on gcc e.g. currently its 4.6.0
> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> index 34bfaeb..a7d478c 100644
> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> @@ -9,6 +9,8 @@ EXTRA_OECONF_PATHS = " \
>      --with-build-sysroot=${STAGING_DIR_TARGET}"
>
>  RUNTIMETARGET = "libssp libstdc++-v3"
> +RUNTIMETARGET_append_powerpc = " libgomp"
> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>  #  ?
>  # libiberty
>  # libmudflap
> diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
> index feb8735..001a444 100644
> --- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
> @@ -13,6 +13,8 @@ PACKAGES = "\
>    libgfortran-dev \
>    libmudflap \
>    libmudflap-dev \
> +  libgomp \
> +  libgomp-dev \
>  "
>  # The base package doesn't exist, so we clear the recommends.
>  RRECOMMENDS_${PN}-dbg = ""
> @@ -61,3 +63,10 @@ FILES_libmudflap-dev = "\
>    ${libdir}/libmudflap*.a \
>    ${libdir}/libmudflap*.la"
>
> +FILES_libgomp = "${libdir}/libgomp*.so.*"
> +FILES_libgomp-dev = "\
> +  ${libdir}/libgomp*.so \
> +  ${libdir}/libgomp*.a \
> +  ${libdir}/libgomp*.la \
> +  ${libdir}/libgomp.spec \
> +  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h"

Did you build a non ppc architecture to verify that it does not
complain about empty packages ?

> --
> 1.7.10
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
McClintock Matthew-B29882 - July 6, 2012, 5:36 a.m.
On Fri, Jul 6, 2012 at 12:25 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Thu, Jul 5, 2012 at 9:32 PM, Matthew McClintock <msm@freescale.com> wrote:
>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>> ---
>>  meta/recipes-devtools/gcc/gcc-4.6.inc               |    2 +-
>>  meta/recipes-devtools/gcc/gcc-configure-runtime.inc |    2 ++
>>  meta/recipes-devtools/gcc/gcc-package-runtime.inc   |    9 +++++++++
>>  3 files changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
>> index 020e21b..32545eb 100644
>> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
>> @@ -1,6 +1,6 @@
>>  require gcc-common.inc
>>
>> -PR = "r25"
>> +PR = "r26"
>>
>>  # Third digit in PV should be incremented after a minor release
>>  # happens from this branch on gcc e.g. currently its 4.6.0
>> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>> index 34bfaeb..a7d478c 100644
>> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>> @@ -9,6 +9,8 @@ EXTRA_OECONF_PATHS = " \
>>      --with-build-sysroot=${STAGING_DIR_TARGET}"
>>
>>  RUNTIMETARGET = "libssp libstdc++-v3"
>> +RUNTIMETARGET_append_powerpc = " libgomp"
>> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>>  #  ?
>>  # libiberty
>>  # libmudflap
>> diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>> index feb8735..001a444 100644
>> --- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>> @@ -13,6 +13,8 @@ PACKAGES = "\
>>    libgfortran-dev \
>>    libmudflap \
>>    libmudflap-dev \
>> +  libgomp \
>> +  libgomp-dev \
>>  "
>>  # The base package doesn't exist, so we clear the recommends.
>>  RRECOMMENDS_${PN}-dbg = ""
>> @@ -61,3 +63,10 @@ FILES_libmudflap-dev = "\
>>    ${libdir}/libmudflap*.a \
>>    ${libdir}/libmudflap*.la"
>>
>> +FILES_libgomp = "${libdir}/libgomp*.so.*"
>> +FILES_libgomp-dev = "\
>> +  ${libdir}/libgomp*.so \
>> +  ${libdir}/libgomp*.a \
>> +  ${libdir}/libgomp*.la \
>> +  ${libdir}/libgomp.spec \
>> +  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h"
>
> Did you build a non ppc architecture to verify that it does not
> complain about empty packages ?

I tested without the powerpc overrides first...

-M

>
>> --
>> 1.7.10
>>
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Khem Raj - July 6, 2012, 6:13 a.m.
On Thu, Jul 5, 2012 at 10:36 PM, McClintock Matthew-B29882
<B29882@freescale.com> wrote:
> On Fri, Jul 6, 2012 at 12:25 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Thu, Jul 5, 2012 at 9:32 PM, Matthew McClintock <msm@freescale.com> wrote:
>>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>>> ---
>>>  meta/recipes-devtools/gcc/gcc-4.6.inc               |    2 +-
>>>  meta/recipes-devtools/gcc/gcc-configure-runtime.inc |    2 ++
>>>  meta/recipes-devtools/gcc/gcc-package-runtime.inc   |    9 +++++++++
>>>  3 files changed, 12 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
>>> index 020e21b..32545eb 100644
>>> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
>>> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
>>> @@ -1,6 +1,6 @@
>>>  require gcc-common.inc
>>>
>>> -PR = "r25"
>>> +PR = "r26"
>>>
>>>  # Third digit in PV should be incremented after a minor release
>>>  # happens from this branch on gcc e.g. currently its 4.6.0
>>> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>> index 34bfaeb..a7d478c 100644
>>> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>> @@ -9,6 +9,8 @@ EXTRA_OECONF_PATHS = " \
>>>      --with-build-sysroot=${STAGING_DIR_TARGET}"
>>>
>>>  RUNTIMETARGET = "libssp libstdc++-v3"
>>> +RUNTIMETARGET_append_powerpc = " libgomp"
>>> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>>>  #  ?
>>>  # libiberty
>>>  # libmudflap
>>> diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>> index feb8735..001a444 100644
>>> --- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>> +++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>> @@ -13,6 +13,8 @@ PACKAGES = "\
>>>    libgfortran-dev \
>>>    libmudflap \
>>>    libmudflap-dev \
>>> +  libgomp \
>>> +  libgomp-dev \
>>>  "
>>>  # The base package doesn't exist, so we clear the recommends.
>>>  RRECOMMENDS_${PN}-dbg = ""
>>> @@ -61,3 +63,10 @@ FILES_libmudflap-dev = "\
>>>    ${libdir}/libmudflap*.a \
>>>    ${libdir}/libmudflap*.la"
>>>
>>> +FILES_libgomp = "${libdir}/libgomp*.so.*"
>>> +FILES_libgomp-dev = "\
>>> +  ${libdir}/libgomp*.so \
>>> +  ${libdir}/libgomp*.a \
>>> +  ${libdir}/libgomp*.la \
>>> +  ${libdir}/libgomp.spec \
>>> +  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h"
>>
>> Did you build a non ppc architecture to verify that it does not
>> complain about empty packages ?
>
> I tested without the powerpc overrides first...

OK let me put it differently remove

+RUNTIMETARGET_append_powerpc = " libgomp"
+RUNTIMETARGET_append_powerpc64 = " libgomp"

and leave the rest of patch in

then build for powerpc

>
> -M
>
>>
>>> --
>>> 1.7.10
>>>
>>>
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
McClintock Matthew-B29882 - July 6, 2012, 2:26 p.m.
On Fri, Jul 6, 2012 at 1:13 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Thu, Jul 5, 2012 at 10:36 PM, McClintock Matthew-B29882
> <B29882@freescale.com> wrote:
>> On Fri, Jul 6, 2012 at 12:25 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>> On Thu, Jul 5, 2012 at 9:32 PM, Matthew McClintock <msm@freescale.com> wrote:
>>>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>>>> ---
>>>>  meta/recipes-devtools/gcc/gcc-4.6.inc               |    2 +-
>>>>  meta/recipes-devtools/gcc/gcc-configure-runtime.inc |    2 ++
>>>>  meta/recipes-devtools/gcc/gcc-package-runtime.inc   |    9 +++++++++
>>>>  3 files changed, 12 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>> index 020e21b..32545eb 100644
>>>> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>> @@ -1,6 +1,6 @@
>>>>  require gcc-common.inc
>>>>
>>>> -PR = "r25"
>>>> +PR = "r26"
>>>>
>>>>  # Third digit in PV should be incremented after a minor release
>>>>  # happens from this branch on gcc e.g. currently its 4.6.0
>>>> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>> index 34bfaeb..a7d478c 100644
>>>> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>> @@ -9,6 +9,8 @@ EXTRA_OECONF_PATHS = " \
>>>>      --with-build-sysroot=${STAGING_DIR_TARGET}"
>>>>
>>>>  RUNTIMETARGET = "libssp libstdc++-v3"
>>>> +RUNTIMETARGET_append_powerpc = " libgomp"
>>>> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>>>>  #  ?
>>>>  # libiberty
>>>>  # libmudflap
>>>> diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>> index feb8735..001a444 100644
>>>> --- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>> +++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>> @@ -13,6 +13,8 @@ PACKAGES = "\
>>>>    libgfortran-dev \
>>>>    libmudflap \
>>>>    libmudflap-dev \
>>>> +  libgomp \
>>>> +  libgomp-dev \
>>>>  "
>>>>  # The base package doesn't exist, so we clear the recommends.
>>>>  RRECOMMENDS_${PN}-dbg = ""
>>>> @@ -61,3 +63,10 @@ FILES_libmudflap-dev = "\
>>>>    ${libdir}/libmudflap*.a \
>>>>    ${libdir}/libmudflap*.la"
>>>>
>>>> +FILES_libgomp = "${libdir}/libgomp*.so.*"
>>>> +FILES_libgomp-dev = "\
>>>> +  ${libdir}/libgomp*.so \
>>>> +  ${libdir}/libgomp*.a \
>>>> +  ${libdir}/libgomp*.la \
>>>> +  ${libdir}/libgomp.spec \
>>>> +  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h"
>>>
>>> Did you build a non ppc architecture to verify that it does not
>>> complain about empty packages ?
>>
>> I tested without the powerpc overrides first...
>
> OK let me put it differently remove
>
> +RUNTIMETARGET_append_powerpc = " libgomp"
> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>
> and leave the rest of patch in
>
> then build for powerpc

That's what I'm saying I did... I did not even get libgomp packages
(rpm's) in this scenario....

-M


>
>>
>> -M
>>
>>>
>>>> --
>>>> 1.7.10
>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Khem Raj - July 6, 2012, 4:05 p.m.
On Fri, Jul 6, 2012 at 7:26 AM, McClintock Matthew-B29882
<B29882@freescale.com> wrote:
> On Fri, Jul 6, 2012 at 1:13 AM, Khem Raj <raj.khem@gmail.com> wrote:
>> On Thu, Jul 5, 2012 at 10:36 PM, McClintock Matthew-B29882
>> <B29882@freescale.com> wrote:
>>> On Fri, Jul 6, 2012 at 12:25 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>>> On Thu, Jul 5, 2012 at 9:32 PM, Matthew McClintock <msm@freescale.com> wrote:
>>>>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>>>>> ---
>>>>>  meta/recipes-devtools/gcc/gcc-4.6.inc               |    2 +-
>>>>>  meta/recipes-devtools/gcc/gcc-configure-runtime.inc |    2 ++
>>>>>  meta/recipes-devtools/gcc/gcc-package-runtime.inc   |    9 +++++++++
>>>>>  3 files changed, 12 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>>> index 020e21b..32545eb 100644
>>>>> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>>> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>>> @@ -1,6 +1,6 @@
>>>>>  require gcc-common.inc
>>>>>
>>>>> -PR = "r25"
>>>>> +PR = "r26"
>>>>>
>>>>>  # Third digit in PV should be incremented after a minor release
>>>>>  # happens from this branch on gcc e.g. currently its 4.6.0
>>>>> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>>> index 34bfaeb..a7d478c 100644
>>>>> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>>> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>>> @@ -9,6 +9,8 @@ EXTRA_OECONF_PATHS = " \
>>>>>      --with-build-sysroot=${STAGING_DIR_TARGET}"
>>>>>
>>>>>  RUNTIMETARGET = "libssp libstdc++-v3"
>>>>> +RUNTIMETARGET_append_powerpc = " libgomp"
>>>>> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>>>>>  #  ?
>>>>>  # libiberty
>>>>>  # libmudflap
>>>>> diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>>> index feb8735..001a444 100644
>>>>> --- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>>> +++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>>> @@ -13,6 +13,8 @@ PACKAGES = "\
>>>>>    libgfortran-dev \
>>>>>    libmudflap \
>>>>>    libmudflap-dev \
>>>>> +  libgomp \
>>>>> +  libgomp-dev \
>>>>>  "
>>>>>  # The base package doesn't exist, so we clear the recommends.
>>>>>  RRECOMMENDS_${PN}-dbg = ""
>>>>> @@ -61,3 +63,10 @@ FILES_libmudflap-dev = "\
>>>>>    ${libdir}/libmudflap*.a \
>>>>>    ${libdir}/libmudflap*.la"
>>>>>
>>>>> +FILES_libgomp = "${libdir}/libgomp*.so.*"
>>>>> +FILES_libgomp-dev = "\
>>>>> +  ${libdir}/libgomp*.so \
>>>>> +  ${libdir}/libgomp*.a \
>>>>> +  ${libdir}/libgomp*.la \
>>>>> +  ${libdir}/libgomp.spec \
>>>>> +  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h"
>>>>
>>>> Did you build a non ppc architecture to verify that it does not
>>>> complain about empty packages ?
>>>
>>> I tested without the powerpc overrides first...
>>
>> OK let me put it differently remove
>>
>> +RUNTIMETARGET_append_powerpc = " libgomp"
>> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>>
>> and leave the rest of patch in
>>
>> then build for powerpc
>
> That's what I'm saying I did... I did not even get libgomp packages
> (rpm's) in this scenario....

OK, Dont you get warnings about empty packages.

>
> -M
>
>
>>
>>>
>>> -M
>>>
>>>>
>>>>> --
>>>>> 1.7.10
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Openembedded-core mailing list
>>>>> Openembedded-core@lists.openembedded.org
>>>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>>>
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>>
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
McClintock Matthew-B29882 - July 6, 2012, 7:31 p.m.
On Fri, Jul 6, 2012 at 11:05 AM, Khem Raj <raj.khem@gmail.com> wrote:
> On Fri, Jul 6, 2012 at 7:26 AM, McClintock Matthew-B29882
> <B29882@freescale.com> wrote:
>> On Fri, Jul 6, 2012 at 1:13 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>> On Thu, Jul 5, 2012 at 10:36 PM, McClintock Matthew-B29882
>>> <B29882@freescale.com> wrote:
>>>> On Fri, Jul 6, 2012 at 12:25 AM, Khem Raj <raj.khem@gmail.com> wrote:
>>>>> On Thu, Jul 5, 2012 at 9:32 PM, Matthew McClintock <msm@freescale.com> wrote:
>>>>>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>>>>>> ---
>>>>>>  meta/recipes-devtools/gcc/gcc-4.6.inc               |    2 +-
>>>>>>  meta/recipes-devtools/gcc/gcc-configure-runtime.inc |    2 ++
>>>>>>  meta/recipes-devtools/gcc/gcc-package-runtime.inc   |    9 +++++++++
>>>>>>  3 files changed, 12 insertions(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>>>> index 020e21b..32545eb 100644
>>>>>> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>>>> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
>>>>>> @@ -1,6 +1,6 @@
>>>>>>  require gcc-common.inc
>>>>>>
>>>>>> -PR = "r25"
>>>>>> +PR = "r26"
>>>>>>
>>>>>>  # Third digit in PV should be incremented after a minor release
>>>>>>  # happens from this branch on gcc e.g. currently its 4.6.0
>>>>>> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>>>> index 34bfaeb..a7d478c 100644
>>>>>> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>>>> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>>>>>> @@ -9,6 +9,8 @@ EXTRA_OECONF_PATHS = " \
>>>>>>      --with-build-sysroot=${STAGING_DIR_TARGET}"
>>>>>>
>>>>>>  RUNTIMETARGET = "libssp libstdc++-v3"
>>>>>> +RUNTIMETARGET_append_powerpc = " libgomp"
>>>>>> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>>>>>>  #  ?
>>>>>>  # libiberty
>>>>>>  # libmudflap
>>>>>> diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>>>> index feb8735..001a444 100644
>>>>>> --- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>>>> +++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>>>>>> @@ -13,6 +13,8 @@ PACKAGES = "\
>>>>>>    libgfortran-dev \
>>>>>>    libmudflap \
>>>>>>    libmudflap-dev \
>>>>>> +  libgomp \
>>>>>> +  libgomp-dev \
>>>>>>  "
>>>>>>  # The base package doesn't exist, so we clear the recommends.
>>>>>>  RRECOMMENDS_${PN}-dbg = ""
>>>>>> @@ -61,3 +63,10 @@ FILES_libmudflap-dev = "\
>>>>>>    ${libdir}/libmudflap*.a \
>>>>>>    ${libdir}/libmudflap*.la"
>>>>>>
>>>>>> +FILES_libgomp = "${libdir}/libgomp*.so.*"
>>>>>> +FILES_libgomp-dev = "\
>>>>>> +  ${libdir}/libgomp*.so \
>>>>>> +  ${libdir}/libgomp*.a \
>>>>>> +  ${libdir}/libgomp*.la \
>>>>>> +  ${libdir}/libgomp.spec \
>>>>>> +  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h"
>>>>>
>>>>> Did you build a non ppc architecture to verify that it does not
>>>>> complain about empty packages ?
>>>>
>>>> I tested without the powerpc overrides first...
>>>
>>> OK let me put it differently remove
>>>
>>> +RUNTIMETARGET_append_powerpc = " libgomp"
>>> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>>>
>>> and leave the rest of patch in
>>>
>>> then build for powerpc
>>
>> That's what I'm saying I did... I did not even get libgomp packages
>> (rpm's) in this scenario....
>
> OK, Dont you get warnings about empty packages.

Let me double check.... it does not seem to have any such messages:

$ bitbake -c cleanall gcc-runtime
$ bitbake gcc-runtime
$ grep libgomp -r tmp/cooker.log.20120706190*

With your changes above starting from scratch with a PR bump for kicks
does not even make the packages.

-M
Saul Wold - July 8, 2012, 9:17 p.m.
On 07/05/2012 09:32 PM, Matthew McClintock wrote:
> Signed-off-by: Matthew McClintock <msm@freescale.com>
> ---
>   meta/recipes-devtools/gcc/gcc-4.6.inc               |    2 +-
>   meta/recipes-devtools/gcc/gcc-configure-runtime.inc |    2 ++
>   meta/recipes-devtools/gcc/gcc-package-runtime.inc   |    9 +++++++++
>   3 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
> index 020e21b..32545eb 100644
> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
> @@ -1,6 +1,6 @@
>   require gcc-common.inc
>
> -PR = "r25"
> +PR = "r26"
>
>   # Third digit in PV should be incremented after a minor release
>   # happens from this branch on gcc e.g. currently its 4.6.0
> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> index 34bfaeb..a7d478c 100644
> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
> @@ -9,6 +9,8 @@ EXTRA_OECONF_PATHS = " \
>       --with-build-sysroot=${STAGING_DIR_TARGET}"
>
>   RUNTIMETARGET = "libssp libstdc++-v3"
> +RUNTIMETARGET_append_powerpc = " libgomp"
> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>   #  ?
>   # libiberty
>   # libmudflap
> diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
> index feb8735..001a444 100644
> --- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
> +++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
> @@ -13,6 +13,8 @@ PACKAGES = "\
>     libgfortran-dev \
>     libmudflap \
>     libmudflap-dev \
> +  libgomp \
> +  libgomp-dev \
>   "
>   # The base package doesn't exist, so we clear the recommends.
>   RRECOMMENDS_${PN}-dbg = ""
> @@ -61,3 +63,10 @@ FILES_libmudflap-dev = "\
>     ${libdir}/libmudflap*.a \
>     ${libdir}/libmudflap*.la"
>
> +FILES_libgomp = "${libdir}/libgomp*.so.*"
> +FILES_libgomp-dev = "\
> +  ${libdir}/libgomp*.so \
> +  ${libdir}/libgomp*.a \
> +  ${libdir}/libgomp*.la \
> +  ${libdir}/libgomp.spec \
> +  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h"
>

I should have noticed this before, but it took a build failure!  Did you 
intend to have a ".a" in the -dev package vs the -staticdav package?

> ERROR: QA Issue: non -staticdev package contains static .a library: libgomp-dev path '/work/ppc603e-poky-linux/gcc-runtime-4.7.1+svnr188658-r2/packages-split/libgomp-dev/usr/lib/libgomp.a'
> ERROR: QA run found fatal errors. Please consider fixing them.
> ERROR: Function failed: do_package_qa
> ERROR: Logfile of failure stored in: /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/gcc-runtime-4.7.1+svnr188658-r2/temp/log.do_package.15360
> NOTE: package gcc-runtime-4.7.1+svnr188658-r2: task do_package: Failed
> ERROR: Task 654 (/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/meta/recipes-devtools/gcc/gcc-runtime_4.7.bb, do_package) failed with exit code '1'

Sau!
Saul Wold - July 8, 2012, 9:19 p.m.
On 07/08/2012 02:17 PM, Saul Wold wrote:
> On 07/05/2012 09:32 PM, Matthew McClintock wrote:
>> Signed-off-by: Matthew McClintock <msm@freescale.com>
>> ---
>>   meta/recipes-devtools/gcc/gcc-4.6.inc               |    2 +-
>>   meta/recipes-devtools/gcc/gcc-configure-runtime.inc |    2 ++
>>   meta/recipes-devtools/gcc/gcc-package-runtime.inc   |    9 +++++++++
>>   3 files changed, 12 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc
>> b/meta/recipes-devtools/gcc/gcc-4.6.inc
>> index 020e21b..32545eb 100644
>> --- a/meta/recipes-devtools/gcc/gcc-4.6.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
>> @@ -1,6 +1,6 @@
>>   require gcc-common.inc
>>
>> -PR = "r25"
>> +PR = "r26"
>>
>>   # Third digit in PV should be incremented after a minor release
>>   # happens from this branch on gcc e.g. currently its 4.6.0
>> diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>> b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>> index 34bfaeb..a7d478c 100644
>> --- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
>> @@ -9,6 +9,8 @@ EXTRA_OECONF_PATHS = " \
>>       --with-build-sysroot=${STAGING_DIR_TARGET}"
>>
>>   RUNTIMETARGET = "libssp libstdc++-v3"
>> +RUNTIMETARGET_append_powerpc = " libgomp"
>> +RUNTIMETARGET_append_powerpc64 = " libgomp"
>>   #  ?
>>   # libiberty
>>   # libmudflap
>> diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>> b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>> index feb8735..001a444 100644
>> --- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>> +++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
>> @@ -13,6 +13,8 @@ PACKAGES = "\
>>     libgfortran-dev \
>>     libmudflap \
>>     libmudflap-dev \
>> +  libgomp \
>> +  libgomp-dev \
>>   "
>>   # The base package doesn't exist, so we clear the recommends.
>>   RRECOMMENDS_${PN}-dbg = ""
>> @@ -61,3 +63,10 @@ FILES_libmudflap-dev = "\
>>     ${libdir}/libmudflap*.a \
>>     ${libdir}/libmudflap*.la"
>>
>> +FILES_libgomp = "${libdir}/libgomp*.so.*"
>> +FILES_libgomp-dev = "\
>> +  ${libdir}/libgomp*.so \
>> +  ${libdir}/libgomp*.a \
>> +  ${libdir}/libgomp*.la \
>> +  ${libdir}/libgomp.spec \
>> +  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h"
>>
>
> I should have noticed this before, but it took a build failure!  Did you
> intend to have a ".a" in the -dev package vs the -staticdav package?
>
>> ERROR: QA Issue: non -staticdev package contains static .a library:
>> libgomp-dev path
>> '/work/ppc603e-poky-linux/gcc-runtime-4.7.1+svnr188658-r2/packages-split/libgomp-dev/usr/lib/libgomp.a'
>>
>> ERROR: QA run found fatal errors. Please consider fixing them.
>> ERROR: Function failed: do_package_qa
>> ERROR: Logfile of failure stored in:
>> /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/gcc-runtime-4.7.1+svnr188658-r2/temp/log.do_package.15360
>>
>> NOTE: package gcc-runtime-4.7.1+svnr188658-r2: task do_package: Failed
>> ERROR: Task 654
>> (/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/meta/recipes-devtools/gcc/gcc-runtime_4.7.bb,
>> do_package) failed with exit code '1'
>

And one more packaging issue:
> ERROR: QA Issue: gcc-runtime: Files/directories were installed but not shipped
>   /usr/lib/gcc/powerpc-poky-linux/4.7.2/finclude
>   /usr/share/info
>   /usr/share/info/libgomp.info
>   /usr/share/info/dir


Sau!


> Sau!
>
>
>
>
McClintock Matthew-B29882 - July 9, 2012, 8:09 p.m.
On Sun, Jul 8, 2012 at 4:19 PM, Saul Wold <sgw@linux.intel.com> wrote:
>   /usr/share/info/dir

I don't see this dir on my build... perhaps it's the specific version
of gcc? or it's some munged text output?

If you still see if can you add it to the patch? v2 coming shortly.

-M
McClintock Matthew-B29882 - July 9, 2012, 8:35 p.m.
On Mon, Jul 9, 2012 at 3:09 PM, Matthew McClintock <msm@freescale.com> wrote:
> On Sun, Jul 8, 2012 at 4:19 PM, Saul Wold <sgw@linux.intel.com> wrote:
>>   /usr/share/info/dir
>
> I don't see this dir on my build... perhaps it's the specific version
> of gcc? or it's some munged text output?
>
> If you still see if can you add it to the patch? v2 coming shortly.

Nevermind, I do see this dir. Will fix.

-M

Patch

diff --git a/meta/recipes-devtools/gcc/gcc-4.6.inc b/meta/recipes-devtools/gcc/gcc-4.6.inc
index 020e21b..32545eb 100644
--- a/meta/recipes-devtools/gcc/gcc-4.6.inc
+++ b/meta/recipes-devtools/gcc/gcc-4.6.inc
@@ -1,6 +1,6 @@ 
 require gcc-common.inc
 
-PR = "r25"
+PR = "r26"
 
 # Third digit in PV should be incremented after a minor release
 # happens from this branch on gcc e.g. currently its 4.6.0
diff --git a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
index 34bfaeb..a7d478c 100644
--- a/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
+++ b/meta/recipes-devtools/gcc/gcc-configure-runtime.inc
@@ -9,6 +9,8 @@  EXTRA_OECONF_PATHS = " \
     --with-build-sysroot=${STAGING_DIR_TARGET}"
 
 RUNTIMETARGET = "libssp libstdc++-v3"
+RUNTIMETARGET_append_powerpc = " libgomp"
+RUNTIMETARGET_append_powerpc64 = " libgomp"
 #  ?
 # libiberty
 # libmudflap
diff --git a/meta/recipes-devtools/gcc/gcc-package-runtime.inc b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
index feb8735..001a444 100644
--- a/meta/recipes-devtools/gcc/gcc-package-runtime.inc
+++ b/meta/recipes-devtools/gcc/gcc-package-runtime.inc
@@ -13,6 +13,8 @@  PACKAGES = "\
   libgfortran-dev \
   libmudflap \
   libmudflap-dev \
+  libgomp \
+  libgomp-dev \
 "
 # The base package doesn't exist, so we clear the recommends.
 RRECOMMENDS_${PN}-dbg = ""
@@ -61,3 +63,10 @@  FILES_libmudflap-dev = "\
   ${libdir}/libmudflap*.a \
   ${libdir}/libmudflap*.la"
 
+FILES_libgomp = "${libdir}/libgomp*.so.*"
+FILES_libgomp-dev = "\
+  ${libdir}/libgomp*.so \
+  ${libdir}/libgomp*.a \
+  ${libdir}/libgomp*.la \
+  ${libdir}/libgomp.spec \
+  ${libdir}/gcc/${TARGET_SYS}/${BINV}/include/omp.h"